Re: [ros-dev] [ros-diffs] [greatlrd] 26246: fixing the build for gcc 3.4.5

[gerard.murphy]

Why have all these 'initialization bugs' suddenly been highlighted, and only
in GCC 3.4.5

Has the latest PSEH code highlighted a GCC 3.4.5 issue which we are just
hiding by double initializing variables??
We've seen initialization bugs with 3.4.5 before but always ignored them as
they appear in development. This is on a different scale.

Taking the AFD as an example, as this was also briefly batted around in IRC,
line 769 holds:

PDEVICE_OBJECT DeviceObject;

Line 773 then holds:

DeviceObject = IoGetRelatedDeviceObject(TransportObject);

This is before any calls to _SEH_TRY, so it's not an issue of stuff being
wrapped in PSEH 

In the words of Mr. Poussineau
- if error message is correct, fix the bug
- if error message is incorrect, report to GCC

Therefore as this code is not a real error, we should either send a bug
report off to mingw, or more realistically, drop 3.4.5 and move to 4.1.2 (as
the latest RosBE already does).
We shouldn't really be hiding incorrect errors by double initializing.

Ged.



-----Original Message-----
From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]]
On Behalf Of greatlrd(a)svn.reactos.org
Sent: 02 April 2007 10:49
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [greatlrd] 26246: fixing the build for gcc 3.4.5

Author: greatlrd
Date: Mon Apr  2 13:48:51 2007
New Revision: 26246

URL: http://svn.reactos.org/svn/reactos?rev=26246&view=rev
Log:
fixing the build for gcc 3.4.5

Modified:
    trunk/reactos/ntoskrnl/cm/ntfunc.c
    trunk/reactos/ntoskrnl/ex/sysinfo.c
    trunk/reactos/ntoskrnl/ex/timer.c
    trunk/reactos/ntoskrnl/fsrtl/fastio.c
    trunk/reactos/ntoskrnl/io/iomgr/driver.c
    trunk/reactos/ntoskrnl/io/iomgr/file.c
    trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
    trunk/reactos/ntoskrnl/io/iomgr/irp.c
    trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
    trunk/reactos/ntoskrnl/ke/i386/usercall.c
    trunk/reactos/ntoskrnl/ke/thrdobj.c
    trunk/reactos/ntoskrnl/mm/section.c
    trunk/reactos/ntoskrnl/mm/virtual.c
    trunk/reactos/ntoskrnl/ob/obdir.c
    trunk/reactos/ntoskrnl/ob/obhandle.c
    trunk/reactos/ntoskrnl/ob/obwait.c
    trunk/reactos/ntoskrnl/ps/job.c
    trunk/reactos/ntoskrnl/ps/query.c
    trunk/reactos/ntoskrnl/ps/thread.c
    trunk/reactos/ntoskrnl/se/acl.c
    trunk/reactos/ntoskrnl/se/priv.c
    trunk/reactos/ntoskrnl/se/sd.c
    trunk/reactos/ntoskrnl/se/sid.c
    trunk/reactos/ntoskrnl/se/token.c

Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/ntfunc.c?rev=26
246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/cm/ntfunc.c (original)
+++ trunk/reactos/ntoskrnl/cm/ntfunc.c Mon Apr  2 13:48:51 2007
@@ -299,7 +299,7 @@
   unsigned i;
   REG_PRE_CREATE_KEY_INFORMATION PreCreateKeyInfo;
   REG_POST_CREATE_KEY_INFORMATION PostCreateKeyInfo;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   UNICODE_STRING CapturedClass = {0};
   HANDLE hKey;
 
@@ -1308,7 +1308,7 @@
 	  IN POBJECT_ATTRIBUTES ObjectAttributes)
 {
   UNICODE_STRING RemainingPath;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   PVOID Object = NULL;
   HANDLE hKey = NULL;
   NTSTATUS Status = STATUS_SUCCESS;
@@ -2145,7 +2145,7 @@
   NTSTATUS Status;
   REG_DELETE_VALUE_KEY_INFORMATION DeleteValueKeyInfo;
   REG_POST_OPERATION_INFORMATION PostOperationInfo;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   UNICODE_STRING CapturedValueName;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=2
6246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ex/sysinfo.c (original)
+++ trunk/reactos/ntoskrnl/ex/sysinfo.c Mon Apr  2 13:48:51 2007
@@ -232,10 +232,10 @@
   ANSI_STRING AName;
   UNICODE_STRING WName;
   BOOLEAN Result;
-  PCH Value;
+  PCH Value = NULL;
   ANSI_STRING AValue;
   UNICODE_STRING WValue;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();
@@ -378,7 +378,7 @@
 {
   UNICODE_STRING CapturedName, CapturedValue;
   ANSI_STRING AName, AValue;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   NTSTATUS Status;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/ex/timer.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/timer.c?rev=262
46&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ex/timer.c (original)
+++ trunk/reactos/ntoskrnl/ex/timer.c Mon Apr  2 13:48:51 2007
@@ -510,7 +510,7 @@
 {
     PETIMER Timer;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
-    NTSTATUS Status;
+    NTSTATUS Status = STATUS_UNSUCCESSFUL;
     PTIMER_BASIC_INFORMATION BasicInfo = TimerInformation;
     PAGED_CODE();
 

Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/fastio.c?rev
=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/fsrtl/fastio.c (original)
+++ trunk/reactos/ntoskrnl/fsrtl/fastio.c Mon Apr  2 13:48:51 2007
@@ -83,7 +83,7 @@
               IN PDEVICE_OBJECT DeviceObject)
 {
 
-    PFSRTL_COMMON_FCB_HEADER FcbHeader;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
     LARGE_INTEGER Offset;
     PFAST_IO_DISPATCH FastIoDispatch;
     PDEVICE_OBJECT Device;
@@ -258,7 +258,7 @@
     BOOLEAN Result = TRUE;
     PFAST_IO_DISPATCH FastIoDispatch;
     PDEVICE_OBJECT Device;
-    PFSRTL_COMMON_FCB_HEADER FcbHeader;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
 
     /* WDK doc. Offset=0xffffffffffffffff indicates append to the end of
file */
     BOOLEAN FileOffsetAppend = ((FileOffset->HighPart == 0xffffffff) &&
(FileOffset->LowPart == 0xffffffff));
@@ -915,7 +915,7 @@
                 OUT PIO_STATUS_BLOCK IoStatus,
                 IN PDEVICE_OBJECT DeviceObject)
 {
-    PFSRTL_COMMON_FCB_HEADER FcbHeader;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
     BOOLEAN Result = TRUE;
     LARGE_INTEGER Offset;
     PFAST_IO_DISPATCH FastIoDispatch;
@@ -1159,7 +1159,7 @@
     BOOLEAN Result = TRUE;
     PFAST_IO_DISPATCH FastIoDispatch;
     PDEVICE_OBJECT Device;
-    PFSRTL_COMMON_FCB_HEADER FcbHeader;
+    PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL;
     
     LARGE_INTEGER OldFileSize;
     LARGE_INTEGER OldValidDataLength;

Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c?
rev=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Mon Apr  2 13:48:51 2007
@@ -1475,7 +1475,7 @@
    UNICODE_STRING ImagePath;
    UNICODE_STRING ServiceName;
    UNICODE_STRING CapturedDriverServiceName = {0};
-   KPROCESSOR_MODE PreviousMode;
+   KPROCESSOR_MODE PreviousMode = {0};
    NTSTATUS Status;
    ULONG Type;
    PDEVICE_NODE DeviceNode;

Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?re
v=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/io/iomgr/file.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c Mon Apr  2 13:48:51 2007
@@ -1629,7 +1629,7 @@
              IN PVOID ExtraCreateParameters OPTIONAL,
              IN ULONG Options)
 {
-    KPROCESSOR_MODE AccessMode;
+    KPROCESSOR_MODE AccessMode = {0};
     HANDLE LocalHandle = 0;
     LARGE_INTEGER SafeAllocationSize;
     PVOID SystemEaBuffer = NULL;

Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c?
rev=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Mon Apr  2 13:48:51 2007
@@ -198,12 +198,12 @@
 {
     NTSTATUS Status = STATUS_SUCCESS;
     PFILE_OBJECT FileObject;
-    PDEVICE_OBJECT DeviceObject;
-    PIRP Irp;
+    PDEVICE_OBJECT DeviceObject = NULL;
+    PIRP Irp = NULL;
     PIO_STACK_LOCATION StackPtr;
     PKEVENT EventObject = NULL;
     BOOLEAN LockedForSynch = FALSE;
-    ULONG AccessType;
+    ULONG AccessType = 0;
     OBJECT_HANDLE_INFORMATION HandleInformation;
     ACCESS_MASK DesiredAccess;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
@@ -1212,9 +1212,9 @@
 {
     PFILE_OBJECT FileObject;
     PLARGE_INTEGER LocalLength = NULL;
-    PIRP Irp;
-    PIO_STACK_LOCATION StackPtr;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PKEVENT Event = NULL;
     BOOLEAN LockedForSync = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
@@ -1386,8 +1386,8 @@
                      IN PUNICODE_STRING FileName OPTIONAL,
                      IN BOOLEAN RestartScan)
 {
-    PIRP Irp;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PFILE_OBJECT FileObject;
     PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
@@ -1627,9 +1627,9 @@
     OBJECT_HANDLE_INFORMATION HandleInformation;
     PFILE_OBJECT FileObject;
     NTSTATUS Status = STATUS_SUCCESS;
-    PIRP Irp;
-    PDEVICE_OBJECT DeviceObject;
-    PIO_STACK_LOCATION StackPtr;
+    PIRP Irp = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
@@ -1938,8 +1938,8 @@
 {
     NTSTATUS Status = STATUS_SUCCESS;
     PFILE_OBJECT FileObject;
-    PIRP Irp;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
     PKEVENT EventObject = NULL;
@@ -2197,9 +2197,9 @@
 {
     PFILE_OBJECT FileObject;
     NTSTATUS Status = STATUS_SUCCESS;
-    PIRP Irp;
-    PDEVICE_OBJECT DeviceObject;
-    PIO_STACK_LOCATION StackPtr;
+    PIRP Irp = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
@@ -2576,9 +2576,9 @@
 {
     PFILE_OBJECT FileObject;
     PLARGE_INTEGER LocalLength = NULL;
-    PIRP Irp;
-    PIO_STACK_LOCATION StackPtr;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
@@ -2760,8 +2760,8 @@
 {
     NTSTATUS Status = STATUS_SUCCESS;
     PFILE_OBJECT FileObject;
-    PIRP Irp;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PIO_STACK_LOCATION StackPtr;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
     PKEVENT EventObject = NULL;
@@ -3027,9 +3027,9 @@
                              IN FS_INFORMATION_CLASS FsInformationClass)
 {
     PFILE_OBJECT FileObject;
-    PIRP Irp;
-    PIO_STACK_LOCATION StackPtr;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();
@@ -3190,9 +3190,9 @@
                            IN FS_INFORMATION_CLASS FsInformationClass)
 {
     PFILE_OBJECT FileObject;
-    PIRP Irp;
-    PIO_STACK_LOCATION StackPtr;
-    PDEVICE_OBJECT DeviceObject;
+    PIRP Irp = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
+    PDEVICE_OBJECT DeviceObject = NULL;
     PKEVENT Event = NULL;
     BOOLEAN LocalEvent = FALSE;
     KPROCESSOR_MODE PreviousMode = KeGetPreviousMode();

Modified: trunk/reactos/ntoskrnl/io/iomgr/irp.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irp.c?rev
=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/io/iomgr/irp.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/irp.c Mon Apr  2 13:48:51 2007
@@ -610,8 +610,8 @@
                               IN PLARGE_INTEGER StartingOffset,
                               IN PIO_STATUS_BLOCK IoStatusBlock)
 {
-    PIRP Irp;
-    PIO_STACK_LOCATION StackPtr;
+    PIRP Irp = NULL;
+    PIO_STACK_LOCATION StackPtr = NULL;
 
     /* Allocate IRP */
     Irp = IoAllocateIrp(DeviceObject->StackSize, FALSE);
@@ -745,7 +745,7 @@
                               IN PKEVENT Event,
                               IN PIO_STATUS_BLOCK IoStatusBlock)
 {
-    PIRP Irp;
+    PIRP Irp = NULL;
     PIO_STACK_LOCATION StackPtr;
     ULONG BufferLength;
 

Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugplay
.c?rev=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c (original)
+++ trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c Mon Apr  2 13:48:51 2007
@@ -443,7 +443,7 @@
     UNICODE_STRING DeviceInstance;
     ULONG BufferSize;
     ULONG Property = 0;
-    PVOID Buffer;
+    PVOID Buffer = NULL;
 
     DPRINT("IopGetDeviceProperty() called\n");
     DPRINT("Device name: %wZ\n", &PropertyData->DeviceInstance);

Modified: trunk/reactos/ntoskrnl/ke/i386/usercall.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/usercall.c
?rev=26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ke/i386/usercall.c (original)
+++ trunk/reactos/ntoskrnl/ke/i386/usercall.c Mon Apr  2 13:48:51 2007
@@ -148,8 +148,8 @@
                    OUT PVOID *Result,
                    OUT PULONG ResultLength)
 {
-    ULONG_PTR NewStack, OldStack;
-    PULONG UserEsp;
+    ULONG_PTR NewStack =0, OldStack = 0;
+    PULONG UserEsp = NULL;
     NTSTATUS CallbackStatus = STATUS_SUCCESS;
     PEXCEPTION_REGISTRATION_RECORD ExceptionList;
     PTEB Teb;

Modified: trunk/reactos/ntoskrnl/ke/thrdobj.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/thrdobj.c?rev=2
6246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ke/thrdobj.c (original)
+++ trunk/reactos/ntoskrnl/ke/thrdobj.c Mon Apr  2 13:48:51 2007
@@ -723,7 +723,7 @@
     ULONG i;
     PKWAIT_BLOCK TimerWaitBlock;
     PKTIMER Timer;
-    NTSTATUS Status;
+    NTSTATUS Status = STATUS_UNSUCCESSFUL;
 
     /* Initalize the Dispatcher Header */
     KeInitializeDispatcherHeader(&Thread->DispatcherHeader,

Modified: trunk/reactos/ntoskrnl/mm/section.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=2
6246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/mm/section.c (original)
+++ trunk/reactos/ntoskrnl/mm/section.c Mon Apr  2 13:48:51 2007
@@ -3670,7 +3670,7 @@
    SIZE_T SafeViewSize;
    PROS_SECTION_OBJECT Section;
    PEPROCESS Process;
-   KPROCESSOR_MODE PreviousMode;
+   KPROCESSOR_MODE PreviousMode = {0};
    PMADDRESS_SPACE AddressSpace;
    NTSTATUS Status = STATUS_SUCCESS;
    ULONG tmpProtect;

Modified: trunk/reactos/ntoskrnl/mm/virtual.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=2
6246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/mm/virtual.c (original)
+++ trunk/reactos/ntoskrnl/mm/virtual.c Mon Apr  2 13:48:51 2007
@@ -554,10 +554,10 @@
                     IN ULONG NumberOfBytesToRead,
                     OUT PULONG NumberOfBytesRead OPTIONAL)
 {
-   PMDL Mdl;
+   PMDL Mdl = NULL;
    PVOID SystemAddress;
-   KPROCESSOR_MODE PreviousMode;
-   PEPROCESS Process, CurrentProcess;
+   KPROCESSOR_MODE PreviousMode = {0};
+   PEPROCESS Process, CurrentProcess = NULL;
    NTSTATUS Status = STATUS_SUCCESS;
 
    PAGED_CODE();
@@ -769,11 +769,11 @@
                      IN ULONG NumberOfBytesToWrite,
                      OUT PULONG NumberOfBytesWritten  OPTIONAL)
 {
-   PMDL Mdl;
-   PVOID SystemAddress;
+   PMDL Mdl = NULL;
+   PVOID SystemAddress = NULL;
    PEPROCESS Process;
-   KPROCESSOR_MODE PreviousMode;
-   NTSTATUS CopyStatus, Status = STATUS_SUCCESS;
+   KPROCESSOR_MODE PreviousMode = {0};
+   NTSTATUS CopyStatus = STATUS_SUCCESS, Status = STATUS_SUCCESS;
 
    DPRINT("NtWriteVirtualMemory(ProcessHandle %x, BaseAddress %x, "
           "Buffer %x, NumberOfBytesToWrite
%d)\n",ProcessHandle,BaseAddress,

Modified: trunk/reactos/ntoskrnl/ob/obdir.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obdir.c?rev=262
46&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ob/obdir.c (original)
+++ trunk/reactos/ntoskrnl/ob/obdir.c Mon Apr  2 13:48:51 2007
@@ -466,7 +466,7 @@
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     ULONG SkipEntries = 0;
     NTSTATUS Status = STATUS_SUCCESS;
-    PVOID LocalBuffer;
+    PVOID LocalBuffer = NULL;
     POBJECT_DIRECTORY_INFORMATION DirectoryInfo;
     ULONG Length, TotalLength;
     ULONG Count, CurrentEntry;

Modified: trunk/reactos/ntoskrnl/ob/obhandle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev=
26246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ob/obhandle.c (original)
+++ trunk/reactos/ntoskrnl/ob/obhandle.c Mon Apr  2 13:48:51 2007
@@ -3150,7 +3150,7 @@
                   IN ULONG HandleAttributes,
                   IN ULONG Options)
 {
-    PEPROCESS SourceProcess, TargetProcess, Target;
+    PEPROCESS SourceProcess, TargetProcess, Target = NULL;
     HANDLE hTarget;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     NTSTATUS Status = STATUS_SUCCESS;

Modified: trunk/reactos/ntoskrnl/ob/obwait.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obwait.c?rev=26
246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ob/obwait.c (original)
+++ trunk/reactos/ntoskrnl/ob/obwait.c Mon Apr  2 13:48:51 2007
@@ -56,7 +56,7 @@
     ULONG i = 0, ReferencedObjects = 0, j;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     LARGE_INTEGER SafeTimeOut;
-    BOOLEAN LockInUse;
+    BOOLEAN LockInUse = FALSE;
     PHANDLE_TABLE_ENTRY HandleEntry;
     POBJECT_HEADER ObjectHeader;
     PHANDLE_TABLE HandleTable;
@@ -457,7 +457,7 @@
 {
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     POBJECT_TYPE Type;
-    PVOID SignalObj, WaitObj, WaitableObject;
+    PVOID SignalObj, WaitObj, WaitableObject = NULL;
     LARGE_INTEGER SafeTimeOut;
     OBJECT_HANDLE_INFORMATION HandleInfo;
     NTSTATUS Status = STATUS_SUCCESS;

Modified: trunk/reactos/ntoskrnl/ps/job.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/job.c?rev=26246
&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ps/job.c (original)
+++ trunk/reactos/ntoskrnl/ps/job.c Mon Apr  2 13:48:51 2007
@@ -225,8 +225,8 @@
 {
     HANDLE hJob;
     PEJOB Job;
-    KPROCESSOR_MODE PreviousMode;
-    PEPROCESS CurrentProcess;
+    KPROCESSOR_MODE PreviousMode = {0};
+    PEPROCESS CurrentProcess = NULL;
     NTSTATUS Status = STATUS_SUCCESS;
 
     PAGED_CODE();
@@ -396,7 +396,7 @@
     ACCESS_MASK DesiredAccess,
     POBJECT_ATTRIBUTES ObjectAttributes)
 {
-    KPROCESSOR_MODE PreviousMode;
+    KPROCESSOR_MODE PreviousMode = {0};
     HANDLE hJob;
     NTSTATUS Status = STATUS_SUCCESS;
 

Modified: trunk/reactos/ntoskrnl/ps/query.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=262
46&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ps/query.c (original)
+++ trunk/reactos/ntoskrnl/ps/query.c Mon Apr  2 13:48:51 2007
@@ -484,7 +484,7 @@
     PEPROCESS Process;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     ACCESS_MASK Access;
-    NTSTATUS Status;
+    NTSTATUS Status = STATUS_NOT_IMPLEMENTED;
     HANDLE PortHandle = NULL;
     HANDLE TokenHandle = NULL;
     PROCESS_SESSION_INFORMATION SessionInfo = {0};
@@ -719,7 +719,7 @@
     PETHREAD Thread;
     ULONG Access;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
-    NTSTATUS Status;
+    NTSTATUS Status = STATUS_INVALID_PARAMETER;
     HANDLE TokenHandle = NULL;
     KPRIORITY Priority = 0;
     KAFFINITY Affinity = 0, CombinedAffinity;

Modified: trunk/reactos/ntoskrnl/ps/thread.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/thread.c?rev=26
246&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/ps/thread.c (original)
+++ trunk/reactos/ntoskrnl/ps/thread.c Mon Apr  2 13:48:51 2007
@@ -141,7 +141,7 @@
 PspSystemThreadStartup(IN PKSTART_ROUTINE StartRoutine,
                        IN PVOID StartContext)
 {
-    PETHREAD Thread;
+    PETHREAD Thread = NULL;
     PSTRACE(PS_THREAD_DEBUG,
             "StartRoutine: %p StartContext: %p\n", StartRoutine,
StartContext);
 

Modified: trunk/reactos/ntoskrnl/se/acl.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/acl.c?rev=26246
&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/se/acl.c (original)
+++ trunk/reactos/ntoskrnl/se/acl.c Mon Apr  2 13:48:51 2007
@@ -275,7 +275,7 @@
               IN BOOLEAN CaptureIfKernel,
               OUT PACL *CapturedAcl)
 {
-  PACL NewAcl;
+  PACL NewAcl = NULL;
   ULONG AclSize = 0;
   NTSTATUS Status = STATUS_SUCCESS;
 

Modified: trunk/reactos/ntoskrnl/se/priv.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/priv.c?rev=2624
6&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/se/priv.c (original)
+++ trunk/reactos/ntoskrnl/se/priv.c Mon Apr  2 13:48:51 2007
@@ -184,7 +184,7 @@
 				 PLUID_AND_ATTRIBUTES* Dest,
 				 PULONG Length)
 {
-    ULONG BufferSize;
+    ULONG BufferSize = 0;
     NTSTATUS Status = STATUS_SUCCESS;
 
     PAGED_CODE();
@@ -300,7 +300,7 @@
   ULONG PrivilegeControl = 0;
   ULONG Length;
   BOOLEAN CheckResult;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/se/sd.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sd.c?rev=26246…
r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/se/sd.c (original)
+++ trunk/reactos/ntoskrnl/se/sd.c Mon Apr  2 13:48:51 2007
@@ -394,7 +394,7 @@
 {
   PISECURITY_DESCRIPTOR OriginalSecurityDescriptor =
_OriginalSecurityDescriptor;
   SECURITY_DESCRIPTOR DescriptorCopy;
-  PISECURITY_DESCRIPTOR NewDescriptor;
+  PISECURITY_DESCRIPTOR NewDescriptor = NULL;
   ULONG OwnerSAC = 0, GroupSAC = 0;
   ULONG OwnerSize = 0, GroupSize = 0;
   ULONG SaclSize = 0, DaclSize = 0;

Modified: trunk/reactos/ntoskrnl/se/sid.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sid.c?rev=26246
&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/se/sid.c (original)
+++ trunk/reactos/ntoskrnl/se/sid.c Mon Apr  2 13:48:51 2007
@@ -236,7 +236,7 @@
               OUT PSID *CapturedSid)
 {
   ULONG SidSize = 0;
-  PISID NewSid, Sid = (PISID)InputSid;
+  PISID NewSid = NULL, Sid = (PISID)InputSid;
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();

Modified: trunk/reactos/ntoskrnl/se/token.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/token.c?rev=262
46&r1=26245&r2=26246&view=diff
============================================================================
==
--- trunk/reactos/ntoskrnl/se/token.c (original)
+++ trunk/reactos/ntoskrnl/se/token.c Mon Apr  2 13:48:51 2007
@@ -669,8 +669,8 @@
     ULONG Ulong;
   } Unused;
   PTOKEN Token;
-  ULONG RequiredLength;
-  KPROCESSOR_MODE PreviousMode;
+  ULONG RequiredLength = 0;
+  KPROCESSOR_MODE PreviousMode = {0};
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();
@@ -1253,7 +1253,7 @@
 		      IN ULONG TokenInformationLength)
 {
   PTOKEN Token;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   ULONG NeededAccess = TOKEN_ADJUST_DEFAULT;
   NTSTATUS Status = STATUS_SUCCESS;
 
@@ -1496,7 +1496,7 @@
                  IN TOKEN_TYPE TokenType,
                  OUT PHANDLE NewTokenHandle)
 {
-  KPROCESSOR_MODE PreviousMode;
+    KPROCESSOR_MODE PreviousMode = {0};
   HANDLE hToken;
   PTOKEN Token;
   PTOKEN NewToken;
@@ -2134,7 +2134,7 @@
   PVOID EndMem;
   ULONG uLength;
   ULONG i;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   ULONG nTokenPrivileges = 0;
   LARGE_INTEGER LocalExpirationTime = {{0}};
   NTSTATUS Status = STATUS_SUCCESS;
@@ -2464,7 +2464,7 @@
   OBJECT_ATTRIBUTES ObjectAttributes;
   SECURITY_DESCRIPTOR SecurityDescriptor;
   PACL Dacl = NULL;
-  KPROCESSOR_MODE PreviousMode;
+  KPROCESSOR_MODE PreviousMode = {0};
   NTSTATUS Status = STATUS_SUCCESS;
 
   PAGED_CODE();
@@ -2661,7 +2661,7 @@
                 IN HANDLE SecondTokenHandle,
                 OUT PBOOLEAN Equal)
 {
-    KPROCESSOR_MODE PreviousMode;
+    KPROCESSOR_MODE PreviousMode = {0};
     PTOKEN FirstToken, SecondToken;
     BOOLEAN IsEqual;
     NTSTATUS Status = STATUS_SUCCESS;




This message contains confidential information and is intended only for the individual
named. If you are not the named addressee you should not disseminate, distribute or copy
this e-mail. Please notify the sender immediately by e-mail if you have received this
e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be
guaranteed to be secure or error-free as information could be intercepted, corrupted,
lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does
not accept liability for any errors or omissions in the contents of this message, which
arise as a result of e-mail transmission. If verification is required please request a
hard-copy version. 

Amteus PLC
57 Cardigan Lane,
Leeds, 
LS4 2LE
t:[phone]
f: [phone]

Registered in England No 4760795

http://www.amteus.com