Re: [ros-dev] [ros-diffs] [tkreuzer] 26559: winetsts build fix - add needed #includes to test.h - add windef.h including psdk/windef.h

[Steven Edwards]

Why can't use change the include path to use the normal windef.h?

On 4/28/07, tkreuzer(a)svn.reactos.org <tkreuzer(a)svn.reactos.org> wrote:
>   Author: tkreuzer
>  Date: Sat Apr 28 12:58:18 2007
>  New Revision: 26559
>
>  URL: http://svn.reactos.org/svn/reactos?rev=26559&view=rev
>  Log:
>  winetsts build fix
>  - add needed #includes to test.h
>  - add windef.h including psdk/windef.h
>
>  Added:
>      trunk/reactos/include/reactos/wine/windef.h
>  Modified:
>      trunk/reactos/include/reactos/wine/test.h
>
>  Modified: trunk/reactos/include/reactos/wine/test.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/test.…
>  ==============================================================================
>  --- trunk/reactos/include/reactos/wine/test.h (original)
>  +++ trunk/reactos/include/reactos/wine/test.h Sat Apr 28 12:58:18 2007
>  @@ -25,6 +25,8 @@
>   #include <stdlib.h>
>   #include <windef.h>
>   #include <winbase.h>
>  +#include <wingdi.h>
>  +#include <winreg.h>
>
>   #ifdef __WINE_WINE_LIBRARY_H
>   #error wine/library.h should not be used in Wine tests
>
>  Added: trunk/reactos/include/reactos/wine/windef.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/winde…
>  ==============================================================================
>  --- trunk/reactos/include/reactos/wine/windef.h (added)
>  +++ trunk/reactos/include/reactos/wine/windef.h Sat Apr 28 12:58:18 2007
>  @@ -1,0 +1,3 @@
>  +#include "../../psdk/windef.h"
>  +
>  +
>
>
>  

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Timo Kreuzer]

Someone (I think it was hpoussin) said that changing winetests was not a 
good idea. So I added the needed header.
I don't know how much winetests are exact copies from their code, I just 
didn't want to change too much wine code.
"wine/..." may even be a ros hack, I don't know. If it is, feel free to 
revert and change the tests.
BTW: Usurp said that the new wine test for shell32 does not reinlcude 
the type definition, so updating would be nice.
BTW2: I'm on irc atm ;-)

Steven Edwards schrieb:
>   Why can't use change the include path to use the
> normal windef.h?
>
>  On 4/28/07, tkreuzer(a)svn.reactos.org <tkreuzer(a)svn.reactos.org> wrote:
>    
> >   Author: tkreuzer
> >  Date: Sat Apr 28 12:58:18 2007
> >  New Revision: 26559
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=26559&view=rev
> >  Log:
> >  winetsts build fix
> >  - add needed #includes to test.h
> >  - add windef.h including psdk/windef.h
> >
> >  Added:
> >      trunk/reactos/include/reactos/wine/windef.h
> >  Modified:
> >      trunk/reactos/include/reactos/wine/test.h
> >
> >  Modified: trunk/reactos/include/reactos/wine/test.h
> >  URL:
> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/test.…
> >  ==============================================================================
> >  --- trunk/reactos/include/reactos/wine/test.h (original)
> >  +++ trunk/reactos/include/reactos/wine/test.h Sat Apr 28 12:58:18 2007
> >  @@ -25,6 +25,8 @@
> >   #include <stdlib.h>
> >   #include <windef.h>
> >   #include <winbase.h>
> >  +#include <wingdi.h>
> >  +#include <winreg.h>
> >
> >   #ifdef __WINE_WINE_LIBRARY_H
> >   #error wine/library.h should not be used in Wine tests
> >
> >  Added: trunk/reactos/include/reactos/wine/windef.h
> >  URL:
> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/winde…
> >  ==============================================================================
> >  --- trunk/reactos/include/reactos/wine/windef.h (added)
> >  +++ trunk/reactos/include/reactos/wine/windef.h Sat Apr 28 12:58:18 2007
> >  @@ -1,0 +1,3 @@
> >  +#include "../../psdk/windef.h"
> >  +
> >  +
> >
> >
> >
> >       
>
>