Build Crash Revision 70918

[James Tabor]

Linux build this is haping on all my systems, Slackware, Fedora,,,,,

Building C object base/shell/progman/progman_pch.h.gch
FAILED: /usr/local/RosBE/i386/bin/i686-w64-mingw32-gcc  -DDBG=1 -DKDBG=1
-DUSE_COMPILER_EXCEPTIONS -DWINVER=0x502 -D_DLL -D_M_IX86
-D_SEH_ENABLE_TRACE -D_SETUPAPI_VER=0x502 -D_USE_32BIT_TIME_T
-D_USE_PSEH3=1 -D_WIN32_IE=0x600 -D_WIN32_WINDOWS=0x502
-D_WIN32_WINNT=0x502 -D_X86_ -D__REACTOS__ -D__USE_CRTIMP -D__i386__
-D_inline=__inline -Di386 -Wa,--compress-debug-sections -pipe
-fms-extensions -fno-strict-aliasing -nostdinc -mstackrealign
-Wold-style-declaration -Wdeclaration-after-statement
-fdebug-prefix-map="/home/ros/reactos"=ReactOS -gdwarf-2 -gstrict-dwarf
-femit-struct-debug-detailed=none -feliminate-unused-debug-symbols
-march=pentium -mtune=i686 -Werror -Wall -Wpointer-arith
-Wno-char-subscripts -Wno-multichar -Wno-unused-value
-Wno-maybe-uninitialized -O1 -fno-optimize-sibling-calls
-fno-omit-frame-pointer -mpreferred-stack-boundary=3
-fno-set-stack-executable -Winvalid-pch -Werror=invalid-pch
-Ibase/shell/progman -I../../base/shell/progman -I../../include
-I../../include/psdk -I../../include/dxsdk -Iinclude -Iinclude/psdk
-Iinclude/dxsdk -Iinclude/ddk -Iinclude/reactos -I../../include/crt
-I../../include/ddk -I../../include/ndk -I../../include/reactos
-I../../include/reactos/libs -MMD -MT base/shell/progman/progman_pch.h.gch
-MF base/shell/progman/progman_pch.h.gch.d -o
base/shell/progman/progman_pch.h.gch -c ../../base/shell/progman/progman.h
../../base/shell/progman/progman.h:25:9: error: #pragma once in main file
[-Werror]
cc1: all warnings being treated as errors

[Amine Khaldi]

Hi,

I fixed the module import. All is well, please svn up and try again.

Cheers,
Amine.

[Hermès BÉLUSCA - MAÏTO]

Hi Amine, why haven't the build bots complained about the #pragma once? (and
the more fundamental question: why does the #pragma once make compilation
fail for *some* people?)
Hermès.

-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Amine Khaldi
Envoyé : samedi 5 mars 2016 09:47
À : [e-mail]
Objet : Re: [ros-dev] Build Crash Revision 70918

Hi,

I fixed the module import. All is well, please svn up and try again.

Cheers,
Amine.

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Amine Khaldi]

> Hi Amine, why haven't the build bots complained about the #pragma once? (and
> the more fundamental question: why does the #pragma once make compilation
> fail for*some*  people?)

Hi,

The pragma issue makes compilation break for *all* people except those 
who have PCH set to 0. As to build bots, I assume they are using ccache 
builds with PCH turned off.

Cheers,
Amine.

[Hermès BÉLUSCA - MAÏTO]

If I remember correctly, in pure VS C/C++ projects using precompiled headers
(ie. with stdafx.h/stdafx.c (or cpp) ), when using #pragma once in stdafx.h,
the compiler doesn’t fail. That’s why I’m surprised of seeing that problem
with ROS.

Hermès

De : Ros-dev [mailto:[e-mail]] De la part de Amine Khaldi
Envoyé : samedi 5 mars 2016 16:10
À : [e-mail]
Objet : Re: [ros-dev] Build Crash Revision 70918

Hi Amine, why haven't the build bots complained about the #pragma once? (and
the more fundamental question: why does the #pragma once make compilation
fail for *some* people?)

Hi,

The pragma issue makes compilation break for *all* people except those who
have PCH set to 0. As to build bots, I assume they are using ccache builds
with PCH turned off.

Cheers,
Amine.

[James Tabor]

Thanks for fixing it!
James

On Sat, Mar 5, 2016 at 9:47 AM, Hermès BÉLUSCA - MAÏTO <
[e-mail]> wrote:
> If I remember correctly, in pure VS C/C++ projects using precompiled
> headers (ie. with stdafx.h/stdafx.c (or cpp) ), when using #pragma once in
> stdafx.h, the compiler doesn’t fail. That’s why I’m surprised of seeing
> that problem with ROS.
>
> Hermès
>
> *De :* Ros-dev [mailto:[e-mail]] *De la part de* Amine
> Khaldi
> *Envoyé :* samedi 5 mars 2016 16:10
> *À :* [e-mail]
> *Objet :* Re: [ros-dev] Build Crash Revision 70918
>
> Hi Amine, why haven't the build bots complained about the #pragma once? (and
>
> the more fundamental question: why does the #pragma once make compilation
>
> fail for ****some** people?)
>
> Hi,
>
> The pragma issue makes compilation break for *all* people except those who
> have PCH set to 0. As to build bots, I assume they are using ccache builds
> with PCH turned off.
>
> Cheers,
> Amine.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev