Re: [ros-dev] [ros-diffs] [tkreuzer] 30929: patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch

[Aleksey Bragin]

>    if(!dc) break;

This additional check is not needed, because dc is checked at the  
beginning of the function now.

WBR,
Aleksey Bragin.

On Dec 1, 2007, at 5:09 AM, [e-mail] wrote:
> Author: tkreuzer
> Date: Sat Dec  1 05:09:39 2007
> New Revision: 30929
>
> URL: http://svn.reactos.org/svn/reactos?rev=30929&view=rev
> Log:
> patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch
>
> Modified:
>     trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c
>
> Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ 
> win32/win32k/objects/gdibatch.c?rev=30929&r1=30928&r2=30929&view=diff
> ====================================================================== 
> ========
> --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c  
> (original)
> +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c Sat  
> Dec  1 05:09:39 2007
> @@ -49,7 +49,13 @@
>       case GdiBCExtSelClipRgn:
>          break;
>       case GdiBCSelObj:
>    break;
> {
>    PGDIBSOBJECT pgO;
>    if(!dc) break;
>    pgO = (PGDIBSOBJECT) pHdr;
>    if(NT_SUCCESS(TextIntRealizeFont((HFONT) pgO->hgdiobj)))
>                  Dc_Attr->hlfntNew = (HFONT) pgO->hgdiobj;
> }
> case GdiBCDelObj:
> case GdiBCDelRgn:
> {
>
> @@ -115,3 +121,4 @@
>    return STATUS_SUCCESS;
>  }

[James Tabor]

Hi,
That is not correct. I fixed it in 30931. Most batch operations do not use
dc.
Thanks,
James

On Dec 1, 2007 2:57 AM, Aleksey Bragin [e-mail] wrote:
> >    if(!dc) break;
>
> This additional check is not needed, because dc is checked at the
> beginning of the function now.
>
> WBR,
> Aleksey Bragin.
>
> On Dec 1, 2007, at 5:09 AM, [e-mail] wrote:
> > Author: tkreuzer
> > Date: Sat Dec  1 05:09:39 2007
> > New Revision: 30929
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=30929&view=rev
> > Log:
> > patch by jimtabor: add GdiBCSelObj to GdiFlushUserBatch
> >
> > Modified:
> >     trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c
> >
> > Modified: trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c
> > URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/
> > win32/win32k/objects/gdibatch.c?rev=30929&r1=30928&r2=30929&view=diff
> > ======================================================================
> > ========
> > --- trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c
> > (original)
> > +++ trunk/reactos/subsystems/win32/win32k/objects/gdibatch.c Sat
> > Dec  1 05:09:39 2007
> > @@ -49,7 +49,13 @@
> >       case GdiBCExtSelClipRgn:
> >          break;
> >       case GdiBCSelObj:
> >    break;
> > {
> >    PGDIBSOBJECT pgO;
> >    if(!dc) break;
> >    pgO = (PGDIBSOBJECT) pHdr;
> >    if(NT_SUCCESS(TextIntRealizeFont((HFONT) pgO->hgdiobj)))
> >                  Dc_Attr->hlfntNew = (HFONT) pgO->hgdiobj;
> > }
> > case GdiBCDelObj:
> > case GdiBCDelRgn:
> > {
> >
> > @@ -115,3 +121,4 @@
> >    return STATUS_SUCCESS;
> >  }
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev