weiden@cvs.reactos.com wrote:
CVSROOT: /CVS/ReactOS Module name: reactos Repository: reactos/lib/kernel32/misc/ Changes by: weiden@mok.osexperts.com 04/12/09 09:28:11
Modified files: reactos/lib/kernel32/file/: dir.c reactos/lib/kernel32/include/: kernel32.h reactos/lib/kernel32/misc/: stubs.c
Log message: implemented SetDllDirectory() and GetDllDirectory(). LoadLibrary(Ex)() should be extended to use the dll directory when present!
Ros-cvs mailing list Ros-cvs@reactos.com http://reactos.com/mailman/listinfo/ros-cvs
Hi,
Shouldn't kernel not use unicode_strings + rtl, and just stay within the domain of normal string functions and kernel32 stuff?
Also, shouldn't the DllDirectory be in the registry, and not some local var that gets erased every time you reboot?
Best regards, Alex Ionescu
Alex Ionescu wrote:
Shouldn't kernel not use unicode_strings + rtl, and just stay within the domain of normal string functions and kernel32 stuff?
Also, shouldn't the DllDirectory be in the registry, and not some local var that gets erased every time you reboot?
I believe Thomas' implementation is correct based on MSDN documentation.
Alex Ionescu wrote:
Shouldn't kernel not use unicode_strings + rtl, and just stay within the domain of normal string functions and kernel32 stuff?
there's nothing wrong with using UNICODE_STRINGs and RTl in kernel32, it's used in many places for system calls
Also, shouldn't the DllDirectory be in the registry, and not some local var that gets erased every time you reboot?
No. It is a global variable that stores a path (not even verifies it) that is used with priority in LoadLibrary(Ex)(). It doesn't query/store anything. The implementation works fine, I wrote a small test application before I committed it.
Best Regards Thomas
A little FYI: The windows NT kernel is apparently 100% unicode. This means that ALL strings within the kernel are unicode. His changes are correct.
Alex Ionescu wrote:
weiden@cvs.reactos.com wrote:
CVSROOT: /CVS/ReactOS Module name: reactos Repository: reactos/lib/kernel32/misc/ Changes by: weiden@mok.osexperts.com 04/12/09 09:28:11
Modified files: reactos/lib/kernel32/file/: dir.c reactos/lib/kernel32/include/: kernel32.h reactos/lib/kernel32/misc/: stubs.c Log message: implemented SetDllDirectory() and GetDllDirectory(). LoadLibrary(Ex)() should be extended to use the dll directory when present!
Ros-cvs mailing list Ros-cvs@reactos.com http://reactos.com/mailman/listinfo/ros-cvs
Hi,
Shouldn't kernel not use unicode_strings + rtl, and just stay within the domain of normal string functions and kernel32 stuff?
Also, shouldn't the DllDirectory be in the registry, and not some local var that gets erased every time you reboot?
Best regards, Alex Ionescu _______________________________________________ Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
Richard Campbell wrote:
A little FYI: The windows NT kernel is apparently 100% unicode. This means that ALL strings within the kernel are unicode. His changes are correct.
this is not entirely correct. Unfortunately there are a few strings that are not unicode, e.g. the ImageFileName field in the EPROCESS structure....But most parts are ;) i guess with kernel he meant the kernel32 library.
Thomas
Okay, let me rephrase that, ntoskrnl, win32k, etc. are SUPPOSED to be 100% unicode according to microsoft.
Thomas Weidenmueller wrote:
Richard Campbell wrote:
A little FYI: The windows NT kernel is apparently 100% unicode. This means that ALL strings within the kernel are unicode. His changes are correct.
this is not entirely correct. Unfortunately there are a few strings that are not unicode, e.g. the ImageFileName field in the EPROCESS structure....But most parts are ;) i guess with kernel he meant the kernel32 library.
Thomas _______________________________________________ Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
-----Original Message----- From: ros-dev-bounces@reactos.com [mailto:ros-dev-bounces@reactos.com] On Behalf Of Richard Campbell Sent: 10. december 2004 00:35 To: ReactOS Development List Subject: Re: [ros-dev] Re: [ros-cvs] CVS Update: reactos
Okay, let me rephrase that, ntoskrnl, win32k, etc. are SUPPOSED to be 100% unicode according to microsoft.
Win32k need to support ANSI windows. Everywhere else it is unicode.
Casper
Richard Campbell wrote:
A little FYI: The windows NT kernel is apparently 100% unicode. This means that ALL strings within the kernel are unicode. His changes are correct.
I know that. But UNICODE_STRINGS are not usually used in Win32, except as LSA_UNICODE_STRING. But then again, this is ReactOS do we can do what we want. It's just not arthicteturally correct, imo.
Best regards, Alex Ionescu
Alex Ionescu wrote:
I know that. But UNICODE_STRINGS are not usually used in Win32, except as LSA_UNICODE_STRING. But then again, this is ReactOS do we can do what we want. It's just not arthicteturally correct, imo.
Well, this is kernel32 which also does lot's of system calls which require UNICODE_STRING parameters sometimes, so we're forced to use them in there in any case ;)
Thomas