Re: [ros-dev] [ros-diffs] [hpoussin] 24379: Copy i8042prt driver from 0.3.1 branch to trunk. Try #2

[Alex Ionescu]

[e-mail] wrote:
> Author: hpoussin
> Date: Tue Oct  3 22:04:03 2006
> New Revision: 24379
>
> URL: http://svn.reactos.org/svn/reactos?rev=24379&view=rev
> Log:
> Copy i8042prt driver from 0.3.1 branch to trunk. Try #2
>
> Added:
>     trunk/reactos/drivers/input/i8042prt/
>       - copied from r24378, branches/ros-branch-0_3_1/reactos/drivers/input/i8042prt/

Why are we copying it from branch to trunk? Shouldn't it be copied from
trunk to the branch?
-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS

[David Hinz]

Herve reverted his new i8042prt driver.
But this still leaves the question, why he copied the old one from the 
branch...

Alex Ionescu schrieb:
> [e-mail] wrote:
> > Author: hpoussin
> > Date: Tue Oct  3 22:04:03 2006
> > New Revision: 24379
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=24379&view=rev
> > Log:
> > Copy i8042prt driver from 0.3.1 branch to trunk. Try #2
> >
> > Added:
> >     trunk/reactos/drivers/input/i8042prt/
> >       - copied from r24378, branches/ros-branch-0_3_1/reactos/drivers/input/i8042prt/
>
> Why are we copying it from branch to trunk? Shouldn't it be copied from
> trunk to the branch?

[Alex Ionescu]

David Hinz wrote:
> Herve reverted his new i8042prt driver.
> But this still leaves the question, why he copied the old one from the 
> branch...
>
> Alex Ionescu schrieb:

On whose authority did he revert his driver? Just kidding ;-)

But seriously, it's ok if he wants to stop maintaing it (i8042prt is
something of a bad omen, 2 devs already went crazy, I hope not a
third...), but I'd still like it to be in trunk.

Maybe someone will finally listen to me (for the 3rd time...) and use
the damn DDK driver as a sample (like the license allows you) and
document it extensively and/or even directly try to identify
bugs/missing features by looking at the code. There is NO LAW AGAINST THIS.
-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS

[WaxDragon]

> On whose authority did he revert his driver? Just kidding ;-)
>
> But seriously, it's ok if he wants to stop maintaing it (i8042prt is
> something of a bad omen, 2 devs already went crazy, I hope not a
> third...), but I'd still like it to be in trunk.
>
> Maybe someone will finally listen to me (for the 3rd time...) and use
> the damn DDK driver as a sample (like the license allows you) and
> document it extensively and/or even directly try to identify
> bugs/missing features by looking at the code. There is NO LAW AGAINST THIS.

I would be more than happy to help with this effort, as I have stated
before.  I wanted Hervé's work to stay in also..

I imagine he copied it from branch to trunk since 0.3.1 was branched
before he committed the new i8042prt code, so it was a known good
copy.

WD
-- 
22:38 <@WaxDragon> false ^ true
22:39 < false> :(
22:39 < false> dont you think you can XOR me and get away with it! I
always return!