Re: [ros-dev] [ros-diffs] [rmessiant] 53729: [NTOSKRNL] Disable normal APC delivery while acquiring/releasing a heap lock. Also, BOOLEAN != NTSTATUS.

[Timo Kreuzer]

Am 17.09.2011 22:26, schrieb [e-mail]:
> Author: rmessiant
> Date: Sat Sep 17 20:26:31 2011
> New Revision: 53729
>
> URL: http://svn.reactos.org/svn/reactos?rev=53729&view=rev
> Log:
> [NTOSKRNL]
> Disable normal APC delivery while acquiring/releasing a heap lock. Also, BOOLEAN != NTSTATUS.
>
> Modified:
>      trunk/reactos/ntoskrnl/rtl/libsupp.c
>
> Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/rtl/libsupp.c?rev=...
> ==============================================================================
> --- trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] Sat Sep 17 20:26:31 2011
> @@ -168,7 +168,10 @@
>   RtlEnterHeapLock(
>       PHEAP_LOCK Lock)
>   {
> return ExAcquireResourceExclusive(&Lock->Resource, TRUE);
>
> KeEnterCriticalRegion();
>
> ExAcquireResourceExclusive(&Lock->Resource, TRUE);
>
> KeLeaveCriticalRegion();
>
> return STATUS_SUCCESS;
> }
>
> NTSTATUS
>
> @@ -185,7 +188,9 @@
>   RtlLeaveHeapLock(
>       PHEAP_LOCK Lock)
>   {
> KeEnterCriticalRegion();
>  ExReleaseResource(&Lock->Resource);
> KeLeaveCriticalRegion();
>  return STATUS_SUCCESS;
> }

Why enable APC delivery after the resource is acquired?
It should stay disabled to prevent deadlocks.

[Roel Messiant]

2011/9/18 Timo Kreuzer [e-mail]:
> Am 17.09.2011 22:26, schrieb [e-mail]:
>
> Why enable APC delivery after the resource is acquired?
> It should stay disabled to prevent deadlocks.

You're right, and it was corrected in my working copy soon after the commit.
It'll be fixed soon, along with other changes.

WBR,
Roel

[Ged Murphy]

I realise your patch doesn't fix nor worsen the original problem, but why
not just fix it now?
It only requires deleting 2 lines and It's been 2 days now.

-----Original Message-----
From: [e-mail] [mailto:[e-mail]] On
Behalf Of Roel Messiant
Sent: 18 September 2011 12:54
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [rmessiant] 53729: [NTOSKRNL] Disable
normal APC delivery while acquiring/releasing a heap lock. Also, BOOLEAN !=
NTSTATUS.

2011/9/18 Timo Kreuzer [e-mail]:
> Am 17.09.2011 22:26, schrieb [e-mail]:
>
> Why enable APC delivery after the resource is acquired?
> It should stay disabled to prevent deadlocks.

You're right, and it was corrected in my working copy soon after the commit.
It'll be fixed soon, along with other changes.

WBR,
Roel

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev