??: Re: suggestion: moving wine dlls

[Aleksey Bragin]

I dislike the idea, I'll tell reasons when I'm back.

-----???????? ?????????-----
??: "James Tabor" <jimtabor(a)adsl-64-217-116-74.dsl.hstntx.swbell.net>
????: "ReactOS Development List" <ros-dev(a)reactos.org>
??????????: 30.07.07 08:58
????: Re: [ros-dev] suggestion: moving wine dlls

Timo Kreuzer wrote:
>   I have a suggestion:
>  Move all wine shared dlls to dll/wine or dll/3rdparty/wine, only kepping
>  our own dlls (gdi32, user32, kernel32, syssetup, newdev, console, hid,
>  mmdrv, ...) in dll/win32.
>  Reason is, we just lost a few earlier commited translation of wine dlls
>  with the latest winesyncs.
>  With this we would make sure everone would directly see that the
>  component is synched with wine and should not be touched. Another point
>  is that it's quite annoying to have >100 folders under the win32 folder
>  that expand in the file browser, when you browse to one of our dlls.
>  
>  Greetings,
>  Timo
>

[Daniel Reimer]

Hi,

I dont talk very often here, but this is, in my eyes, quite urgent. Some 
days ago Magnus said he was able to fix some bugs thanks to the old 
winetests we have in SVN. When I looked at the tests I saw that some had 
their last update in r16000, TWO Years ago. I know its some work to port 
the tests, but dont you agree that newer tests could help to find even 
more bugs in ROS and that a update should be performed? If I could, I 
would do so, but I'm not skilled enough yet...

Daniel "EmuandCo" Reimer

[Magnus Olsen]

The problem we fail around 50%-70% of all winetest toghter. a update to
winetest at moment are not imported
and we are also plan write test kit for win32k with real syscall test in
windows and reactos. it mean we will found
the real bugs in our win32k, so it can behoir more like windows nt win32k,
next step is todo a over view
of gdi32, user32 and few part of kernel32,  also we need  writing big test
for thuse part,

We need the automatic testing farm for each build,  it is testing system
that are ready but missing test kit.
 we got janderwald to thanks for the new automatic testing kit  and we need
testing it now and write testkit
 for each api in reactos, it mean we will getting a real large testing farm
for reactos.


----- Original Message ----- 
From: "Daniel Reimer" <reimer.daniel(a)freenet.de>
To: "ReactOS Development List" <ros-dev(a)reactos.org>
Sent: Monday, July 30, 2007 10:14 PM
Subject: [ros-dev] Winetests


>   Hi,
>
>  I dont talk very often here, but this is, in my eyes, quite urgent. Some
>  days ago Magnus said he was able to fix some bugs thanks to the old
>  winetests we have in SVN. When I looked at the tests I saw that some had
>  their last update in r16000, TWO Years ago. I know its some work to port
>  the tests, but dont you agree that newer tests could help to find even
>  more bugs in ROS and that a update should be performed? If I could, I
>  would do so, but I'm not skilled enough yet...
>
>  Daniel "EmuandCo" Reimer
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Timo Kreuzer]

I am currently working on an api testing framework. Mostly working on 
win32k native api test atm, but it shall also include api testing for 
gdi32, user32, etc.
win32k test will work with syscall tables to decide on runtime how to 
perform a syscall by comparing OS version and build number. On ros 
syscalls will be done by linking to w32kdll wich is compiled from 
autogenerated win32k.S, so there is no need to update the syscall list 
for ros all the time.
The testing framework will include tests, regression tests, and an api 
status output is planned.


BTW: I have a suggestion:
1. move w32ksvc.db from nci folder to win32k folder, where it belongs imo
2. autogenerate win32k.S in lib\win32k and compile a static lib there 
(no need to compile it more than once)
same for sysfuncs.lst

Magnus Olsen schrieb:
>   The problem we fail around 50%-70% of all winetest
> toghter. a update to
>  winetest at moment are not imported
>  and we are also plan write test kit for win32k with real syscall test in
>  windows and reactos. it mean we will found
>  the real bugs in our win32k, so it can behoir more like windows nt win32k,
>  next step is todo a over view
>  of gdi32, user32 and few part of kernel32,  also we need  writing big test
>  for thuse part,
>
>  We need the automatic testing farm for each build,  it is testing system
>  that are ready but missing test kit.
>   we got janderwald to thanks for the new automatic testing kit  and we need
>  testing it now and write testkit
>   for each api in reactos, it mean we will getting a real large testing farm
>  for reactos.
>

[Magnus Olsen]

Hi
I dislike moving thuse files.
the win32k.S are genreate in gdi32 folder and user32 folder
maybe we should move it to own lib instead ?
call it win32ksyscall.a ? and only have one autogenreated win32k.S
I think that is better solvtions.


----- Original Message ----- 
From: "Timo Kreuzer" <timo.kreuzer(a)web.de>
To: "ReactOS Development List" <ros-dev(a)reactos.org>
Sent: Tuesday, July 31, 2007 10:29 AM
Subject: Re: [ros-dev] Winetests


>   I am currently working on an api testing framework.
> Mostly working on
>  win32k native api test atm, but it shall also include api testing for
>  gdi32, user32, etc.
>  win32k test will work with syscall tables to decide on runtime how to
>  perform a syscall by comparing OS version and build number. On ros
>  syscalls will be done by linking to w32kdll wich is compiled from
>  autogenerated win32k.S, so there is no need to update the syscall list
>  for ros all the time.
>  The testing framework will include tests, regression tests, and an api
>  status output is planned.
>
>
>  BTW: I have a suggestion:
>  1. move w32ksvc.db from nci folder to win32k folder, where it belongs imo
>  2. autogenerate win32k.S in lib\win32k and compile a static lib there
>  (no need to compile it more than once)
>  same for sysfuncs.lst
>
>  Magnus Olsen schrieb:
>  > The problem we fail around 50%-70% of all winetest toghter. a update to
>  > winetest at moment are not imported
>  > and we are also plan write test kit for win32k with real syscall test in
>  > windows and reactos. it mean we will found
>  > the real bugs in our win32k, so it can behoir more like windows nt 
win32k,
>   > next step is todo a over view
>  > of gdi32, user32 and few part of kernel32,  also we need  writing big 
test
>   > for thuse part,
>  >
>  > We need the automatic testing farm for each build,  it is testing system
>  > that are ready but missing test kit.
>  >  we got janderwald to thanks for the new automatic testing kit  and we 
need
>   > testing it now and write testkit
>  >  for each api in reactos, it mean we will getting a real large testing 
farm
> >   for reactos.
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Timo Kreuzer]

The lib thing is exactly what I had in mind.
I just also suggest moving the lists (win32ksvc.db and sysfuncs.lst) 
from the folder where the nci tool is to the folder where the function 
implementations are (win32k and ntoskrnl)

Magnus Olsen schrieb:
>   Hi
>  I dislike moving thuse files.
>  the win32k.S are genreate in gdi32 folder and user32 folder
>  maybe we should move it to own lib instead ?
>  call it win32ksyscall.a ? and only have one autogenreated win32k.S
>  I think that is better solvtions.
>
>

[Ged]

Timo Kreuzer wrote:

>   I just also suggest moving the lists (win32ksvc.db and
> sysfuncs.lst) 
>  from the folder where the nci tool is to the folder where the 
>  function implementations are (win32k and ntoskrnl) 
+1

Ged.



























This message contains confidential information and is intended only for the individual
named. If you are not the named addressee you should not disseminate, distribute or copy
this e-mail. Please notify the sender immediately by e-mail if you have received this
e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be
guaranteed to be secure or error-free as information could be intercepted, corrupted,
lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does
not accept liability for any errors or omissions in the contents of this message, which
arise as a result of e-mail transmission. If verification is required please request a
hard-copy version. 

Amteus Secure Communications Ltd
57 Cardigan Lane,
Leeds, 
LS4 2LE
t: [phone]
f: [phone]

Registered in England No 4760795

http://www.amteus.com