Re: [ros-dev] [ros-diffs] [dreimer] 68672: [BROWSEUI] Address is untranslatable by Adam Stachowicz CORE-9977 #resolve #comment Committed (with a Unicode fix), thx ^^

[Thomas Faber]

On 2015-08-10 18:52, [e-mail] wrote:
> --- trunk/reactos/dll/win32/browseui/addressband.cpp	[iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/browseui/addressband.cpp	[iso-8859-1] Mon Aug 10 16:52:40 2015
> @@ -93,7 +93,11 @@
>          pdbi->ptActual.y = 22;
>      }
>      if (pdbi->dwMask & DBIM_TITLE)
>    wcscpy(pdbi->wszTitle, L"Address");
> {
>    if (!LoadStringW(_AtlBaseModule.GetResourceInstance(), IDS_ADDRESSBANDLABEL, pdbi->wszTitle, _countof(pdbi->wszTitle)))
>        return E_FAIL;
> }

As a general rule, try not to use E_FAIL.
HRESULT_FROM_WIN32(GetLastError()) would probably be correct here.