Re: [ros-dev] [ros-diffs] [sginsberg] 38922: - Fix more InterlockedCompareExchangePointer warnings in crypt32 -- this to Wine, too - Hack-0-initialize a variable in cryptui to satisfy gcc -- this needed as Wine use a less retarded gcc than we do - Warning fix old a

[Ged]

sginsberg(a)svn.reactos.org wrote:
>   Author: sginsberg
>  Date: Sun Jan 18 17:31:26 2009
>  New Revision: 38922
>  URL: http://svn.reactos.org/svn/reactos?rev=38922&view=rev
>  Log:
>  - Fix more InterlockedCompareExchangePointer warnings in crypt32 -- this to Wine, too
>  Added:
>      trunk/reactos/dll/win32/crypt32/warningfixes.diff 
This is a bad idea.
It's painful enough keeping wine libs in sync without adding to the complexity with
non-needed warning fixes.
Ged.

[Aleksey Bragin]

And even more to that topic, warningfixes.diff is not processed by
any winesync script I know, so it's doubling information we have in
svn history anyway, without any real use.
Fix warnings upstream.
WBR,
Aleksey.
On Jan 19, 2009, at 11:07 AM, Ged wrote:
>   sginsberg(a)svn.reactos.org wrote:
> >   Author: sginsberg
> >  Date: Sun Jan 18 17:31:26 2009
> >  New Revision: 38922
> >  URL: http://svn.reactos.org/svn/reactos?rev=38922&view=rev
> >  Log:
> >  - Fix more InterlockedCompareExchangePointer warnings in crypt32
> >  -- this to Wine, too
> >  Added:
> >      trunk/reactos/dll/win32/crypt32/warningfixes.diff 
>  This is a bad idea.
>  It's painful enough keeping wine libs in sync without adding to the
>  complexity with non-needed warning fixes.
>  Ged.