Re: [ros-dev] [ros-diffs] [greatlrd] 32652: part 2/2 for implement GetAppCompatFlags left todo implemented set AppCompatFlags

[Aleksey Bragin]

Why did that big chunk of MS's support database text got into our  
codebase? Even not edited, so that I can read up about "tax form 1040  
would not print correctly" in ReactOS Source code? What is the use  
from it?

If you wanted SO MUCH, you could at least edit it, or ask someone to  
edit it for you (we have quite a few people in our team). But then, I  
could insert half of WDK docs into the kernel source code and drivers  
source code (which in fact would violate copyrights, since it would  
not even be fair use).

Providing URL is quite enough, though, if I don't mistake (I'm not up  
to date with their position), Wine is already removing URLs from  
source code because they should be kept somewhere else. Source code  
is source code, not a collector to store everything. There is no  
point in sticking various garbage into reactos source code with a  
note "so it doesn't get lost", we've come over that point quite a few  
years ago.



With the best regards,
Aleksey Bragin.

On Mar 11, 2008, at 3:09 AM, greatlrd(a)svn.reactos.org wrote:

>   Author: greatlrd
>  Date: Mon Mar 10 19:09:23 2008
>  New Revision: 32652
>
>  URL: http://svn.reactos.org/svn/reactos?rev=3D32652&view=3Drev
>  Log:
>  part 2/2 for implement GetAppCompatFlags
>  left todo implemented set AppCompatFlags =
>
>
>  Modified:
>      trunk/reactos/dll/win32/user32/misc/stubs.c
>
>  +  /* NOTE : GetAppCompatFlags retuns which compatible flags should  
>  be send=
>   back =
>
>  +   * the return value is any of http://support.microsoft.com/kb/82860
>  +   * This text are direcly copy from the  MSDN URL, so it does not  
>  get lost
>  +    
>  *--------------------------------------------------------------------- 
>  -=
>  --------
>  +   * Bit: 1 
Lots of text here

>   +  =
>
>  +  return ti->dwAppsCompatibleFlags;
>   }
>   =
>
>   /*

[James Tabor]

On Tue, Mar 11, 2008 at 10:41 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
>   Why did that big chunk of MS's support database
> text got into our
>   codebase? Even not edited, so that I can read up about "tax form 1040
>   would not print correctly" in ReactOS Source code? What is the use
>   from it?
>  
What would anyone outside of the US need to know about the 1040?
LOL!

>    Providing URL is quite enough, though, if I don't
> mistake (I'm not up
>   to date with their position), Wine is already removing URLs from
>   source code because they should be kept somewhere else. Source code
>   is source code, not a collector to store everything. There is no
>   point in sticking various garbage into reactos source code with a
>   note "so it doesn't get lost", we've come over that point quite a few
>   years ago.
>
>  
Wine? Must I?

I guess we can rewrite the data and post it in a blog. Include the
pointer to the url and include a copy of the page just for safe
keeping. I noticed many changes on the web that had hard to come by
data is going away. Having archives to prove our changes are
legitimate is a wise choice. Soon everyone from M$ will start posting
that we are coping from the leaked source,,,, oh that has already
happened!

Thanks,
James