Re: [ros-dev] [ros-diffs] [akhaldi] 50854: [RTL] - Silence this dprint. It's flooding the

[Pierre Schweitzer]

Hi,

this debug wasn't supposed to be silent as it highlights a quite crappy situation in
ReactOS. And that's even what one would call: "a hack".
That way, you could also silence IopParseDevice hack debug...
At least, you could have asked the author, I'm not that unreachable ;-).

Regards,
P. Schweitzer

[Amine Khaldi]

Hi,

Please check 
http://build.reactos.org/builders/Linux_AMD64_1%20KVM-Test/builds/4331/step…

IMHO it's not reasonable to keep such flood for an undetermined time (we 
don't know whether this bug will be fixed soon, or stay like the r1xxx 
style fixes we had lately).

A proper solution would be filing a bug report about this hack, and 
CCing the potentially interested devs.

Regards,
Amine.

[Timo Kreuzer]

I agree with Amine. The current debug log situation is not optimal. 
Important messages can get missed and even finding your own additional 
DPRINTs can be hard sometimes. I already use DPRINT1("############# 
!!!!!!!! Message bla bla !!! #######\n") to be able to find my debug 
prints ;-)
We have tons of hacks in our code, if each of them would do a dprint, ...
We should rather try to cleanup useless debug messages.

Timo

[Ged Murphy]

The correct way is to raise a bug and put a comment in the code with the
corresponding bug number.
This way it's always tracked and anyone who stumbles upon it when reading
the code can get information easily.

It doesn't seem to be a very popular way of doing things in reactos, I'm not
sure why though.

Ged.



-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Timo Kreuzer
Sent: 21 February 2011 14:58
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 50854: [RTL] - Silence this
dprint. It's flooding the


I agree with Amine. The current debug log situation is not optimal. 
Important messages can get missed and even finding your own additional 
DPRINTs can be hard sometimes. I already use DPRINT1("############# 
!!!!!!!! Message bla bla !!! #######\n") to be able to find my debug 
prints ;-)
We have tons of hacks in our code, if each of them would do a dprint, ...
We should rather try to cleanup useless debug messages.

Timo


_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Pierre Schweitzer]

Then, just remove the DPRINT.
Still, you could ask me ;-).

>   The correct way is to raise a bug and put a comment in
> the code with the
>  corresponding bug number.
>  This way it's always tracked and anyone who stumbles upon it when reading
>  the code can get information easily.
>  
>  It doesn't seem to be a very popular way of doing things in reactos, I'm not
>  sure why though.
>  
>  Ged.
>  
>  
>  
>  -----Original Message-----
>  From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
>  Behalf Of Timo Kreuzer
>  Sent: 21 February 2011 14:58
>  To: ReactOS Development List
>  Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 50854: [RTL] - Silence this
>  dprint. It's flooding the
>  
>  
>  I agree with Amine. The current debug log situation is not optimal. 
>  Important messages can get missed and even finding your own additional 
>  DPRINTs can be hard sometimes. I already use DPRINT1("############# 
>  !!!!!!!! Message bla bla !!! #######\n") to be able to find my debug 
>  prints ;-)
>  We have tons of hacks in our code, if each of them would do a dprint, ...
>  We should rather try to cleanup useless debug messages.
>  
>  Timo
>  
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev