Re: [ros-cvs] CVS Update: reactos

"Richard Campbell" [e-mail] wrote:
> CVSROOT: /CVS/ReactOS
> Module name: reactos
> Repository: reactos/bootdata/
> Changes by: [e-mail] 04/09/28 18:26:36
>
> Modified files:
> reactos/bootdata/: hivedef.inf hivesft.inf
>
> Log message:
> Changed a few REG_EXPAND_SZ to REG_SZs as per Windows

Please revert that change! These values _must_ be expandable in ReactOS to
work properly, no matter which type is used by Windows.

Regards,
Eric

[Richard Campbell]

Without this change an installer i'm working on getting to doesn't seem 
to properly read these values.  (Thanks to this bug and another related 
to %USERPROFILE% and %ALLUSERPROFILE% not properly getting replaced  
when the profile is created).  After this fix and a fix for the other 
bug, the installer now loads.

Eric Kohl wrote:
> "Richard Campbell" [e-mail] wrote:
> > CVSROOT: /CVS/ReactOS
> > Module name: reactos
> > Repository: reactos/bootdata/
> > Changes by: [e-mail] 04/09/28 18:26:36
> >
> > Modified files:
> > reactos/bootdata/: hivedef.inf hivesft.inf
> >
> > Log message:
> > Changed a few REG_EXPAND_SZ to REG_SZs as per Windows
>
> Please revert that change! These values _must_ be expandable in ReactOS to
> work properly, no matter which type is used by Windows.
>
> Regards,
> Eric
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

"Richard Campbell" [e-mail] wrote:
> Without this change an installer i'm working on getting to doesn't seem
> to properly read these values.  (Thanks to this bug and another related
> to %USERPROFILE% and %ALLUSERPROFILE% not properly getting replaced
> when the profile is created).  After this fix and a fix for the other
> bug, the installer now loads.

These values _must_ be of the REG_EXPAND_SZ type because they contain
environment variables (%USERPROFILE% and %ALLUSERPROFILE%).

Regards,
Eric

[Thomas Weidenmueller]

Eric Kohl wrote:
> These values _must_ be of the REG_EXPAND_SZ type because they contain
> environment variables (%USERPROFILE% and %ALLUSERPROFILE%).

I haven't checked myself but if they don't contain environment variables 
on windows machines we should do the same - even if it's not a good 
solution. there's always the risk that applications depend on little 
details like this. But again, I don't know about this specific case.

Regards
Thomas

[Royce Mitchell III]

Eric Kohl wrote:
> These values _must_ be of the REG_EXPAND_SZ type because they contain
> environment variables (%USERPROFILE% and %ALLUSERPROFILE%).

These values in XP do *not* contain environment variables, and they are 
REG_SZ... the problem is that we need an alternate place to store the 
strings until we create these entries whenever we are initializing a 
user profile. I think if the paths don't exist in the reg... we can 
create them with the hard-coded defaults, but we should always defer to 
the value if it exists ( in case the user changes it ), which is how 
shell32 is apparently handling it...
-- 
------------------------
http://wecanstopspam.org

[Richard Campbell]

Eric, this is incorrect.  They should not contain environment variables, 
Royce and i have investigated this on IRC.  And regardless, this doesn't 
work as intended anyways, write a test app for yourself and see.  This 
is confirmed to break compatibility with the 2 apps i tested it with 
(blizzard's installers.)

Eric Kohl wrote:
> "Richard Campbell" [e-mail] wrote:
> > Without this change an installer i'm working on getting to doesn't seem
> > to properly read these values.  (Thanks to this bug and another related
> > to %USERPROFILE% and %ALLUSERPROFILE% not properly getting replaced
> > when the profile is created).  After this fix and a fix for the other
> > bug, the installer now loads.
>
> These values _must_ be of the REG_EXPAND_SZ type because they contain
> environment variables (%USERPROFILE% and %ALLUSERPROFILE%).
>
> Regards,
> Eric
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev