Re: [ros-dev] [ros-diffs] [hbelusca] 66240: [WINLOGON] - Implement KillComProcesses that just kills with force and without any notification back to winlogon, any remaining app that is still alive even if we asked before to ...

[Thomas Faber]

On 2015-02-13 00:35, hbelusca(a)svn.reactos.org wrote:
>   +    if (LSData->Session->UserToken != NULL
> &&
>  +        !ImpersonateLoggedOnUser(LSData->Session->UserToken))
>  +    {
>  +        ERR("ImpersonateLoggedOnUser() failed with error %lu\n",
> GetLastError());
>  +        return 0;
>  +    }
>  +
>  +    /* Attempt to kill remaining processes. No notifications needed. */
>  +    if (!ExitWindowsEx(EWX_CALLER_WINLOGON | EWX_NONOTIFY | EWX_FORCE | EWX_LOGOFF, 0))
>  +    {
>  +        ERR("Unable to kill COM apps, error %lu\n", GetLastError());
>  +        RevertToSelf();
>  +        return 0;
>  +    }
>  +
>  +    if (LSData->Session->UserToken)
>  +        RevertToSelf(); 
Sounds like the RevertToSelf() call in the error case should not be
unconditional.

[Hermès BÉLUSCA - MAÏTO]

Maybe. In any case this is a copy-paste of the existing other thread that
does the exit windows callback.
-----Message d'origine-----
De : Ros-dev [mailto:[e-mail]] De la part de Thomas Faber
Envoyé : vendredi 13 février 2015 08:06
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 66240: [WINLOGON] - Implement
KillComProcesses that just kills with force and without any notification
back to winlogon, any remaining app that is still alive even if we asked
before to ...
On 2015-02-13 00:35, hbelusca(a)svn.reactos.org wrote:
>   +    if (LSData->Session->UserToken != NULL
> &&
>  +        !ImpersonateLoggedOnUser(LSData->Session->UserToken))
>  +    {
>  +        ERR("ImpersonateLoggedOnUser() failed with error %lu\n",
GetLastError());
>   +        return 0;
>  +    }
>  +
>  +    /* Attempt to kill remaining processes. No notifications needed. */
>  +    if (!ExitWindowsEx(EWX_CALLER_WINLOGON | EWX_NONOTIFY | EWX_FORCE |
EWX_LOGOFF, 0))
>   +    {
>  +        ERR("Unable to kill COM apps, error %lu\n", GetLastError());
>  +        RevertToSelf();
>  +        return 0;
>  +    }
>  +
>  +    if (LSData->Session->UserToken)
>  +        RevertToSelf(); 
Sounds like the RevertToSelf() call in the error case should not be
unconditional.
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev