Re: [ros-dev] [ros-diffs] [sir_richard] 52098: [FREELDR]: Some ARM architectures do not necessarily have CS0_BASE at 0x00000000, for example, most Ti OMAP Platforms have DDR at 0x80000000. The current FreeLDR algorithms wou...

[Cameron Gutman]

> ==============================================================================
> --- trunk/reactos/boot/freeldr/freeldr/arcemul/mm.c [iso-8859-1] (original)
> +++ trunk/reactos/boot/freeldr/freeldr/arcemul/mm.c [iso-8859-1] Sun Jun  5 20:48:34 2011
> @@ -30,7 +30,6 @@
>     { { MemoryFirmwareTemporary, 0x80, 0x10 }, 4, }, // File system read buffer. FILESYSBUFFER
>     { { MemoryFirmwareTemporary, 0x90, 0x10 }, 5, }, // Disk read buffer for int 13h. DISKREADBUFFER
>     { { MemoryFirmwarePermanent, 0xA0, 0x60 }, 6, }, // ROM / Video
> { { MemorySpecialMemory, 0xFFF, 1 }, 7, }, // unusable memory
>
> #elif __arm__ // This needs to be done per-platform specific way
> #endif

This part breaks boot with AC97.
> Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/mem...
> ==============================================================================
> --- trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] (original)
> +++ trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] Sun Jun  5 20:48:34 2011
> @@ -307,9 +322,9 @@
>             case MemorySpecialMemory:
>             {
>                 //
>            // Special reserved memory
>            //
>            MemoryMapPageAllocated = LoaderSpecialMemory;
>            // OS Loader Stack
>            //
>            MemoryMapPageAllocated = LoaderOsloaderStack;
>           break;
>       }
>       default:

I assume this is also related.

Cameron Gutman

[Alex Ionescu]

You guys are booting ARM with AC97 now?

Or does your compiler generate x86 code when the code is inside an #if __arm__ statement?

Or... PEBKAC? :D

--
Best regards,
Alex Ionescu

On 2011-06-06, at 9:57 AM, Cameron Gutman wrote:
> > { { MemorySpecialMemory, 0xFFF, 1 }, 7, }, // unusable memory
> >
> > #elif __arm__ // This needs to be done per-platform specific way
> > #endif
>
> This part breaks boot with AC97.