right way form shared modules

Hello

I want port some function from wine kernel32.dll to ReactOS 
kernel32.dll but have some problems.
First i have two modules and the question is where is the right place 
to put them.
I need /tools/unicode/wctype.c also here /dll/win32/kernel32/misc/ to 
compile.

1.) Is it better to leave this module in /tools/unicode/ ?
        -> What must i write in kernel32.rbuild to build this module 
with kernel32.dll

2.) or copy this file to /dll/win32/kernel32/misc/

the second solution is a bit ugly because we have tow files whit the 
same contents.

3.) ???

thanks
Daniel










________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com

[Maarten Bosma]

De /tools folder is for compile time tools.

Best regrades,
Maarten Bosma

On Feb 6, 2008 7:43 PM, <netzimme(a)aim.com> wrote:

>   Hello
>
>  I want port some function from wine kernel32.dll to ReactOS
>  kernel32.dll but have some problems.
>  First i have two modules and the question is where is the right place
>  to put them.
>  I need /tools/unicode/wctype.c also here /dll/win32/kernel32/misc/ to
>  compile.
>
>  1.) Is it better to leave this module in /tools/unicode/ ?
>         -> What must i write in kernel32.rbuild to build this module
>  with kernel32.dll
>
>  2.) or copy this file to /dll/win32/kernel32/misc/
>
>  the second solution is a bit ugly because we have tow files whit the
>  same contents.
>
>  3.) ???
>
>  thanks
>  Daniel
>
>
>
>
>
>
>
>
>
>
>  ________________________________________________________________________
>  More new features than ever.  Check out the new AIM(R) Mail ! -
>  http://webmail.aim.com
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Colin Finck]

Which host tools still need libunicode by the way?
I looked into Wine CVS and they merged the Unicode stuff into libwine there.
The Unicode tables were also updated several times.
 
I don't think anything would hinder us from doing the same.
If a host tool really needs these libraries, we could create both a .mak and
an .rbuild file for it like we did for cmlib or inflib.
 
Best regards,
 
Colin
 



  _____  

From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Maarten Bosma
Sent: Wednesday, February 06, 2008 8:57 PM
To: ReactOS Development List
Subject: Re: [ros-dev] right way form shared modules


De /tools folder is for compile time tools.

Best regrades,
Maarten Bosma


On Feb 6, 2008 7:43 PM, <netzimme(a)aim.com> wrote:


Hello

I want port some function from wine kernel32.dll to ReactOS
kernel32.dll but have some problems.
First i have two modules and the question is where is the right place
to put them.
I need /tools/unicode/wctype.c also here /dll/win32/kernel32/misc/ to
compile.

1.) Is it better to leave this module in /tools/unicode/ ?
       -> What must i write in kernel32.rbuild to build this module
with kernel32.dll

2.) or copy this file to /dll/win32/kernel32/misc/

the second solution is a bit ugly because we have tow files whit the
same contents.

3.) ???

thanks
Daniel










________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! -
http://webmail.aim.com
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Thanks for the answer

I have take a look in cmlib. This is used in difference places also.

The /tools/unicode code is still used for /tools/wmc.
So a solution were to build a /lib/unicode and link with kernel32.dll 
and
wmc.exe.

Perhapses this modules can synced with wine. I have test ReactOS with 
the Kernel32_test.exe locale
 from wine and there are still 104 error. With a sync to new wine 
function this can reduce to 4 error.

I try to create a patch.

Greetings
Daniel



-----Original Message-----
From: Colin Finck <mail(a)colinfinck.de>
To: 'ReactOS Development List' <ros-dev(a)reactos.org>
Sent: Wed, 6 Feb 2008 10:37 pm
Subject: Re: [ros-dev] right way form shared modules

Which host tools still need libunicode by the
way?
I
looked into Wine CVS and they merged the Unicode stuff into libwine 
there. The
Unicode tables were also updated several times.

I
don't think anything would hinder us from doing the same.
If a host tool really needs these libraries, we could create both a 
.mak
and an .rbuild file for it like we did for cmlib or inflib.

Best regards,

Colin





  From: ros-dev-bounces(a)reactos.org
  [mailto:[e-mail]] On Behalf Of Maarten
  Bosma
Sent: Wednesday, February 06, 2008 8:57 PM
To:
  ReactOS Development List
Subject: Re: [ros-dev] right way form
  shared modules


  De /tools folder is for compile time tools.

Best
  regrades,
Maarten Bosma


  On Feb 6, 2008 7:43 PM, netzimme(a)aim.com> wrote:

  Hello

I
    want port some function from wine kernel32.dll to ReactOS
kernel32.dll
    but have some problems.
First i have two modules and the question is
    where is the right place
to put them.
I need /tools/unicode/wctype.c
    also here /dll/win32/kernel32/misc/ to
compile.

1.) Is it better
    to leave this module in /tools/unicode/ ?

     -> What must i write in kernel32.rbuild to build this
    module
with kernel32.dll

2.) or copy this file to
    /dll/win32/kernel32/misc/

the second solution is a bit ugly because
    we have tow files whit the
same contents.

3.)
    ???

thanks
Daniel










________________________________________________________________________
More
    new features than ever.  Check out the new AIM(R) Mail ! -
http://webmail.aim.com
_______________________________________________
Ros-dev
    mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev____________________________…
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev



________________________________________________________________________
More new features than ever.  Check out the new AIM(R) Mail ! - 
http://webmail.aim.com