Re: [ros-dev] [ros-diffs] [dreimer] 45050: Ok, last time I delete my built main tree while playing with clean in a branch! Now clean cleans the branch you are in!

[Colin Finck]

dreimer(a)svn.reactos.org wrote:
>   URL:
> http://svn.reactos.org/svn/reactos?rev=45050&view=rev 
FYI, I already have a change like this ready for some months, see
http://reactos.colinfinck.de/files/Other_Stuff/Clean.cmd

I won't commit it though, because after a suggestion from KJK, I agree that
it would be the best if RosBE's basic clean logic goes into the Makefile
itself and RosBE's clean scripts only call "make rosbe-clean" (or whatever
it'll be called) afterwards.
Then no RosBE clean script would ever need to care about the environment
variables for object and output pathes again. We would stop duplicating
logic in the Makefile and in RosBE and a simple "clean" would always operate
on the same tree as a "make" by design.

This is another change that should be finished before we release RosBE 1.5,
because it'll break compatibility with older revisions (just like the new
toolchain will do), and I want to avoid doing this too often.

Best regards,

Colin

[Daniel Reimer]

Colin Finck schrieb:
>   dreimer(a)svn.reactos.org wrote:
>     
> >   URL:
> > http://svn.reactos.org/svn/reactos?rev=45050&view=rev
> >        
>  FYI, I already have a change like this ready for some months, see
>  http://reactos.colinfinck.de/files/Other_Stuff/Clean.cmd
>
>  I won't commit it though, because after a suggestion from KJK, I agree that
>  it would be the best if RosBE's basic clean logic goes into the Makefile
>  itself and RosBE's clean scripts only call "make rosbe-clean" (or whatever
>  it'll be called) afterwards.
>  Then no RosBE clean script would ever need to care about the environment
>  variables for object and output pathes again. We would stop duplicating
>  logic in the Makefile and in RosBE and a simple "clean" would always operate
>  on the same tree as a "make" by design.
>
>  This is another change that should be finished before we release RosBE 1.5,
>  because it'll break compatibility with older revisions (just like the new
>  toolchain will do), and I want to avoid doing this too often.
>
>  Best regards,
>
>  Colin
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>
>      
I know of kjk's plans. But after killing my 2 hours taking base tree by 
accident I wanted to fix that regardless if its getting useless in some 
daysw/weeks/months.
But I did not know of your clean.cmd. Looks nice. *backingup*

[Olaf Siejka]

FINALLY!

Btw... is this fuss really necessary? As we are basically talking about
something like:

del makefile.auto
rmdir output-i386 /s /q
rmdir obj-i386 /s /q

executed from the root of svn tree directory. Anyway, i don't care as much
as before, when my buildtime wasnt below 12 minutes, but i do applaud to
this change.

2010/1/12 Daniel Reimer <daniel.reimer(a)stud-mail.uni-wuerzburg.de>

>   Colin Finck schrieb:
> >   dreimer(a)svn.reactos.org wrote:
> >
> > >   URL:
> > > http://svn.reactos.org/svn/reactos?rev=45050&view=rev
> > >  
> >  FYI, I already have a change like this ready for some months, see
> >  http://reactos.colinfinck.de/files/Other_Stuff/Clean.cmd
> >  
>