ROS-Diffs fails on special characters in commit message

[Thomas Faber]

Hi,

I've noticed that the ROS-Diffs list (or rather the hook sending to it)
consistently fails on revisions that have special chars in their commit
message.

E.g. there is no message for r56846, r56844, r56763, r56754 etc.
(sorry Hermès :p)
This goes back as far as r23711 (August 2006), for which the archive
shows no message [1].
It apparently did work at some point because r20354 (December 2005) and
earlier seem to have ROS-Diffs messages [2] (although possibly because
special chars didn't make it into the mails' subjects).

Is there a chance this could be fixed?
And in the meantime, could I ask the devs to refrain from using special
chars? (don't know about you, but the missing messages are quite an
annoyance to me, as this is the most convenient platform for code
review)

Thanks!

-Thomas

[1] http://www.reactos.org/pipermail/ros-diffs/2006-August/thread.html
[2] http://www.reactos.org/pipermail/ros-diffs/2005-December/010731.html

[Pierre Schweitzer]

Hi,

this should be fixed now.

With my best regards

On Jul 7, 2012, at 5:56 PM, Thomas Faber wrote:
> Hi,
>
> I've noticed that the ROS-Diffs list (or rather the hook sending to it)
> consistently fails on revisions that have special chars in their commit
> message.
>
> E.g. there is no message for r56846, r56844, r56763, r56754 etc.
> (sorry Hermès :p)
> This goes back as far as r23711 (August 2006), for which the archive
> shows no message [1].
> It apparently did work at some point because r20354 (December 2005) and
> earlier seem to have ROS-Diffs messages [2] (although possibly because
> special chars didn't make it into the mails' subjects).
>
> Is there a chance this could be fixed?
> And in the meantime, could I ask the devs to refrain from using special
> chars? (don't know about you, but the missing messages are quite an
> annoyance to me, as this is the most convenient platform for code
> review)
>
> Thanks!
>
> -Thomas
>
> [1] http://www.reactos.org/pipermail/ros-diffs/2006-August/thread.html
> [2] http://www.reactos.org/pipermail/ros-diffs/2005-December/010731.html
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

--
Pierre Schweitzer [e-mail]
System Administrator
ReactOS Foundation