Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something

[Thomas Faber]

On 2014-04-18 23:40, [e-mail] wrote:
> --- trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] (original)
> +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] Fri Apr 18 21:40:02 2014
> @@ -129,7 +131,7 @@
>  BOOLEAN
>  CdfsFCBIsRoot(PFCB Fcb)
>  {
> return(wcscmp(Fcb->PathName, L"\") == 0);
> return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\');
>
> }

==

Generally I'm seeing a lot of manual work where
RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.

[Pierre Schweitzer]

Thanks for your feedback. I fixed these.

On 19/04/2014 09:31, Thomas Faber wrote:
> On 2014-04-18 23:40, [e-mail] wrote:
> > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] (original)
> > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] Fri Apr 18 21:40:02 2014
> > @@ -129,7 +131,7 @@
> >  BOOLEAN
> >  CdfsFCBIsRoot(PFCB Fcb)
> >  {
> > return(wcscmp(Fcb->PathName, L"\") == 0);
> > return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\');
> >
> > }
>
> ==
>
> Generally I'm seeing a lot of manual work where
> RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Pierre Schweitzer<pierre at reactos.org>
System Administrator
ReactOS Foundation

[Alexander Andrejevic]

Hi,

Correct me if I'm wrong, but the original version didn't modify the string length.
Are you sure that should be "=" and not "=="?

Regards,
Alex

On Sat, Apr 19, 2014 at 09:31:44AM +0200, Thomas Faber wrote:
> On 2014-04-18 23:40, [e-mail] wrote:
> > --- trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] (original)
> > +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c	[iso-8859-1] Fri Apr 18 21:40:02 2014
> > @@ -129,7 +131,7 @@
> >  BOOLEAN
> >  CdfsFCBIsRoot(PFCB Fcb)
> >  {
> > return(wcscmp(Fcb->PathName, L"\") == 0);
> > return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\');
> >
> > }
>
> ==
>
> Generally I'm seeing a lot of manual work where
> RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Alexander Andrejevic [e-mail]
SDF Public Access UNIX System - http://sdf.lonestar.org