Re: [ros-svn] [ion] 16728: - Don't try to get the length of a possibly empty string. This fixes many menu applications (such as WinRAR). However I'm now getting a bug due to a double-free. It seems a GDI Object is being freed twice. Can anyone check this out please?
ion@svn.reactos.com wrote:
- Don't try to get the length of a possibly empty string. This fixes many menu applications (such as WinRAR). However I'm now getting a bug due to a double-free. It seems a GDI Object is being freed twice. Can anyone check this out please?
With the combination of this patch + Hartmut's patch + DBG = 0 build (and/or disabling RZ detection), Winrar runs fine again. However, pressing OK in the dialog bug causes a crash in RtlFreeUnicodeString->RtlpFreeMemory->ExFreePool. It seems the buffer is invalid. So it looks like two things have to be fixed for Winrar and other apps to work fine (Windows Commander does work now):
1) Stop the GDI Object from being freed twice. This will fix the first bugcheck and allow Winrar to work in DBG = 1 with RZ enabled. Disabling RZ is only a hack and shouldn't be used a solution. The stack trace ships the double-free routine pretty well, but I'm not well versed in win32k to fix this.
2) Find out why we are RtlFreeUnicodestring-ing what seems to be an invalid pointer.
I think if we can fix these two issues we'll have many more apps working again! I've tested Winrar 3.50 b7, btw.
Best regards, Alex Ionescu
How about blockers? When is it time for the next Release Candidate. I can't figure out when it's time because I don't find into bugzilla anymore.. (as the site is down)
Alex Ionescu wrote:
ion@svn.reactos.com wrote:
- Don't try to get the length of a possibly empty string. This fixes
many menu applications (such as WinRAR). However I'm now getting a bug due to a double-free. It seems a GDI Object is being freed twice. Can anyone check this out please?
With the combination of this patch + Hartmut's patch + DBG = 0 build (and/or disabling RZ detection), Winrar runs fine again. However, pressing OK in the dialog bug causes a crash in RtlFreeUnicodeString->RtlpFreeMemory->ExFreePool. It seems the buffer is invalid. So it looks like two things have to be fixed for Winrar and other apps to work fine (Windows Commander does work now):
- Stop the GDI Object from being freed twice. This will fix the first
bugcheck and allow Winrar to work in DBG = 1 with RZ enabled. Disabling RZ is only a hack and shouldn't be used a solution. The stack trace ships the double-free routine pretty well, but I'm not well versed in win32k to fix this.
- Find out why we are RtlFreeUnicodestring-ing what seems to be an
invalid pointer.
I think if we can fix these two issues we'll have many more apps working again! I've tested Winrar 3.50 b7, btw.
Best regards, Alex Ionescu _______________________________________________ Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
blight_ has a wiki to track the blockers. Alex and I have tracked down the commit that causes my laptop to fail on stage 1 of loading. it is related to i8042.sys(commit 14926). Alex has given me a patch to test help track it down more and i will assume this bug will be taken care of very soon.
Brandon
Robert Köpferl wrote:
How about blockers? When is it time for the next Release Candidate. I can't figure out when it's time because I don't find into bugzilla anymore.. (as the site is down)
Alex Ionescu wrote:
ion@svn.reactos.com wrote:
- Don't try to get the length of a possibly empty string. This fixes
many menu applications (such as WinRAR). However I'm now getting a bug due to a double-free. It seems a GDI Object is being freed twice. Can anyone check this out please?
With the combination of this patch + Hartmut's patch + DBG = 0 build (and/or disabling RZ detection), Winrar runs fine again. However, pressing OK in the dialog bug causes a crash in RtlFreeUnicodeString->RtlpFreeMemory->ExFreePool. It seems the buffer is invalid. So it looks like two things have to be fixed for Winrar and other apps to work fine (Windows Commander does work now):
- Stop the GDI Object from being freed twice. This will fix the
first bugcheck and allow Winrar to work in DBG = 1 with RZ enabled. Disabling RZ is only a hack and shouldn't be used a solution. The stack trace ships the double-free routine pretty well, but I'm not well versed in win32k to fix this.
- Find out why we are RtlFreeUnicodestring-ing what seems to be an
invalid pointer.
I think if we can fix these two issues we'll have many more apps working again! I've tested Winrar 3.50 b7, btw.
Best regards, Alex Ionescu _______________________________________________ Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.com http://reactos.com:8080/mailman/listinfo/ros-dev
Robert Köpferl wrote:
How about blockers?
Almost all the blockers have been fixed except the Shift Key bug and Context Menu bug. The context menu bug seems a rather large patch and I'm not sure if Filip will have the time/mood to do it... in any case it looks like 0.2.7 is till 2-3 weeks from now, so the fix might get in. As for the shift key bug, I think there is still some work being done on it.
I'm also working with Brandon and Gge to fix two other critical bugs, althoug they aren't blockers (nevertheless Brandon's worries me a lot since it would kill installation for a large number of uses).
I think in another week RC2 will be ready...
Best regards, Alex Ionescu
-
Alex Ionescu -
Brandon Turner -
Robert Köpferl