Re: [ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)
30 Aug
2008
30 Aug
'08
11 p.m.
Please make sure that these types are available for DRIVERS as well --
otherwise, they belong in the NDK. (Check with WDK
wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access
pointers/structures of this type, it must be in the NDK).
Also, the NDK does not include winnt.h -- at least it's not supposed
to, unless someone broke it.
For the future, please make suer to review NDK changes with me, since
I'm still its owner.
Best regards,
Alex Ionescu
On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg(a)svn.reactos.org> wrote:
Author: sginsberg
Date: Sat Aug 30 16:34:56 2008
New Revision: 35819
URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev
Log:
- CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need
to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks
build)
Modified:
trunk/reactos/include/ndk/ketypes.h
Modified: trunk/reactos/include/ndk/ketypes.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/ketypes.h?rev=…
==============================================================================
--- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original)
+++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30 16:34:56 2008
@@ -542,17 +542,6 @@
} KAPC_ENVIRONMENT;
//
-// CPU Cache Types
-//
-typedef enum _PROCESSOR_CACHE_TYPE
-{
- CacheUnified,
- CacheInstruction,
- CacheData,
- CacheTrace,
-} PROCESSOR_CACHE_TYPE;
-
-//
// PRCB DPC Data
//
typedef struct _KDPC_DATA
@@ -571,18 +560,6 @@
struct _GENERAL_LOOKASIDE *P;
struct _GENERAL_LOOKASIDE *L;
} PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST;
-
-//
-// CPU Cache Descriptor
-//
-typedef struct _CACHE_DESCRIPTOR
-{
- UCHAR Level;
- UCHAR Associativity;
- USHORT LineSize;
- ULONG Size;
- PROCESSOR_CACHE_TYPE Type;
-} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR;
//
// Architectural Types
31 Aug
31 Aug
8:14 a.m.
New subject: [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)
They are in 6001/inc/api/winnt.h.
WBR,
Aleksey Bragin.
On Aug 31, 2008, at 3:00 AM, Alex Ionescu wrote:
Please make sure that these types are available for
DRIVERS as well --
otherwise, they belong in the NDK. (Check with WDK
wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access
pointers/structures of this type, it must be in the NDK).
Also, the NDK does not include winnt.h -- at least it's not supposed
to, unless someone broke it.
For the future, please make suer to review NDK changes with me, since
I'm still its owner.
Best regards,
Alex Ionescu
On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg(a)svn.reactos.org> wrote:
Author: sginsberg
Date: Sat Aug 30 16:34:56 2008
New Revision: 35819
URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev
Log:
- CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined
in winnt.h, so no need to define them in the NDK (the NDK includes
winnt.h through windef.h, so this breaks build)
Modified:
trunk/reactos/include/ndk/ketypes.h
Modified: trunk/reactos/include/ndk/ketypes.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/
ketypes.h?rev=35819&r1=35818&r2=35819&view=diff
=====================================================================
=========
--- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original)
+++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30
16:34:56 2008
@@ -542,17 +542,6 @@
} KAPC_ENVIRONMENT;
//
-// CPU Cache Types
-//
-typedef enum _PROCESSOR_CACHE_TYPE
-{
- CacheUnified,
- CacheInstruction,
- CacheData,
- CacheTrace,
-} PROCESSOR_CACHE_TYPE;
-
-//
// PRCB DPC Data
//
typedef struct _KDPC_DATA
@@ -571,18 +560,6 @@
struct _GENERAL_LOOKASIDE *P;
struct _GENERAL_LOOKASIDE *L;
} PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST;
-
-//
-// CPU Cache Descriptor
-//
-typedef struct _CACHE_DESCRIPTOR
-{
- UCHAR Level;
- UCHAR Associativity;
- USHORT LineSize;
- ULONG Size;
- PROCESSOR_CACHE_TYPE Type;
-} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR;
//
// Architectural Types
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
11:20 a.m.
New subject: [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)
Did you purposedly completely ignore what I wrote?
Best regards,
Alex Ionescu
On Sun, Aug 31, 2008 at 10:14 AM, Aleksey Bragin <aleksey(a)reactos.org> wrote:
They are in 6001/inc/api/winnt.h.
WBR,
Aleksey Bragin.
On Aug 31, 2008, at 3:00 AM, Alex Ionescu wrote:
Please make sure that these types are available
for DRIVERS as well --
otherwise, they belong in the NDK. (Check with WDK
wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access
pointers/structures of this type, it must be in the NDK).
Also, the NDK does not include winnt.h -- at least it's not supposed
to, unless someone broke it.
For the future, please make suer to review NDK changes with me, since
I'm still its owner.
Best regards,
Alex Ionescu
On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg(a)svn.reactos.org> wrote:
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
Author: sginsberg
Date: Sat Aug 30 16:34:56 2008
New Revision: 35819
URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev
Log:
- CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined
in winnt.h, so no need to define them in the NDK (the NDK includes
winnt.h through windef.h, so this breaks build)
Modified:
trunk/reactos/include/ndk/ketypes.h
Modified: trunk/reactos/include/ndk/ketypes.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/
ketypes.h?rev=35819&r1=35818&r2=35819&view=diff
=====================================================================
=========
--- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original)
+++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30
16:34:56 2008
@@ -542,17 +542,6 @@
} KAPC_ENVIRONMENT;
//
-// CPU Cache Types
-//
-typedef enum _PROCESSOR_CACHE_TYPE
-{
- CacheUnified,
- CacheInstruction,
- CacheData,
- CacheTrace,
-} PROCESSOR_CACHE_TYPE;
-
-//
// PRCB DPC Data
//
typedef struct _KDPC_DATA
@@ -571,18 +560,6 @@
struct _GENERAL_LOOKASIDE *P;
struct _GENERAL_LOOKASIDE *L;
} PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST;
-
-//
-// CPU Cache Descriptor
-//
-typedef struct _CACHE_DESCRIPTOR
-{
- UCHAR Level;
- UCHAR Associativity;
- USHORT LineSize;
- ULONG Size;
- PROCESSOR_CACHE_TYPE Type;
-} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR;
//
// Architectural Types
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev 
11:55 a.m.
New subject: [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)
The NDK includes winnt.h through umtypes.h -> windef.h -> winnt.h (MS PSDK's
windef.h includes winnt.h too, so I assumed this was correct).
If this is wrong then how should it be done?
Date: Sun, 31 Aug 2008 01:00:18 +0200
From: ionucu(a)videotron.ca
To: ros-dev(a)reactos.org
Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR
and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in
the NDK (the NDK includes winnt.h through windef.h, so this breaks build)
Please make sure that these types are available for DRIVERS as well --
otherwise, they belong in the NDK. (Check with WDK
wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access
pointers/structures of this type, it must be in the NDK).
Also, the NDK does not include winnt.h -- at least it's not supposed
to, unless someone broke it.
For the future, please make suer to review NDK changes with me, since
I'm still its owner.
Best regards,
Alex Ionescu
On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg(a)svn.reactos.org> wrote:
_________________________________________________________________
Connect to the next generation of MSN Messenger
http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&sou…
Author: sginsberg
Date: Sat Aug 30 16:34:56 2008
New Revision: 35819
URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev
Log:
- CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need
to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks
build)
Modified:
trunk/reactos/include/ndk/ketypes.h
Modified: trunk/reactos/include/ndk/ketypes.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/ketypes.h?rev=…
==============================================================================
--- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original)
+++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30 16:34:56 2008
@@ -542,17 +542,6 @@
} KAPC_ENVIRONMENT;
//
-// CPU Cache Types
-//
-typedef enum _PROCESSOR_CACHE_TYPE
-{
- CacheUnified,
- CacheInstruction,
- CacheData,
- CacheTrace,
-} PROCESSOR_CACHE_TYPE;
-
-//
// PRCB DPC Data
//
typedef struct _KDPC_DATA
@@ -571,18 +560,6 @@
struct _GENERAL_LOOKASIDE *P;
struct _GENERAL_LOOKASIDE *L;
} PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST;
-
-//
-// CPU Cache Descriptor
-//
-typedef struct _CACHE_DESCRIPTOR
-{
- UCHAR Level;
- UCHAR Associativity;
- USHORT LineSize;
- ULONG Size;
- PROCESSOR_CACHE_TYPE Type;
-} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR;
//
// Architectural Types
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
5959
days inactive
5960
days old
3 comments
3 participants
participants (3)
-
Aleksey Bragin -
Alex Ionescu -
Stefan Ginsberg