Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] convert hivecls.inf and hivedef.inf to UTF16LE fixes CORE-7614

[Thomas Faber]

This is not the right solution. SVN has terrible UTF-16 handling so we
should not convert these back to UTF-16.

https://jira.reactos.org/browse/CORE-7703
https://jira.reactos.org/browse/CORE-8221

On 2014-05-25 22:17, cwittich(a)svn.reactos.org wrote:
>   Author: cwittich
>  Date: Sun May 25 20:17:25 2014
>  New Revision: 63452
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=63452&view=rev
>  Log:
>  [bootdata]
>  convert hivecls.inf and hivedef.inf to UTF16LE
>  fixes CORE-7614
>  
>  Modified:
>      trunk/reactos/boot/bootdata/hivecls.inf   (contents, props changed)
>      trunk/reactos/boot/bootdata/hivedef.inf   (contents, props changed)
>

[Christoph von Wittich]

Did you notice the mime type I set?

----- Ursprüngliche Nachricht -----
Von: "Thomas Faber" <thomas.faber(a)reactos.org>
Gesendet: ‎26.‎05.‎2014 01:11
An: "ros-dev(a)reactos.org" <ros-dev(a)reactos.org>
Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] converthivecls.inf and
hivedef.inf to UTF16LE fixes CORE-7614

This is not the right solution. SVN has terrible UTF-16 handling so we
should not convert these back to UTF-16.

https://jira.reactos.org/browse/CORE-7703
https://jira.reactos.org/browse/CORE-8221

On 2014-05-25 22:17, cwittich(a)svn.reactos.org wrote:
>   Author: cwittich
>  Date: Sun May 25 20:17:25 2014
>  New Revision: 63452
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=63452&view=rev
>  Log:
>  [bootdata]
>  convert hivecls.inf and hivedef.inf to UTF16LE
>  fixes CORE-7614
>  
>  Modified:
>      trunk/reactos/boot/bootdata/hivecls.inf   (contents, props changed)
>      trunk/reactos/boot/bootdata/hivedef.inf   (contents, props changed)
>   

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Hermès BÉLUSCA - MAÏTO]

So what about this utf16le tool we have in our codebase ???

H.

 

De : Ros-dev [mailto:[e-mail]] De la part de Christoph von Wittich
Envoyé : lundi 26 mai 2014 07:37
À : ReactOS Development List
Objet : Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] converthivecls.inf and
hivedef.inf to UTF16LE fixes CORE-7614

 

Did you notice the mime type I set?

  _____  

Von: Thomas Faber <mailto:[e-mail]> 
Gesendet: ‎26.‎05.‎2014 01:11
An: ros-dev(a)reactos.org
Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata] converthivecls.inf and
hivedef.inf to UTF16LE fixes CORE-7614

This is not the right solution. SVN has terrible UTF-16 handling so we
should not convert these back to UTF-16.

 <https://jira.reactos.org/browse/CORE-7703>
https://jira.reactos.org/browse/CORE-7703
 <https://jira.reactos.org/browse/CORE-8221>
https://jira.reactos.org/browse/CORE-8221

On 2014-05-25 22:17,  <mailto:[e-mail]> cwittich(a)svn.reactos.org
wrote:
>   Author: cwittich
>  Date: Sun May 25 20:17:25 2014
>  New Revision: 63452
>  
>  URL:  <http://svn.reactos.org/svn/reactos?rev=63452&view=rev>
> http://svn.reactos.org/svn/reactos?rev=63452&view=rev
>  Log:
>  [bootdata]
>  convert hivecls.inf and hivedef.inf to UTF16LE
>  fixes CORE-7614
>  
>  Modified:
>      trunk/reactos/boot/bootdata/hivecls.inf   (contents, props changed)
>      trunk/reactos/boot/bootdata/hivedef.inf   (contents, props changed)
>   

_______________________________________________
Ros-dev mailing list
 <mailto:[e-mail]> Ros-dev(a)reactos.org
 <http://www.reactos.org/mailman/listinfo/ros-dev>
http://www.reactos.org/mailman/listinfo/ros-dev

[Colin Finck]

Christoph von Wittich wrote:
>   Did you notice the mime type I set? 
"text/plain;charset=UTF-16" looks cool, didn't know about this one.
Still, it doesn't make patching any better. I just had a try with
command-line SVN 1.7.9: Changing hivedef.inf a bit, doing "svn diff >
diff.patch", reverting hivedef.inf again and trying "svn patch
diff.patch". The resulting hivedef.inf was totally garbage.

With such bad UTF-16 support for basic tasks, I still don't consider
this a solution. Let's better stick to UTF-8 for these files and convert
them to UTF-16 on the fly. This also denotes the UTF-16 critical files
in the build files.

Matthias has written the utf16le tool for this years ago, it just needs
a simple rule in CMake. Would anybody volunteer?


- Colin

[Christoph von Wittich]

Seems to work only with TSVN :/


-----Ursprüngliche Nachricht-----
Von: Ros-dev [mailto:[e-mail]] Im Auftrag von Colin Finck
Gesendet: Montag, 26. Mai 2014 19:41
An: ros-dev(a)reactos.org
Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63452: [bootdata]
converthivecls.inf and hivedef.inf to UTF16LE fixes CORE-7614

Christoph von Wittich wrote:
>   Did you notice the mime type I set? 
"text/plain;charset=UTF-16" looks cool, didn't know about this one.
Still, it doesn't make patching any better. I just had a try with
command-line SVN 1.7.9: Changing hivedef.inf a bit, doing "svn diff >
diff.patch", reverting hivedef.inf again and trying "svn patch
diff.patch".
The resulting hivedef.inf was totally garbage.

With such bad UTF-16 support for basic tasks, I still don't consider this a
solution. Let's better stick to UTF-8 for these files and convert them to
UTF-16 on the fly. This also denotes the UTF-16 critical files in the build
files.

Matthias has written the utf16le tool for this years ago, it just needs a
simple rule in CMake. Would anybody volunteer?


- Colin

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev