About ATL wrappers - atlex

[Alexander Sh.]

Hello, I am sanchaez (Alexander Shaposhnikov) - a GSoC student working on
RAPPS. I've found a set of useful wrappers for ATL on Github -
https://github.com/Amebis/atlex.
I have some questions:
1. It is GPLv3. Is it compatible with ROS license? Can I use them?
2. If I can, where to place it in the source folders?

P.S. I've rushed a little by committing it to my branch. "It lies in
reactos\sdk\include\reactos" for now.

Thanks in advance,
Alexander

[Colin Finck]

Am 12.07.2017 um 09:27 schrieb Alexander Sh.:> 1. It is GPLv3. Is it
compatible with ROS license? Can I use them?

That would require all developers of RAPPS to agree to a license change
to GPLv3. Doing a

svn log
https://svn.reactos.org/reactos/trunk/reactos/base/applications/rapps
--xml | sed 's@</author>@\n</author>@' | xmllint --xpath
'/log/logentry/author/text()' - | sort | uniq -c | sort -nr

(from https://stackoverflow.com/questions/31612997) yields the following
authors and their number of commits:

158 dreimer
     65 akhaldi
     21 osiejka
     19 tfaber
     19 hbelusca
     17 dgorbachev
     14 dchapyshev
     13 pschweitzer
     12 mkupfer
      9 khornicek
      8 fireball
      7 cwittich
      7 cfinck
      6 zguo
      6 rharabien
      4 tkreuzer
      3 rnaumann
      3 mjansen
      3 gschneider
      3 ekohl
      3 dquintana
      2 spetreolle
      2 janderwald
      2 ilardig
      2 cgutman
      1 sginsberg
      1 jgardou
      1 gedmurphy
      1 gadamopoulos

Note that this may include people who have committed in the past, but
whose code has been rewritten over the time. An "svn blame" on the
current rapps source files should give a more accurate list.
It does not include people though, who have no commit access.

Looking at the source file headers, the main people to ask seem to be
Dmitry Chapyshev ([e-mail]) and Ismael Ferreras Morezuelas
([e-mail]). If you're reading this, please speak up
whether you would be okay with relicensing your code as GPLv3.

Looking at atlex, this library seems to be very new and small though.
Maybe it's easier asking the author if he can relicense his library as
GPLv2 or any later version :)
> If I can, where to place it in the source folders?

reactos/sdk/lib/3rdparty/atlex sounds like the best place to me.

Cheers,

Colin

[Alexander Sh.]

Replying to Colin:
I've contacted the developer of atlex. He seems to agree with licensing the
library as GPLv2+. Since it's the company repository, he waits for a "yes"
from it's legal team.

Track the issue here: https://github.com/Amebis/atlex/issues/2

Alexander

2017-07-12 10:27 GMT+03:00 Alexander Sh. [e-mail]:
> Hello, I am sanchaez (Alexander Shaposhnikov) - a GSoC student working on
> RAPPS. I've found a set of useful wrappers for ATL on Github -
> https://github.com/Amebis/atlex.
> I have some questions:
> It is GPLv3. Is it compatible with ROS license? Can I use them?
> If I can, where to place it in the source folders?
>
> P.S. I've rushed a little by committing it to my branch. "It lies in
> reactos\sdk\include\reactos" for now.
>
> Thanks in advance,
> Alexander

[Alexander Sh.]

The dev changed the license of atlex to "GPLv2 or later" \o/

2017-07-13 15:29 GMT+03:00 Alexander Sh. [e-mail]:
> Replying to Colin:
> I've contacted the developer of atlex. He seems to agree with licensing
> the library as GPLv2+. Since it's the company repository, he waits for a
> "yes" from it's legal team.
>
> Track the issue here: https://github.com/Amebis/atlex/issues/2
>
> Alexander
>
> 2017-07-12 10:27 GMT+03:00 Alexander Sh. [e-mail]:
> > Hello, I am sanchaez (Alexander Shaposhnikov) - a GSoC student working on
> > RAPPS. I've found a set of useful wrappers for ATL on Github -
> > https://github.com/Amebis/atlex.
> > I have some questions:
> > It is GPLv3. Is it compatible with ROS license? Can I use them?
> > If I can, where to place it in the source folders?
> >
> > P.S. I've rushed a little by committing it to my branch. "It lies in
> > reactos\sdk\include\reactos" for now.
> >
> > Thanks in advance,
> > Alexander