Re: [ros-dev] [ros-diffs] [dgorbachev] 41788: "Fix" MDL PROBE FAILED! bug #4663.

[Alex Ionescu]

I'm confused... I've looked through the code, and I don't get what the  
"Break" does here.

Does the ExRaiseStatus somehow end up handled in this path again? That  
means there's a serious SEH2 bug.
On 6-Jul-09, at 11:28 AM, [e-mail] wrote:
> Author: dgorbachev
> Date: Mon Jul  6 22:28:11 2009
> New Revision: 41788
>
> URL: http://svn.reactos.org/svn/reactos?rev=41788&view=rev
> Log:
> "Fix" MDL PROBE FAILED! bug #4663.
>
> Modified:
>    trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c
>
> Modified: trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c?r...
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Mon Jul  6  
> 22:28:11 2009
> @@ -679,6 +679,7 @@
>         // Oops :(
>         //
>         ProbeStatus = _SEH2_GetExceptionCode();
>    _SEH2_YIELD(break);
> }
>   _SEH2_END;

Best regards,
Alex Ionescu

[Dmitry Gorbachev]

Yes, it's a bug in PSEH2, unnoticed. More testcases are needed in psehtest.

[Aleksey Bragin]

If it would be said so (in a commit message, in a bug report), it  
wouldn't provide so big frustration among developers. Otherwise we'll  
end up communicating in C code rather than in human readable language :)

WBR,
Aleksey.

On Jul 7, 2009, at 11:52 AM, Dmitry Gorbachev wrote:
> Yes, it's a bug in PSEH2, unnoticed. More testcases are needed in  
> psehtest.

[Dmitry Gorbachev]

> If it would be said so (in a commit message, in a bug report), it
> wouldn't provide so big frustration among developers. Otherwise we'll
> end up communicating in C code rather than in human readable language :)

Why should be there any frustration because of it?

[Alex Ionescu]

Yes, why is there not a bug report for this on BugZilla, and why are  
the developers screaming murder against the portable group when  
they've uncovered a major PSEH fault?

Reverting their commit, while, yes, 'unbreaking' trunk (and only only  
on the test server anyway), would've caused this issue to go unnoticed  
and perhaps cause headaches later on (without the DPRINT there this  
would've been hard to catch).

On 7-Jul-09, at 5:48 AM, Aleksey Bragin wrote:
> If it would be said so (in a commit message, in a bug report), it
> wouldn't provide so big frustration among developers. Otherwise we'll
> end up communicating in C code rather than in human readable  
> language :)
>
> WBR,
> Aleksey.
>
> On Jul 7, 2009, at 11:52 AM, Dmitry Gorbachev wrote:
> > Yes, it's a bug in PSEH2, unnoticed. More testcases are needed in
> > psehtest.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

Best regards,
Alex Ionescu

[James Tabor]

Hi!

On Tue, Jul 7, 2009 at 11:59 AM, Alex [e-mail] wrote:
> Yes, why is there not a bug report for this on BugZilla, and why are
> the developers screaming murder against the portable group when
> they've uncovered a major PSEH fault?
>
> Reverting their commit, while, yes, 'unbreaking' trunk (and only only
> on the test server anyway), would've caused this issue to go unnoticed
> and perhaps cause headaches later on (without the DPRINT there this
> would've been hard to catch).

Where have I read this before~?
Someone file a bug report! Keep trunk broken! So we can learn how to
fix it. Hiding bugs with hax has been the greatest enemy to this
project, even greater than the wine sabotage back in the audit days!
These hax are still with us and we are managing to get them removed.
Please! We need to know where the PSEH bugs are located so we can
educate the newbies.

Thanks,
James

[Dmitry Gorbachev]

> Hi!
> Where have I read this before~?
> Someone file a bug report! Keep trunk broken! So we can learn how to
> fix it. Hiding bugs with hax has been the greatest enemy to this
> project, even greater than the wine sabotage back in the audit days!
> These hax are still with us and we are managing to get them removed.
> Please! We need to know where the PSEH bugs are located so we can
> educate the newbies.

Hi. Bug report was already filed, I know where the bug is located, the
purpose of the hack was not to hide anything.

[KJK::Hyperion]

Dmitry Gorbachev wrote:
> Yes, it's a bug in PSEH2, unnoticed. More testcases are needed in psehtest.

I just want to make it 100% clear that I will neither investigate nor
fix this bug. ReactOS cannot depend on a piece of code that a single
person understands. Become a SEH/PSEH expert and fix it. Do it before
the PSEH author is hit by a bus, while he can still help you

[Dmitry Gorbachev]

> I just want to make it 100% clear that I will neither investigate nor
> fix this bug. ReactOS cannot depend on a piece of code that a single
> person understands. Become a SEH/PSEH expert and fix it. Do it before
> the PSEH author is hit by a bus, while he can still help you

I can not guarantee, after becoming a SEH/PSEH expert, I will not be
struck by a car, too. :)

[KJK::Hyperion]

Dmitry Gorbachev wrote:
> > I just want to make it 100% clear that I will neither investigate nor
> > fix this bug. ReactOS cannot depend on a piece of code that a single
> > person understands. Become a SEH/PSEH expert and fix it. Do it before
> > the PSEH author is hit by a bus, while he can still help you
>
> I can not guarantee, after becoming a SEH/PSEH expert, I will not be
> struck by a car, too. :)

Clearly we need another volunteer. Stefan? do you want to get hit by a
train?