Re: [ros-dev] [ros-diffs] [tkreuzer] 36379: preprocess all spec files

[Aleksey Bragin]

There is a big problem with this change, originally this was added  
only for "our own" .spec files, which don't have comments starting  
with #.

Wine .spec files have such comments, and thus will be preprocessed  
incorrectly.


WBR,
Aleksey.

On Sep 21, 2008, at 6:34 PM, tkreuzer(a)svn.reactos.org wrote:

>   Author: tkreuzer
>  Date: Sun Sep 21 09:34:48 2008
>  New Revision: 36379
>
>  URL: http://svn.reactos.org/svn/reactos?rev=36379&view=rev
>  Log:
>  preprocess all spec files
>
>  Modified:
>      branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/ 
>  modulehandler.cpp
>
>  Modified: branches/ros-amd64-bringup/reactos/tools/rbuild/backend/ 
>  mingw/modulehandler.cpp
>  URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/ 
>  reactos/tools/rbuild/backend/mingw/modulehandler.cpp? 
>  rev=36379&r1=36378&r2=36379&view=diff

[Thomas Bluemel]

Use -P to inhibit this output: 
http://gcc.gnu.org/onlinedocs/cpp/Invocation.html#index-P-188

Thomas

Aleksey Bragin wrote:
>   There is a big problem with this change, originally
> this was added  
>  only for "our own" .spec files, which don't have comments starting  
>  with #.
>
>  Wine .spec files have such comments, and thus will be preprocessed  
>  incorrectly.
>
>
>  WBR,
>  Aleksey.
>
>  On Sep 21, 2008, at 6:34 PM, tkreuzer(a)svn.reactos.org wrote:
>
>    
> >   Author: tkreuzer
> >  Date: Sun Sep 21 09:34:48 2008
> >  New Revision: 36379
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=36379&view=rev
> >  Log:
> >  preprocess all spec files
> >
> >  Modified:
> >      branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/ 
> >  modulehandler.cpp
> >
> >  Modified: branches/ros-amd64-bringup/reactos/tools/rbuild/backend/ 
> >  mingw/modulehandler.cpp
> >  URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/ 
> >  reactos/tools/rbuild/backend/mingw/modulehandler.cpp? 
> >  rev=36379&r1=36378&r2=36379&view=diff
> >       
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Thomas Bluemel]

I guess I should've read that email more carefully...

Thomas

Thomas Bluemel wrote:
>   Use -P to inhibit this output: 
>  http://gcc.gnu.org/onlinedocs/cpp/Invocation.html#index-P-188
>
>  Thomas
>
>  Aleksey Bragin wrote:
>    
> >   There is a big problem with this change,
> > originally this was added  
> >  only for "our own" .spec files, which don't have comments starting  
> >  with #.
> >
> >  Wine .spec files have such comments, and thus will be preprocessed  
> >  incorrectly.
> >
> >
> >  WBR,
> >  Aleksey.
> >
> >  On Sep 21, 2008, at 6:34 PM, tkreuzer(a)svn.reactos.org wrote:
> >
> >    
> >      
> > >   Author: tkreuzer
> > >  Date: Sun Sep 21 09:34:48 2008
> > >  New Revision: 36379
> > >
> > >  URL: http://svn.reactos.org/svn/reactos?rev=36379&view=rev
> > >  Log:
> > >  preprocess all spec files
> > >
> > >  Modified:
> > >      branches/ros-amd64-bringup/reactos/tools/rbuild/backend/mingw/ 
> > >  modulehandler.cpp
> > >
> > >  Modified: branches/ros-amd64-bringup/reactos/tools/rbuild/backend/ 
> > >  mingw/modulehandler.cpp
> > >  URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/ 
> > >  reactos/tools/rbuild/backend/mingw/modulehandler.cpp? 
> > >  rev=36379&r1=36378&r2=36379&view=diff
> > >      
> > >         
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >    
> >       
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>