On Fri, Jul 3, 2009 at 5:53 AM, dchapyshev@svn.reactos.org wrote:
- if (-1 == (int) Res || ! Res)
- {
- return Res;
- if (-1 == (int) Res || !Res)
- {
- return FALSE;
I know you didn't write the check and were just changing the return values but as a matter of style could we do something like
if (((int) Res || !Res) == -1)
or would the extra parens mess up the order of operations? Not a big deal, its just easier on my eyes.
Thanks
Steven Edwards wrote:
if (((int) Res || !Res) == -1)
Ehhhm, you probably mean something like 'if ((int)Res == -1 || !Res)', don't you? The one you've written makes no sense for me. Maybe that could even be replaced with a simple 'if ((int)Res < 0)', haven't looked at the whole code yet.
Best regards,
Colin
On Sat, Jul 4, 2009 at 7:51 PM, Colin Finckmail@colinfinck.de wrote:
Ehhhm, you probably mean something like 'if ((int)Res == -1 || !Res)', don't you? The one you've written makes no sense for me. Maybe that could even be replaced with a simple 'if ((int)Res < 0)', haven't looked at the whole code yet.
Yeah thats it. The number coming first just does not look good to me but like I said its just a matter of style as I browse the commit messages.