Re: [ros-dev] [ros-diffs] [cgutman] 54016: [HAL] - Implement support for scatter/gather DMA - Tested with Intel's NDIS 5.1 PRO/1000 driver (but more testing would be helpful to weed out bugs) [NDIS] - Report NDIS 5.1 now si...

[Colin Finck]

cgutman(a)svn.reactos.org wrote:
>   - Implement support for scatter/gather DMA 
This commit deserves a huge LIKE button, thanks!

Will try it out as soon as I have access to my ReactOS laptop again. 
Finally a chance for getting its Ethernet port to work :-)


- Colin

[Cameron Gutman]

On Oct 5, 2011, at 7:43 PM, Colin Finck wrote:

>   cgutman(a)svn.reactos.org wrote:
> >   - Implement support for scatter/gather DMA 
>
>  This commit deserves a huge LIKE button, thanks! 
Most of the real backend code for scatter/gather was already there in
IoFlushAdapterBuffers, IoMapTransfer, and IoAllocateAdapterChannel. I just plumbed it all
together and created the SCATTER_GATHER_LIST structure.

>   
>  Will try it out as soon as I have access to my ReactOS laptop again. Finally a chance for
> getting its Ethernet port to work :-)
>   
That would be great! Anyone else who has drivers that use S/G DMA, please try it on trunk
and report your experience.


Regards,
Cameron

[Alex Ionescu]

Great Cam, did Aleksey finally send you my patch?

There's some more complexities, so it'd be great if you can make sure
something works with this driver, than after my changes are
introduced, regtests can be used to see if they break anything.

Best regards,
Alex Ionescu



On Wed, Oct 5, 2011 at 9:04 PM, Cameron Gutman <aicommander(a)gmail.com> wrote:
>  
>  On Oct 5, 2011, at 7:43 PM, Colin Finck wrote:
>
> >   cgutman(a)svn.reactos.org wrote:
> > >   - Implement support for scatter/gather DMA
> >  This commit deserves a huge LIKE button, thanks! 
>  Most of the real backend code for scatter/gather was already there in
> IoFlushAdapterBuffers, IoMapTransfer, and IoAllocateAdapterChannel. I just plumbed it all
> together and created the SCATTER_GATHER_LIST structure.
>
> >  
> >  Will try it out as soon as I have access to my ReactOS laptop again. Finally a chance for
> > getting its Ethernet port to work :-)
> >  
>  That would be great! Anyone else who has drivers that use S/G DMA, please try it on trunk
> and report your experience.
>
>
>  Regards,
>  Cameron
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Javier Agustìn Fernàndez Arroyo]

fix/feature of the month? :)

On Thu, Oct 6, 2011 at 3:17 AM, Alex Ionescu <ionucu(a)videotron.ca> wrote:

>   Great Cam, did Aleksey finally send you my patch?
>
>  There's some more complexities, so it'd be great if you can make sure
>  something works with this driver, than after my changes are
>  introduced, regtests can be used to see if they break anything.
>
>  Best regards,
>  Alex Ionescu
>
>
>
>  On Wed, Oct 5, 2011 at 9:04 PM, Cameron Gutman <aicommander(a)gmail.com>
>  wrote:
> >  
> >  On Oct 5, 2011, at 7:43 PM, Colin Finck wrote:
> >
> > >   cgutman(a)svn.reactos.org wrote:
> > > >   - Implement support for scatter/gather DMA
> > >  This commit deserves a huge LIKE button, thanks! 
> >  Most of the real backend code for scatter/gather was already there in 
> IoFlushAdapterBuffers, IoMapTransfer, and IoAllocateAdapterChannel. I just
>  plumbed it all together and created the SCATTER_GATHER_LIST structure.
> >  
> > >
> > > Will try it out as soon as I have access to my ReactOS laptop again. 
>  Finally a
> chance for getting its Ethernet port to work :-)
> > >   
> >  That would be great! Anyone else who has drivers that use S/G DMA, please 
>  try it
> on trunk and report your experience.
> >  
> >
> >  Regards,
> >  Cameron
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Igor Paliychuk]

 I will try it on my nforce2 chipset soon

2011/10/6 Javier Agustìn Fernàndez Arroyo <elhoir(a)gmail.com>

>   fix/feature of the month? :)
>
>
>  On Thu, Oct 6, 2011 at 3:17 AM, Alex Ionescu <ionucu(a)videotron.ca> wrote:
>
> >   Great Cam, did Aleksey finally send you my
> > patch?
> >
> >  There's some more complexities, so it'd be great if you can make sure
> >  something works with this driver, than after my changes are
> >  introduced, regtests can be used to see if they break anything.
> >
> >  Best regards,
> >  Alex Ionescu
> >
> >
> >
> >  On Wed, Oct 5, 2011 at 9:04 PM, Cameron Gutman <aicommander(a)gmail.com>
> >  wrote:
> > >  
> > >  On Oct 5, 2011, at 7:43 PM, Colin Finck wrote:
> > >
> > > >   cgutman(a)svn.reactos.org wrote:
> > > >  > - Implement support for scatter/gather DMA
> > > >
> > > >  This commit deserves a huge LIKE button, thanks! 
> > >  Most of the real backend code for scatter/gather was already there in 
> > IoFlushAdapterBuffers, IoMapTransfer, and IoAllocateAdapterChannel. I just
> >  plumbed it all together and created the SCATTER_GATHER_LIST structure.
> > >  
> > > >
> > > > Will try it out as soon as I have access to my ReactOS laptop again. 
> >  Finally a
> > chance for getting its Ethernet port to work :-)
> > > >   
> > >  That would be great! Anyone else who has drivers that use S/G DMA, 
> >  please try it
> > on trunk and report your experience.
> > >  
> > >
> > >  Regards,
> > >  Cameron
> > >  _______________________________________________
> > >  Ros-dev mailing list
> > >  Ros-dev(a)reactos.org
> > >  http://www.reactos.org/mailman/listinfo/ros-dev
> > >  
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>