Re: [ros-dev] [ros-diffs] [peterw] 31817: Big polish translation patch by Olaf Siejka (caemyr AT gmail DOT com) See issue #2944 for more details. - Polish translation for 0.3.4 is now complete... almost :) One thing left is kernel32 error codes. As it requires inte

[Marc Piulachs]

> trunk/reactos/dll/win32/kernel32/lang/pl-PL.mc   (with props)

IMO is not a good idea to use different mc files for every language. MC file
format is specially designed to hold all the languages in the same file,
also our current WMC implementation does not support splitting translation
across multiple mc files. AFAIK Physcious was working on implementing that
feature to our WMC but even in that case there is no easy way to support
them at rbuild level without introducing a hack, also MS's WMC does not
support it so I think we should keep it to the lowest common denominator and
avoid future compiler compatibility problems as there isn't any significant
advantage on it.

/Marc

[Timo Kreuzer]

Marc Piulachs schrieb:
> > trunk/reactos/dll/win32/kernel32/lang/pl-PL.mc   (with props)
>
> IMO is not a good idea to use different mc files for every language. MC file
> format is specially designed to hold all the languages in the same file,

It is designed to make it possible, but I don't see why it would force 
us to do so.
> also our current WMC implementation does not support splitting translation
> across multiple mc files. AFAIK Physcious was working on implementing that
> feature to our WMC but even in that case there is no easy way to support
> them at rbuild level without introducing a hack, also MS's WMC does not
> support it so I think we should keep it to the lowest common denominator and
> avoid future compiler compatibility problems as there isn't any significant
> advantage on it.

I already compile my kernel32 with 2 mc files ;-) Simply by adding a 
second entry to the rbuild file and to the rc. And it works, both 
message tables are in the dll. For some reason it doesn't work when the 
mc is in the lang subfolder, don't know why.
And I guess there should be no problem with msvc, too.
Advantage: Putting all translations into one file is a real mess and 
will not allow to compile individual languages.
Maybe you can have a look at it and make rbuild use mc files the same 
way as translated rc files.

Timo