Re: [ros-dev] [ros-diffs] [fireball] 31043: - Fix Greatlordisms: * Don't try to link *user*mode program to static *kernelmode* libcntpr. msvcrt.dll exists for this. * Fix main()'s declaration and definition. * The above changes fix compiling of rostest module.

[Alex Ionescu]

Something is wrong with your development process if you believe  
libcntpr is a "kernel-mode" library. I always compile my native  
programs with it on Windows -- in fact so should ntdll in ReactOS. If  
it doesn't you may want to check your brains before bashing  
Greatlord... including msvcrt in a native program is a sure recipe  
for disaster...

--
Best regards,
Alex Ionescu

On 6-Dec-07, at 10:44 AM, fireball(a)svn.reactos.org wrote:

>   Author: fireball
>  Date: Thu Dec  6 18:44:23 2007
>  New Revision: 31043
>
>  URL: http://svn.reactos.org/svn/reactos?rev=31043&view=rev
>  Log:
>  - Fix Greatlordisms:
>  * Don't try to link *user*mode program to static *kernelmode*  
>  libcntpr. msvcrt.dll exists for this.
>  * Fix main()'s declaration and definition.
>  * The above changes fix compiling of rostest module.
>
>  Modified:
>      trunk/rostests/tests/D3DParseUnknownCommand_show/ 
>  D3DParseUnknownCommand_show.rbuild
>      trunk/rostests/tests/D3DParseUnknownCommand_show/main.c
>
>  Modified: trunk/rostests/tests/D3DParseUnknownCommand_show/ 
>  D3DParseUnknownCommand_show.rbuild
>  URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/ 
>  D3DParseUnknownCommand_show/D3DParseUnknownCommand_show.rbuild? 
>  rev=31043&r1=31042&r2=31043&view=diff
>  ====================================================================== 
>  ========
>  --- trunk/rostests/tests/D3DParseUnknownCommand_show/ 
>  D3DParseUnknownCommand_show.rbuild (original)
>  +++ trunk/rostests/tests/D3DParseUnknownCommand_show/ 
>  D3DParseUnknownCommand_show.rbuild Thu Dec  6 18:44:23 2007
>  @@ -5,7 +5,6 @@
>   	<library>kernel32</library>
>   	<library>gdi32</library>
>   	<library>ddraw</library>
>  -	<library>libcntpr</library>
>   	<library>user32</library>
>   	<file>main.c</file>
>   </module>
>
>  Modified: trunk/rostests/tests/D3DParseUnknownCommand_show/main.c
>  URL: http://svn.reactos.org/svn/reactos/trunk/rostests/tests/ 
>  D3DParseUnknownCommand_show/main.c? 
>  rev=31043&r1=31042&r2=31043&view=diff
>  ====================================================================== 
>  ========
>  --- trunk/rostests/tests/D3DParseUnknownCommand_show/main.c (original)
>  +++ trunk/rostests/tests/D3DParseUnknownCommand_show/main.c Thu  
>  Dec  6 18:44:23 2007
>  @@ -22,10 +22,10 @@
>    *
>    */
>
>  -INT main(INT argc, CHAR argv[]);
>  +INT main(INT argc, TCHAR *argv[]);
>   VOID BuildReturnCode(DWORD * ReturnCode);
>
>  -INT main(INT argc, TCHAR argv[])
>  +INT main(INT argc, TCHAR *argv[])
>   {
>       DWORD ReturnCode[256];
>
>  @@ -44,6 +44,6 @@
>       {
>          dp2command.bCommand = t;
>          ReturnCode[t] = D3DParseUnknownCommand ( (LPVOID)  
>  &dp2command, (LPVOID *) lplpvReturnedCommand) ;
>  -       printf("D3DParseUnknownCommand return code = %x command %d  
>  \n", ReturnCode[t], t);
>  +       printf("D3DParseUnknownCommand return code = %x command %d  
>  \n", (UINT)ReturnCode[t], t);
>       }
>   }
>
>