Re: [ros-dev] [ros-diffs] [mkupfer] 43292: temporarily workaround for swap mouse buttons feature

[Timo Kreuzer]

CurInfo is an overengineered reactos construct. Mouse stuff is only
relevant for an interactive Windowstation and there is only one per
session. This way is correct,.but using the global variable
gspv.bMouseBtnSwap directly would be better.

Regards,
Timo


mkupfer(a)svn.reactos.org schrieb:
>   Author: mkupfer
>  Date: Sun Oct  4 22:45:51 2009
>  New Revision: 43292
>
>  URL: http://svn.reactos.org/svn/reactos?rev=43292&view=rev
>  Log:
>  temporarily workaround for swap mouse buttons feature
>
>  Modified:
>      trunk/reactos/subsystems/win32/win32k/ntuser/input.c
>
>  Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt…
>  ==============================================================================
>  --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] (original)
>  +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] Sun Oct  4 22:45:51
> 2009
>  @@ -1120,7 +1120,8 @@
>         mi->time = MsqCalculateMessageTime(&LargeTickCount);
>      }
>   
>  -   SwapButtons = CurInfo->SwapButtons;
>  +   // FIXME: CurInfo->SwapButtons doesn't contain the correct value yet
>  +   SwapButtons = UserGetSystemMetrics(SM_SWAPBUTTON);//CurInfo->SwapButtons;
>      DoMove = FALSE;
>   
>      IntGetCursorLocation(WinSta, &MousePos);
>
>
>
>

[Matthias Kupfer]

Am Montag, 5. Oktober 2009 10:22:05 schrieb Timo Kreuzer:
>   CurInfo is an overengineered reactos construct. Mouse
> stuff is only
>  relevant for an interactive Windowstation and there is only one per
>  session. This way is correct,.but using the global variable
>  gspv.bMouseBtnSwap directly would be better. 
Regarding to your sysparams-rewrite I'm trying to fix. Maybe you know the 
different registry key types REG_SZ and REG_DWORD.  Your rewrite only uses 
REG_SZ for integer values which is mostly wrong and result in issues hard to 
find (like MouseBtnSwap).

I think the rewrite wasn't well-thought at this point and a lot of calls are 
still wrong. Maybe you can fix this, because at present some of your SpiSet* 
change the types of registry keys which is dangerous as well...

Regards,
Matthias

-- 
Matthias Kupfer          phone [phone]
Wilhelm-Firl-Straße 21   mobile [phone]
09122 Chemnitz, Germany

[Colin Finck]

Matthias Kupfer wrote:
>   Your rewrite only uses REG_SZ for integer values
> which
>  is mostly wrong [...] 
This is what Windows uses as well, at least my WinXP for most of the
HKCU\Control Panel subkeys. (also for that "SwapMouseButtons" setting for
example)

Expect applications to be out there, which do not or even cannot use
GetSystemMetrics and thus read REG_SZ values for these settings from the
registry directly. Therefore we cannot just break compatibility here.

Best regards,

Colin