Re: [ros-dev] [ros-diffs] [jimtabor] 66464: [User32_WINETEST] - Move test_SetFocus first as it is done originally. Refer to read past wine CVS logs for the reason.

[Thomas Faber]

I don't care about the reason.
Tests that fail on Windows are broken, period. In this order the tests
fail on Windows.

On 2015-02-26 09:38, jimtabor(a)svn.reactos.org wrote:
>   Author: jimtabor
>  Date: Thu Feb 26 08:38:00 2015
>  New Revision: 66464
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=66464&view=rev
>  Log:
>  [User32_WINETEST]
>  - Move test_SetFocus first as it is done originally. Refer to read past wine CVS logs for
> the reason.
>  
>  Modified:
>      trunk/rostests/winetests/user32/msg.c
>  
>  Modified: trunk/rostests/winetests/user32/msg.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/user32/msg.c?re…
>  ==============================================================================
>  --- trunk/rostests/winetests/user32/msg.c	[iso-8859-1] (original)
>  +++ trunk/rostests/winetests/user32/msg.c	[iso-8859-1] Thu Feb 26 08:38:00 2015
>  @@ -14717,8 +14717,8 @@
>   START_TEST(msg_focus)
>   {
>       init_tests();
>  +    test_SetFocus();
>       test_SetActiveWindow();
>  -    test_SetFocus();
>   
>       /* HACK: For some reason test_SetForegroundWindow fails on Windows unless
>        * we do this */

[James Tabor]

Strange,,,, I've been testing edited tests for months on XP and haven't had
any crashes or test failures. Our test numbers are starting to match too.
I'll info dig around wine tonight and see what they have.

Thank you,
James

On Thu, Feb 26, 2015 at 3:12 AM, Thomas Faber <thomas.faber(a)reactos.org>
wrote:

>   I don't care about the reason.
>  Tests that fail on Windows are broken, period. In this order the tests
>  fail on Windows.
>
>  On 2015-02-26 09:38, jimtabor(a)svn.reactos.org wrote:
> >   Author: jimtabor
> >  Date: Thu Feb 26 08:38:00 2015
> >  New Revision: 66464
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=66464&view=rev
> >  Log:
> >  [User32_WINETEST]
> >  - Move test_SetFocus first as it is done originally. Refer to read past 
>  wine CVS
> logs for the reason.
> >  
> >  Modified:
> >      trunk/rostests/winetests/user32/msg.c
> >
> >  Modified: trunk/rostests/winetests/user32/msg.c
> >  URL: 
> http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/user32/msg.c?re…
> >   
> ==============================================================================
> >   --- trunk/rostests/winetests/user32/msg.c    
> > [iso-8859-1] (original)
> >  +++ trunk/rostests/winetests/user32/msg.c     [iso-8859-1] Thu Feb 26 
>  08:38:00
> 2015
>  > @@ -14717,8 +14717,8 @@
>  >  START_TEST(msg_focus)
>  >  {
>  >      init_tests();
>  > +    test_SetFocus();
>  >      test_SetActiveWindow();
>  > -    test_SetFocus();
> >   
>  >      /* HACK: For some reason
> test_SetForegroundWindow fails on Windows
>  unless
> >         * we do this */ 
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Thomas Faber]

Hmm. The failures in msg_focus reproduce consistently for me if I
remove the keybd_event hack stuff, on both 2003 and 7. I haven't tried
in XP, though. I think Giannis didn't see any failures in Win8.1.
Maybe there's some difference in configuration involved too, would be
interesting what results other people get on 2003 and/or XP.


On 2015-02-26 12:39, James Tabor wrote:
>   Strange,,,, I've been testing edited tests for
> months on XP and haven't had
>  any crashes or test failures. Our test numbers are starting to match too.
>  I'll info dig around wine tonight and see what they have.
>  
>  Thank you,
>  James
>  
>  On Thu, Feb 26, 2015 at 3:12 AM, Thomas Faber <thomas.faber(a)reactos.org>
>  wrote:
>  
> > I don't care about the reason.
> > Tests that fail on Windows are broken, period. In this order the tests
> > fail on Windows.
> >
> > On 2015-02-26 09:38, jimtabor(a)svn.reactos.org wrote:
> >> Author: jimtabor
> >> Date: Thu Feb 26 08:38:00 2015
> >> New Revision: 66464
> >>
> >> URL: http://svn.reactos.org/svn/reactos?rev=66464&view=rev
> >> Log:
> >> [User32_WINETEST]
> >> - Move test_SetFocus first as it is done originally. Refer to read past
> > wine CVS logs for the reason.
> >>
> >> Modified:
> >>     trunk/rostests/winetests/user32/msg.c
> >>
> >> Modified: trunk/rostests/winetests/user32/msg.c
> >> URL:
> >
> http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/user32/msg.c?re…
> >>
> > ==============================================================================
> >> --- trunk/rostests/winetests/user32/msg.c     [iso-8859-1] (original)
> >> +++ trunk/rostests/winetests/user32/msg.c     [iso-8859-1] Thu Feb 26
> > 08:38:00 2015
> >> @@ -14717,8 +14717,8 @@
> >>  START_TEST(msg_focus)
> >>  {
> >>      init_tests();
> >> +    test_SetFocus();
> >>      test_SetActiveWindow();
> >> -    test_SetFocus();
> >>
> >>      /* HACK: For some reason test_SetForegroundWindow fails on Windows
> > unless
> >>       * we do this */