Problems with patchbot/newcc/rosbe

After a quick look into your problems with patchbot it seems that vbox scripts were
missing some errorlevel checks, which should bail out the test run at prepare stage when
ISO was not present (which is the situation when you dont pass the proper revision/id
number. Same thing was with newcc1 tests. I added some debug prints so if my current
solution wont do its job, i`ll at least know bit more about the problem.

By that occasion i found out a problem with current ROSBE - its not emitting proper
ERRORLEVEL at the end of the build, due to tee/buildtime/flash/sound playback or any of
similar crap that is getting the final ERRORLEVEL value. For main building step i hacked
around this issue by simply checking for ISO file at the end and erroring out if its not
there. For host building part, this is more complicated. I tried removing the stuff
mentioned above, but it still doesnt work. Dreimer: it would be of help if you could fix
this problem.

-- 
With best regards
Caemyr

[Zachary Gorden]

Would also be nice if we could turn off the whole sound alert thing.
Some of us find it a bit irritating.

On Mon, Mar 5, 2012 at 6:11 PM,  <caemyr(a)myopera.com> wrote:
>   After a quick look into your problems with patchbot it
> seems that vbox scripts were missing some errorlevel checks, which should bail out the
> test run at prepare stage when ISO was not present (which is the situation when you dont
> pass the proper revision/id number. Same thing was with newcc1 tests. I added some debug
> prints so if my current solution wont do its job, i`ll at least know bit more about the
> problem.
>
>  By that occasion i found out a problem with current ROSBE - its not emitting proper
> ERRORLEVEL at the end of the build, due to tee/buildtime/flash/sound playback or any of
> similar crap that is getting the final ERRORLEVEL value. For main building step i hacked
> around this issue by simply checking for ISO file at the end and erroring out if its not
> there. For host building part, this is more complicated. I tried removing the stuff
> mentioned above, but it still doesnt work. Dreimer: it would be of help if you could fix
> this problem.
>
>  --
>  With best regards
>  Caemyr
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Timo Kreuzer]

Am 06.03.2012 01:20, schrieb Zachary Gorden:
>   Would also be nice if we could turn off the whole
> sound alert thing.
>  Some of us find it a bit irritating. 
Some of us also find it a bit useful.

[Timo Kreuzer]

Am 06.03.2012 01:11, schrieb caemyr(a)myopera.com:
>   After a quick look into your problems with patchbot it
> seems that vbox scripts were missing some errorlevel checks, which should bail out the
> test run at prepare stage when ISO was not present (which is the situation when you dont
> pass the proper revision/id number. Same thing was with newcc1 tests. I added some debug
> prints so if my current solution wont do its job, i`ll at least know bit more about the
> problem.
>
>  By that occasion i found out a problem with current ROSBE - its not emitting proper
> ERRORLEVEL at the end of the build, due to tee/buildtime/flash/sound playback or any of
> similar crap that is getting the final ERRORLEVEL value. For main building step i hacked
> around this issue by simply checking for ISO file at the end and erroring out if its not
> there. For host building part, this is more complicated. I tried removing the stuff
> mentioned above, but it still doesnt work. Dreimer: it would be of help if you could fix
> this problem.
>  
Why don't you use mingw32-make instead of make?

[Daniel Reimer]

I think our mingw32-make is the problem. Even if you ONLY use 
mingw32-make it does not return what it should...


Am 06.03.2012 10:08, schrieb Timo Kreuzer:
>   Am 06.03.2012 01:11, schrieb caemyr(a)myopera.com:
> >   After a quick look into your problems with
> > patchbot it seems that 
> >  vbox scripts were missing some errorlevel checks, which should bail 
> >  out the test run at prepare stage when ISO was not present (which is 
> >  the situation when you dont pass the proper revision/id number. Same 
> >  thing was with newcc1 tests. I added some debug prints so if my 
> >  current solution wont do its job, i`ll at least know bit more about 
> >  the problem.
> >
> >  By that occasion i found out a problem with current ROSBE - its not 
> >  emitting proper ERRORLEVEL at the end of the build, due to 
> >  tee/buildtime/flash/sound playback or any of similar crap that is 
> >  getting the final ERRORLEVEL value. For main building step i hacked 
> >  around this issue by simply checking for ISO file at the end and 
> >  erroring out if its not there. For host building part, this is more 
> >  complicated. I tried removing the stuff mentioned above, but it still 
> >  doesnt work. Dreimer: it would be of help if you could fix this problem.
> >  
>  Why don't you use mingw32-make instead of make?
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

Could someone doublecheck that? My builder is using a custom PGO build of mingw32-make. It
is vital to be sure if this issue is local or general.

On Tue, Mar 6, 2012, at 10:20 PM, Daniel Reimer wrote:
>   I think our mingw32-make is the problem. Even if you
> ONLY use 
>  mingw32-make it does not return what it should...
>  
>   
-- 
With best regards
Caemyr