Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

[Alex Ionescu]

This changes documented/external behavior. What is the point of this change?
Best regards,
Alex Ionescu

On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie
[e-mail] wrote:
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6ece4e9fc22d664ea2485d...
>
> commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f
> Author:     Serge Gautherie [e-mail]
> AuthorDate: Wed Feb 7 06:29:02 2018 +0100
> Commit:     Pierre Schweitzer [e-mail]
> CommitDate: Wed Feb 7 22:22:28 2018 +0100
> [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
>
> ntoskrnl/ke/bug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c
> index a92acb1bab..2127d7207c 100644
> --- a/ntoskrnl/ke/bug.c
> +++ b/ntoskrnl/ke/bug.c
> @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode,
>      if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled))
>      {
>          /* Crash on the debugger console */
>    DbgPrint("\n*** Fatal System Error: 0x%08lx\n"
>             "                       (0x%p,0x%p,0x%p,0x%p)\n\n",
>    DbgPrint("\n*** BugCheck: 0x%08lx\n"
>             "             (0x%p,0x%p,0x%p,0x%p)\n\n",
>             KiBugCheckData[0],
>             KiBugCheckData[1],
>             KiBugCheckData[2],

[Pierre Schweitzer]

Hey Alex,

The root cause of this is:
https://jira.reactos.org/browse/CORE-14293?focusedCommentId=101589&page=...

Cheers,
Pierre

Le 08/02/2018 à 01:55, Alex Ionescu a écrit :
> This changes documented/external behavior. What is the point of this change?
> Best regards,
> Alex Ionescu
>
> On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie
> [e-mail] wrote:
> > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6ece4e9fc22d664ea2485d...
> >
> > commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f
> > Author:     Serge Gautherie [e-mail]
> > AuthorDate: Wed Feb 7 06:29:02 2018 +0100
> > Commit:     Pierre Schweitzer [e-mail]
> > CommitDate: Wed Feb 7 22:22:28 2018 +0100
> > [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
> >
> > ntoskrnl/ke/bug.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c
> > index a92acb1bab..2127d7207c 100644
> > --- a/ntoskrnl/ke/bug.c
> > +++ b/ntoskrnl/ke/bug.c
> > @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode,
> >      if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled))
> >      {
> >          /* Crash on the debugger console */
> >    DbgPrint("\n*** Fatal System Error: 0x%08lx\n"
> >             "                       (0x%p,0x%p,0x%p,0x%p)\n\n",
> >    DbgPrint("\n*** BugCheck: 0x%08lx\n"
> >             "             (0x%p,0x%p,0x%p,0x%p)\n\n",
> >             KiBugCheckData[0],
> >             KiBugCheckData[1],
> >             KiBugCheckData[2],
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

[Thomas Faber]

On 2018-02-08 01:55, Alex Ionescu wrote:
> This changes documented/external behavior. What is the point of this change?

Hmm. Before approving the change I googled/tested whether Windows
produces that output but somehow didn't see it. Now that you mention it,
all versions of Windows do seem to have that exact print, so I agree we
should revert this to avoid breaking tools that scan the debug output.

[Pierre Schweitzer]

Done with e26e4445b39d7455e83e45ac7272d21289cc5106.

Le 08/02/2018 à 11:29, Thomas Faber a écrit :
> On 2018-02-08 01:55, Alex Ionescu wrote:
> > This changes documented/external behavior. What is the point of this
> > change?
>
> Hmm. Before approving the change I googled/tested whether Windows
> produces that output but somehow didn't see it. Now that you mention it,
> all versions of Windows do seem to have that exact print, so I agree we
> should revert this to avoid breaking tools that scan the debug output.
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

[M. Ziggyesque]

My 2 cents,

I'd think it better specfies the hex values are BugCheck codes, not another error number set's values. That it's being output to the debug console is indication enough to most it's a System Error. :-) I'd keep "Fatal " before it to keep the emphasis it isn't considered recoverable, however.

------ Original message------
From: Alex Ionescu
Date: Wed, Feb 7, 2018 7:57 PM
To: ReactOS Development List;Serge Gautherie;
Cc: Linda Wang;
Subject:Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal SystemError" with "BugCheck"

This changes documented/external behavior. What is the point of this change?
Best regards,
Alex Ionescu

On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie
[e-mail] wrote:
> https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.reacto...
>
> commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f
> Author:     Serge Gautherie [e-mail]
> AuthorDate: Wed Feb 7 06:29:02 2018 +0100
> Commit:     Pierre Schweitzer [e-mail]
> CommitDate: Wed Feb 7 22:22:28 2018 +0100
> [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
>
> ntoskrnl/ke/bug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c
> index a92acb1bab..2127d7207c 100644
> --- a/ntoskrnl/ke/bug.c
> +++ b/ntoskrnl/ke/bug.c
> @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode,
>      if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled))
>      {
>          /* Crash on the debugger console */
>    DbgPrint("\n*** Fatal System Error: 0x%08lx\n"
>             "                       (0x%p,0x%p,0x%p,0x%p)\n\n",
>    DbgPrint("\n*** BugCheck: 0x%08lx\n"
>             "             (0x%p,0x%p,0x%p,0x%p)\n\n",
>             KiBugCheckData[0],
>             KiBugCheckData[1],
>             KiBugCheckData[2],

_______________________________________________
Ros-dev mailing list
[e-mail]
https://nam02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.reactos...