Re: [ros-dev] [ros-diffs] [cfinck] 28423: - Always include "wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the first included he

[Steven Edwards]

On 8/19/07, cfinck(a)svn.reactos.org <cfinck(a)svn.reactos.org> wrote:
>   - Always include "wine/unicode.h" before all
> other headers, when we need the wchar_t type. 
Please stop changing the header order. If you need to do this then
something is wrong. The Wine headers are mostly correct as far as the
PSDK/WDK goes and if you build Wine on MSVC you DO NOT have to make
these invasive changes to the source even when using the SDK headers.
Fix the ROS headers or work around system limitations some other way.

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Colin Finck]

Hi Steven,

These changes were made to properly compile ReactOS under a Mac OS X host.
They have nothing to do with MSVC or the Microsoft SDK headers.

Mac OS X defines its own wchar_t type in "ctype.h". But it uses _WCHAR_T for
reporting that the type has been defined and not _WCHAR_T_DEFINED like
Windows does.
This is why I needed to add a handling for _WCHAR_T in "winnt.h".
But if "ctype.h" is now included before "winnt.h", these changes
don't have
any effect. This is why I changed the header order.

Of course, there might be other "solutions" to this problem (like adding all
possible definitions that wchar_t has been defined into the Makefile), but
this is the simplest one.
And I see no reason not to do this for fixing this problem.

Regards,

Colin


>   -----Original Message-----
>  From: ros-dev-bounces(a)reactos.org 
>  [mailto:[e-mail]] On Behalf Of Steven Edwards
>  Sent: Sunday, August 19, 2007 8:37 PM
>  To: ros-dev(a)reactos.org
>  Cc: ros-diffs(a)reactos.org
>  Subject: Re: [ros-dev] [ros-diffs] [cfinck] 28423: - Always 
>  include"wine/unicode.h" before all other headers,when we need 
>  the wchar_t type. unicode.h includes windef.h,which includes 
>  winnt.h,which has the handling for the wchar_t type. As it's 
>  the firstincluded he
>  
>  On 8/19/07, cfinck(a)svn.reactos.org <cfinck(a)svn.reactos.org> wrote:
> >   - Always include "wine/unicode.h"
> > before all other headers,  
>  when we need the wchar_t type.
>  
>  Please stop changing the header order. If you need to do this then
>  something is wrong. The Wine headers are mostly correct as far as the
>  PSDK/WDK goes and if you build Wine on MSVC you DO NOT have to make
>  these invasive changes to the source even when using the SDK headers.
>  Fix the ROS headers or work around system limitations some other way.
>  
>  -- 
>  Steven Edwards
>  
>  "There is one thing stronger than all the armies in the world, and
>  that is an idea whose time has come." - Victor Hugo
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev