crash after opening multi cmd.exe sessions in win32csr.dll

[Steven Edwards]

If you attempt to spawn one cmd session after another you will run in to this crash after about 14
instances:

(shelllink.c:1738:IShellLinkW_fnResolve) (007afc80)->(hwnd=00000000 flags=0)
Failed to tell csrss about new process. Expect trouble.
(api/handle.c:71) CsrGetObject returning invalid handle
(objects/gdiobj.c:788) Attempted to lock foreign handle: 0x50147, Owner: 0x4 loc
ked: 0x0 Caller: 0x8, stockobj: 0x0
(objects/gdiobj.c:790) -> called from objects/dc.c:1509
(NTDLL:rtl/critical.c:77) RtlEnterCriticalSection: Failed to wait (Status c00000
08)
(KERNEL32:except/except.c:132) Unhandled exception
(KERNEL32:except/except.c:133) Address:
(KERNEL32:except/except.c:136)    5ffb7f8e   C:\ReactOS\system32\win32csr.dll
CS:EIP 1b:5ffb7f8e
DS 23 ES 23 FS 3b GS 23
EAX: 5471e311   EBX: 0011f9f0   ECX: 0011f9f0
EDX: ffffffff   EBP: 016dfdd8   ESI: 016dffbc   ESP: 016dfd70
EDI: 016dff68   EFLAGS: 00000206
(KERNEL32:except/except.c:139) Frames:
(KERNEL32:except/except.c:147)    5ffb8566   C:\ReactOS\system32\win32csr.dll
(KERNEL32:except/except.c:147)    5ffb859e   C:\ReactOS\system32\win32csr.dll
(KERNEL32:except/except.c:147)    5ffb88b8   C:\ReactOS\system32\win32csr.dll
(KERNEL32:except/except.c:147)    5ffb8ea4   C:\ReactOS\system32\win32csr.dll
(KERNEL32:except/except.c:147)    77e7364b   C:\ReactOS\system32\user32.dll
(KERNEL32:except/except.c:147)    77e738a9   C:\ReactOS\system32\user32.dll
(KERNEL32:except/except.c:147)    5ffb9170   C:\ReactOS\system32\win32csr.dll
(KERNEL32:except/except.c:147)    7c825693   C:\ReactOS\system32\kernel32.dll
(ntuser/windc.c:747) [000001d8] GetDC() without ReleaseDC()!

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

[Hartmut Birr]

Steven Edwards schrieb:
> If you attempt to spawn one cmd session after another you will run in to this crash after about 14
> instances:
>
> Failed to tell csrss about new process. Expect trouble.

This message (look above) comes from CreateProcess. CsrReply.Status 
returns STATUS_INSUFFICIENT_RESOURCES. There exist three positions in 
csrss which return directly STATUS_INSUFFICIENT_RESOURCES.

- Hartmut

[Ge van Geldorp]

> From: Hartmut Birr
>
> This message (look above) comes from CreateProcess. CsrReply.Status 
> returns STATUS_INSUFFICIENT_RESOURCES. There exist three positions in 
> csrss which return directly STATUS_INSUFFICIENT_RESOURCES.

The location where it actually fails is in CsrInitConsoleScreenBuffer()
where HeapAlloc() returns NULL. The parameters in the call look fine, I'm
guessing we're running out of private heap space here. The heap is created
in csrss/init.c with a size of 64k, it should be growable but maybe we don't
support that? Anyway, if I increase the heap size there to 640k I can create
far more consoles.

Gé van Geldorp.

[Hartmut Birr]

Ge van Geldorp schrieb:
> > From: Hartmut Birr
> >
> > This message (look above) comes from CreateProcess. CsrReply.Status 
> > returns STATUS_INSUFFICIENT_RESOURCES. There exist three positions in 
> > csrss which return directly STATUS_INSUFFICIENT_RESOURCES.
>
> The location where it actually fails is in CsrInitConsoleScreenBuffer()
> where HeapAlloc() returns NULL. The parameters in the call look fine, I'm
> guessing we're running out of private heap space here. The heap is created
> in csrss/init.c with a size of 64k, it should be growable but maybe we don't
> support that? Anyway, if I increase the heap size there to 640k I can create
> far more consoles.
>
> Gé van Geldorp.
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

Hi,

there exist two definitions for HEAP_GROWABLE. I will fix this in a few 
minutes.

- Hartmut

[Steven Edwards]

Hi,

--- Hartmut Birr [e-mail] wrote:
> Ge van Geldorp schrieb:
> > The location where it actually fails is in CsrInitConsoleScreenBuffer()
> > where HeapAlloc() returns NULL. The parameters in the call look fine, I'm
> > guessing we're running out of private heap space here. The heap is created
> > in csrss/init.c with a size of 64k, it should be growable but maybe we don't
> > support that? Anyway, if I increase the heap size there to 640k I can create
> > far more consoles.
>
> there exist two definitions for HEAP_GROWABLE. I will fix this in a few 
> minutes.

Thanks guys. With the latest changes I am able to open 100+ consoles.

....100+ ought to be enough for everyone <g>

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
Meet the all-new My Yahoo! - Try it today! 
http://my.yahoo.com

[Richard Campbell]

Out of curiousity did you find a limit?  or just get tired of opening up 
new console windows? (or did you write a batch file, LAZY ASS! lol)

Steven Edwards wrote:
> Hi,
>
> --- Hartmut Birr [e-mail] wrote:
> > Ge van Geldorp schrieb:
> > > The location where it actually fails is in CsrInitConsoleScreenBuffer()
> > > where HeapAlloc() returns NULL. The parameters in the call look fine, I'm
> > > guessing we're running out of private heap space here. The heap is created
> > > in csrss/init.c with a size of 64k, it should be growable but maybe we don't
> > > support that? Anyway, if I increase the heap size there to 640k I can create
> > > far more consoles.
> >
> > there exist two definitions for HEAP_GROWABLE. I will fix this in a few 
> > minutes.
>
> Thanks guys. With the latest changes I am able to open 100+ consoles.
>
> ....100+ ought to be enough for everyone <g>
>
> Thanks
> Steven
>
> __________________________________ 
> Do you Yahoo!? 
> Meet the all-new My Yahoo! - Try it today! 
> http://my.yahoo.com
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-dev

[Steven Edwards]

Hi,

--- Richard Campbell [e-mail] wrote:
> Out of curiousity did you find a limit?  or just get tired of opening up 
> new console windows? (or did you write a batch file, LAZY ASS! lol)

Heh. I suppose I should have written a batch file but it took less time for 
me to just keep clicking than to write it and figure out how to make it loop 
and print the count. I lost count around 100 and other than just getting slower
the responce was find. I am going to be doing more tests like this once the GDI 
handle leak is fixed.

It will take us forever to run everything Windows does and in the mean time 
we should make everything we have now work as well as it does on Windows.

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - Get yours free! 
http://my.yahoo.com