Re: [ros-dev] [ros-diffs] [greatlrd] 33764: 1. do not use wine def for reactos 2. this is almost 100% correct list of windows 2003 export list of msvcrt.def and it will make abiword working again for it was missing api wfreopen and allot more api from msvcrt 3

[Steven Edwards]

On Thu, May 29, 2008 at 9:27 PM,  [e-mail] wrote:
> Author: greatlrd
> Date: Thu May 29 20:27:29 2008
> New Revision: 33764
>
> URL: http://svn.reactos.org/svn/reactos?rev=33764&view=rev
> Log:
> do not use wine def for reactos
> this is almost 100% correct list of windows 2003 export list of msvcrt.def and it will make abiword working again for it was missing api wfreopen and allot more api from msvcrt
> this add back api that was remove api they exists in windows 2003 export list
> List was provide from colin f
>
> See issue #3293 for more details.

I'd suggest putting a comment at the top of the def so that in the
future someone won't make this mistake again. Any idea why it works on
Wine with the missing exports but not ReactOS?
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Colin Finck]

Steven Edwards wrote:
> Any idea why it works on Wine with the missing exports but not ReactOS?

GreatLord's comment is wrong. Wine doesn't miss these exports.

Encoded synchronized some msvcrt stuff with Wine and I gave him the list of
msvcrt exports. His patch was later committed by me in r33747.
He edited the .def file according to this list, but it looks like he missed
some exports.

Anyway, the current .def file is still not correct. Many ordinals don't
match the export list.
I plan to fix this later.

Best regards,

Colin