Re: [ros-dev] [ros-diffs] [phater] 73095: [TCPIP] Copy back unicast IP if broadcast is specified for listen. CORE-12152

[Thomas Faber]

On 2016-11-02 12:24, phater(a)svn.reactos.org wrote:
>   +        /* Check if we had an unspecified address */
>  +        if (Connection->AddressFile->Address.Address.IPv4Address !=
> bindaddr.addr)
>  +        {
>  +            /* We did, so we need to copy back the address */
>  +            Connection->AddressFile->Address.Address.IPv4Address = bindaddr.addr;
>  +        } 
Seems like you could shorten this to just the assignment?

[Neo Love]

On 2016-11-03 00.14, Thomas Faber wrote:
>   On 2016-11-02 12:24, phater(a)svn.reactos.org wrote:
> >   +        /* Check if we had an unspecified
> > address */
> >  +        if (Connection->AddressFile->Address.Address.IPv4Address != 
> >  bindaddr.addr)
> >  +        {
> >  +            /* We did, so we need to copy back the address */
> >  + Connection->AddressFile->Address.Address.IPv4Address = bindaddr.addr;
> >  +        }
> >  
>  Seems like you could shorten this to just the assignment?
>  
Yes indeed... He could :)