Re: [ros-dev] [ros-diffs] [dchapyshev] 42005: - Re-implement FreeLibrary (for support LOAD_LIBRARY_AS_DATAFILE) - HeapAlloc -> RtlAllocateHeap, GetProcessHeap -> RtlGetProcessHeap, HeapFree -> RtlFreeHeap, CloseHandle -> NtClose - Remove FIXME in LoadModule

[Aleksey Bragin]

I think that part you removed was right, because that is ntdll's job.
Wine, for historic reasons, have this code in kernel32, which is wrong.

Same applies to the LoadLibrary call.


WBR,
Aleksey Bragin.

On Jul 17, 2009, at 9:15 PM, dchapyshev(a)svn.reactos.org wrote:

>   Author: dchapyshev
>  Date: Fri Jul 17 19:15:17 2009
>  New Revision: 42005
>
>  URL: http://svn.reactos.org/svn/reactos?rev=42005&view=rev
>  Log:
>  - Re-implement FreeLibrary (for support LOAD_LIBRARY_AS_DATAFILE)
>  - HeapAlloc -> RtlAllocateHeap, GetProcessHeap ->  
>  RtlGetProcessHeap, HeapFree -> RtlFreeHeap, CloseHandle -> NtClose
>  - Remove FIXME in LoadModule
>
>  Modified:
>      trunk/reactos/dll/win32/kernel32/misc/ldr.c

[Dmitry Chapyshev]

I think, that you are mistaken. I have very well checked up. Wine, 2k, 2k3  
r2 and vista sp2 have this code in kernel32.


On Sun, 19 Jul 2009 12:02:27 +0400, Aleksey Bragin <aleksey(a)reactos.org>  
wrote:

>   I think that part you removed was right, because that
> is ntdll's job.
>  Wine, for historic reasons, have this code in kernel32, which is wrong.
>
>  Same applies to the LoadLibrary call.
>
>
>  WBR,
>  Aleksey Bragin.
>
>  On Jul 17, 2009, at 9:15 PM, dchapyshev(a)svn.reactos.org wrote:
>
> >   Author: dchapyshev
> >  Date: Fri Jul 17 19:15:17 2009
> >  New Revision: 42005
> >
> >  URL: http://svn.reactos.org/svn/reactos?rev=42005&view=rev
> >  Log:
> >  - Re-implement FreeLibrary (for support LOAD_LIBRARY_AS_DATAFILE)
> >  - HeapAlloc -> RtlAllocateHeap, GetProcessHeap ->
> >  RtlGetProcessHeap, HeapFree -> RtlFreeHeap, CloseHandle -> NtClose
> >  - Remove FIXME in LoadModule
> >
> >  Modified:
> >      trunk/reactos/dll/win32/kernel32/misc/ldr.c 
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 


-- 
WBR,
Dmitry Chapyshev