Re: [ros-dev] [ros-diffs] [reactos] 01/01: [MSI] Allow to pass product key validation check

[Thomas Faber]

This causes a test failure...
https://reactos.org/testman/diff.php?id1=41900790&id2=41904063&type=...

On 2019-03-19 23:06, Stanislav Motylkov wrote:
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8e05f5509c4baa4df9d543...
>
> commit 8e05f5509c4baa4df9d543620d5da9552c18f25f
> Author:     Stanislav Motylkov [e-mail]
> AuthorDate: Mon Mar 18 01:14:46 2019 +0300
> Commit:     Hermès BÉLUSCA - MAÏTO [e-mail]
> CommitDate: Tue Mar 19 23:05:57 2019 +0100
>  [MSI] Allow to pass product key validation check
>
>  CORE-14710 CORE-15864
>
> dll/win32/msi/action.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/dll/win32/msi/action.c b/dll/win32/msi/action.c
> index 3909246869..0eef96a89c 100644
> --- a/dll/win32/msi/action.c
> +++ b/dll/win32/msi/action.c
> @@ -7448,7 +7448,11 @@ UINT msi_validate_product_id( MSIPACKAGE *package )
>       if (key && template)
>       {
>           FIXME( "partial stub: template %s key %s\n", debugstr_w(template), debugstr_w(key) );
> +#ifdef __REACTOS__
>    WARN("Product key validation HACK, see CORE-14710\n");
>
> +#else
>           r = msi_set_property( package->db, szProductID, key, -1 );
> +#endif
>       }
>       msi_free( template );
>       msi_free( key );

[Stas'M]

Yeah that was expected.

Среда, 20 марта 2019, 10:17 +03:00 от "Thomas Faber" [e-mail]:
> This causes a test failure...
> https://reactos.org/testman/diff.php?id1=41900790&id2=41904063&type=...
>
> On 2019-03-19 23:06, Stanislav Motylkov wrote:
> >
>
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8e05f5509c4baa4df9d543...
> > commit 8e05f5509c4baa4df9d543620d5da9552c18f25f
> > Author:     Stanislav Motylkov [e-mail]
> > AuthorDate: Mon Mar 18 01:14:46 2019 +0300
> > Commit:     Hermès BÉLUSCA - MAÏTO [e-mail]
> > CommitDate: Tue Mar 19 23:05:57 2019 +0100
> >  [MSI] Allow to pass product key validation check
> >
> >  CORE-14710 CORE-15864
> >
> > dll/win32/msi/action.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/dll/win32/msi/action.c b/dll/win32/msi/action.c
> > index 3909246869..0eef96a89c 100644
> > --- a/dll/win32/msi/action.c
> > +++ b/dll/win32/msi/action.c
> > @@ -7448,7 +7448,11 @@ UINT msi_validate_product_id( MSIPACKAGE *package )
> >       if (key && template)
> >       {
> >           FIXME( "partial stub: template %s key %s\n", debugstr_w(template),
>
> debugstr_w(key) );
> > +#ifdef __REACTOS__
> >    WARN("Product key validation HACK, see CORE-14710\n");
> >
> > +#else
> >           r = msi_set_property( package->db, szProductID, key, -1 );
> > +#endif
> >       }
> >       msi_free( template );
> >       msi_free( key );
>
> Ros-dev mailing list
> [e-mail]
> http://reactos.org/mailman/listinfo/ros-dev