Re: [ros-dev] [ros-diffs] [hbelusca] 69935: [USER32] MessageBoxIndirect fixes by Carlo Bramini: - Implemented loading of text and caption if they are detected as resource IDs. - Use direct resource string pointers with Load...

[Thomas Faber]

Mixing formatting changes, changes that should and changes that
shouldn't affect behavior, and making indentation inconsistent in the
progress is my favorite.

:\

On 2015-11-19 00:46, [e-mail] wrote:
> Author: hbelusca
> Date: Wed Nov 18 23:46:38 2015
> New Revision: 69935
>
> URL: http://svn.reactos.org/svn/reactos?rev=69935&view=rev
> Log:
> [USER32]
> MessageBoxIndirect fixes by Carlo Bramini:
> Implemented loading of text and caption if they are detected as resource IDs.
> Use direct resource string pointers with LoadStringW and use the returned string length.
> Dramatically improve the implementation of ID and resource string assignments, by using a little look up table. This removes some ugly, difficult to maintain copy-paste code.
> Fix the scaling of logical coordinates by making it aware of rounding, i.e. the size of the controls is now calculated correctly.
>
> CORE-10352 #resolve #comment Thank you for the patch! :D