Re: [ros-svn] [royce] 14018: -Wall -Werror and fix warnings

[James Tabor]

Hi Royce,

[e-mail] wrote:
> -Wall -Werror and fix warnings
>
> Updated files:
> trunk/reactos/tools/widl/Makefile
> trunk/reactos/tools/widl/hash.c
> trunk/reactos/tools/widl/write_msft.c
>
> Ros-svn mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-svn

More crazy Linux port problems, in /reactos/tools/widl,

write_msft.c: In function `ctl2_write_chunk':
write_msft.c:2189: warning: implicit declaration of function `write'
write_msft.c:2190: warning: implicit declaration of function `close'
write_msft.c: In function `save_all_changes':
write_msft.c:2284: warning: implicit declaration of function `creat'
make: *** [write_msft.o] Error 1

It works when removing -Werror -Wall from the Makefile. BTW io.h
is in the /usr/mingw32/include directory.

Thanks,
James

[Royce Mitchell III]

James Tabor wrote:
> More crazy Linux port problems, in /reactos/tools/widl,
>
> write_msft.c: In function `ctl2_write_chunk':
> write_msft.c:2189: warning: implicit declaration of function `write'
> write_msft.c:2190: warning: implicit declaration of function `close'
> write_msft.c: In function `save_all_changes':
> write_msft.c:2284: warning: implicit declaration of function `creat'
> make: *** [write_msft.o] Error 1

Sorry about that James. Would you see if removing the #ifdef around 
<io.h> resolves those warnings?

( I thought io.h was a mostly windows-specific file )

[James Tabor]

Royce Mitchell III wrote:
> James Tabor wrote:
> > More crazy Linux port problems, in /reactos/tools/widl,
> >
> > write_msft.c: In function `ctl2_write_chunk':
> > write_msft.c:2189: warning: implicit declaration of function `write'
> > write_msft.c:2190: warning: implicit declaration of function `close'
> > write_msft.c: In function `save_all_changes':
> > write_msft.c:2284: warning: implicit declaration of function `creat'
> > make: *** [write_msft.o] Error 1
>
> Sorry about that James. Would you see if removing the #ifdef around 
> <io.h> resolves those warnings?
>
> ( I thought io.h was a mostly windows-specific file )

It does not work, I have to include -I/usr/mingw32/include, that returns
a new set of errors from the mingw headers.
8^),
James