Re: [ros-svn] [weiden] 13138: implemented the ProcessSessionInformation information class

[Hartmut Birr]

[e-mail] schrieb:
> implemented the ProcessSessionInformation information class
>
> Updated files:
> trunk/reactos/ntoskrnl/ps/process.c
>
> Ros-svn mailing list
> [e-mail]
> http://reactos.com:8080/mailman/listinfo/ros-svn

Hi,

I think that some parts of your implementation are incorrect. The 
function must check for the location of the buffer and the previous 
mode. If the previous mode is user mode, the buffer must be located 
within the user address space. IMHO using of  MmCopyFrom/ToCaller is 
better than using an exception block. It is also true for your following 
commits.

- Hartmut

[Thomas Weidenmueller]

Hartmut Birr wrote:
> I think that some parts of your implementation are incorrect. The 
> function must check for the location of the buffer and the previous 
> mode. If the previous mode is user mode, the buffer must be located 
> within the user address space. IMHO using of  MmCopyFrom/ToCaller is 
> better than using an exception block. It is also true for your 
> following commits.

Yes, that's true. I've fixed them in the meanwhile doing it how MSDN 
recommends, probing the buffers passed from user mode and then rely on 
SEH. I know that SEH might not look as good as using 
MmCopyFrom/ToCaller, but 3rd party drivers don't have this option as well...

Best Regards
Thomas

[Joseph Galbraith]

Hartmut Birr wrote:
> [e-mail] schrieb:
> > implemented the ProcessSessionInformation information class
> >
> > Updated files:
> > trunk/reactos/ntoskrnl/ps/process.c
>
> I think that some parts of your implementation are incorrect. The 
> function must check for the location of the buffer and the previous 
> mode. If the previous mode is user mode, the buffer must be located 
> within the user address space. IMHO using of  MmCopyFrom/ToCaller is 
> better than using an exception block. It is also true for your following 
> commits.

Do MmCopyFrom/ToCaller use SEH?

If not, both are necessary.  Using SEH protects from another
thread in the process (or some other component) free the VM
page and cause a crash.

So not only must the address be checked to make sure it
is a user mode address iff the caller is user mode, but
the parameter need to be copied using SEH; otherwise
what was just probed as valid may become invalid before
the copy can be done.

Thanks,

Joseph

[Royce Mitchell III]

Joseph Galbraith wrote:
> Hartmut Birr wrote:
> > [e-mail] schrieb:
> > > implemented the ProcessSessionInformation information class
> > >
> > > Updated files:
> > > trunk/reactos/ntoskrnl/ps/process.c
> >
> > I think that some parts of your implementation are incorrect. The 
> > function must check for the location of the buffer and the previous 
> > mode. If the previous mode is user mode, the buffer must be located 
> > within the user address space. IMHO using of  MmCopyFrom/ToCaller is 
> > better than using an exception block. It is also true for your 
> > following commits.
>
> Do MmCopyFrom/ToCaller use SEH?
>
> If not, both are necessary.  Using SEH protects from another
> thread in the process (or some other component) free the VM
> page and cause a crash.
>
> So not only must the address be checked to make sure it
> is a user mode address iff the caller is user mode, but
> the parameter need to be copied using SEH; otherwise
> what was just probed as valid may become invalid before
> the copy can be done.

Yes... and no...

our exception handler has a special-case for MmCopyFrom/MmCopyTo.

The upshot is that those two functions have SEH without explicitly 
needing to setup an SEH frame for it.

[Joseph Galbraith]

> > Do MmCopyFrom/ToCaller use SEH?
> >
> > If not, both are necessary.  Using SEH protects from another
> > thread in the process (or some other component) free the VM
> > page and cause a crash.
> >
> > So not only must the address be checked to make sure it
> > is a user mode address iff the caller is user mode, but
> > the parameter need to be copied using SEH; otherwise
> > what was just probed as valid may become invalid before
> > the copy can be done.
>
> Yes... and no...
>
> our exception handler has a special-case for MmCopyFrom/MmCopyTo.
>
> The upshot is that those two functions have SEH without explicitly 
> needing to setup an SEH frame for it.

Fascinating... that I would have never guessed.

Thanks,

Joseph

[Thomas Larsen]

Please Implent Those Files they sync to newest wine and implent many missing or uncorrect
functions in Reactos

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - You care about security. So do we. 
http://promotions.yahoo.com/new_mail

[Casper Hornstrup]

> -----Original Message-----
> From: [e-mail] 
> [mailto:[e-mail]] On Behalf Of Thomas Larsen
> Sent: 21. januar 2005 10:31
> To: ReactOS Development List
> Subject: [ros-dev] ** PATCH DAY 2005 ** PART I
>
> Please Implent Those Files they sync to newest wine and 
> implent many missing or uncorrect functions in Reactos

You've just wasted 200MB of bandwidth. What are you trying to accomplish?

Casper

[Ge van Geldorp]

Thomas,

You've obviously invested a lot of time and effort in this, but it seems not
in the most efficient way. For starters, I had to get winrar, only to find
that the files inside were packed with another utility. Even with the 7-Zip
I then downloaded a lot of files just refuse to open. The patch files that
do open seem to be "diff" files instead of "diff -u" which would provide
more context.

I see a lot of the components contain the changes between Wine-20050111 and
current Wine CVS HEAD. We normally merge Wine changes after a Wine release,
that keeps the merge process manageable. Merging some arbitrary changes
between Wine releases doesn't make much sense.

Some of the files are new imports from Wine. Unfortunately, we can't just
commit those if we want to be able to keep components in sync in the future.
We need to do SVN "vendor drops", to be able to merge future updates (see
http://mok.lvcm.com/cgi-bin/reactos/roswiki?Using_Code_From_Other_Projects
on what we need to do to import code).

Other stuff doesn't belong in ReactOS alltogether, like the "start" files. I
was unable to open that particular archive, but I assume it would give us
the Win9x start.exe utility, which we don't need, 'cause "start" is a
cmd-builtin in NT OSes. I also have doubts about some of the components we
don't share with Wine (like kernel32), but again I couldn't open those with
7-Zip.

I do appreciate the effort you put into this, and I will try to put some of
the stuff in SVN, but to be honest in its current form there's a lot of
stuff which isn't going to make it.

Ge van Geldorp.

[Steven Edwards]

Hello Thomas,

--- Ge van Geldorp [e-mail] wrote:
> I do appreciate the effort you put into this, and I will try to put some of
> the stuff in SVN, but to be honest in its current form there's a lot of
> stuff which isn't going to make it.

As GvG said we do appreciate the effort. To make things less work on everyone please send patches
to [e-mail] following the winehq rules for patch submission. If its a patch that
will affect ReactOS only then you can send it here for review. Committing patches directy to the
ReactOS tree that are shared from other projects is generally discouraged. We make exception for
minor patches and for developers that have limited internet access.

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

[Thomas Larsen]

Please Implent Those Files they sync to newest wine and implent many missing or uncorrect
functions in Reactos

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - What will yours do?
http://my.yahoo.com

[Thomas Larsen]

Please Implent Those Files they sync to newest wine and implent many missing or uncorrect
functions in Reactos

__________________________________ 
Do you Yahoo!? 
All your favorites on one personal page � Try My Yahoo!
http://my.yahoo.com

[Alex Ionescu]

Thomas Larsen wrote:
> Please Implent Those Files they sync to newest wine and implent many missing or uncorrect
> functions in Reactos

Hi,

These files are

1) Extremly hard to get to, since they involve multiple levels of 
decompression with different utiltiles.

If you want us to even *look* at them, please post them as pure 
.patch files in a zip file.

2) Lacking any sort of changelog

We will not merge or look at any patch that does not have a 
changelog. You need to explain what and why you are doing.

3) Mostly re-formatting changes, or code style changes.

Such patches are not accepted. Please make you new .patch files only 
include bug fixes or improvements. Changing something like

if  (foo == bar)
    {
       ...;
    }

to if (foo ==bar) ....;

is not an acceptable patch.

None of us will pay any attention to this patch unless the above 
criteria are met. Single .patch files in a normal .zip file; Changelog 
for each patch file, explaning in detail *what the change does *and *why 
it's necessary* (if not obvious); Removal of any useless re-formatting 
changes.

Best regards,
Alex Ionescu

[Thomas Larsen]

Okay Doing That

I did ask 3 times how any would like to receive the patches 3 month 2 month 1 month ago
Nobody answer so I found this program on your outdated web page "Win Merge" to make the patches...

The files include in a rar are not compressed and can be opened by one util. Seven Zip I
compressed it in Winrar because of the limit on bandwidth "Mail Server" only 200 kb allowed and
split the files in 4 stage without compress... sry for that.

And

shfolder.dll are a new dll file and many more are not included in reactor also hhctrl.ocx makes
WinZip version 1.0-9.0b works "WinZip Seeks an help file" and can�t start up without this file so

MSISYS.OCX Make Some parts of office 2000 Works and some other ocx files witch makes internet
explorer 5 run but not receive WebPages but its an start..

The patches in ntdll.dll correct some bugs/mistakes and implant some new functions will return
with more detail

And comdlg32 and comctl32 I implanted missing and wrong implantations and let it work so you could
test those in a winxp env.

comdlg32 comctl32 shfolder.dll makes dependsx86 works and you can also open a run debug output

Most of the other files are new implantations of functions

In advapi32.dll
;iamallreadyimplentet where all ready implanted look at it yourself many weird things going on in
the def file
And implanted and corrected the reg.c file so you could use your regedit app properly..

and i sync every dll with the most recent cvs of wine

Code Style

if   (bob)  
  {
 bobobob( kffk) ;
}

my point different code styles every where in reactos I just tabbed and made it more easy to
understand

if (bob) {
  bobobob(kffk);
}

But okay am a little tired of some blaming all and nothing

Won�t help you
Read about that and I may help you
Look on the web page you moron
You spell the word wrong can�t understand you like an irritating France Man would say.
You used 2000 Mb of... are you all on telephone lines or what..
Think it really would help if you treat ppl. Better�

I got an idea:

Split the work provide documentation on your web page comment your code put your best information
link up on kernel code and so on instead of cutting ppls head over all information do not stand I
books and many great coders get their information and ideas from ppl, own expertise share it.. it
will make ppl better.. And Reactos could really use it..

Don�t want a lot of negative mail but comment and so on are welcome the negative I just empty..

But nice job you all and great Sunday..

Thomas

__________________________________ 
Do you Yahoo!? 
Take Yahoo! Mail with you! Get it on your mobile phone. 
http://mobile.yahoo.com/maildemo

[Alex Ionescu]

Thomas Larsen wrote:
> Okay Doing That
>
> I did ask 3 times how any would like to receive the patches 3 month 2 month 1 month ago
> Nobody answer so I found this program on your outdated web page "Win Merge" to make the patches...
>
> The files include in a rar are not compressed and can be opened by one util. Seven Zip I
> compressed it in Winrar because of the limit on bandwidth "Mail Server" only 200 kb allowed and
> split the files in 4 stage without compress... sry for that.

Rar is a compression algorithm, so is 7zip. Both are uncommon... please 
just post a single zip on a website if you can...or split it, it's still 
fine. But a zip file please. With the .patches directly inside.
> And
>
> shfolder.dll are a new dll file and many more are not included in reactor also hhctrl.ocx makes
> WinZip version 1.0-9.0b works "WinZip Seeks an help file" and can’t start up without this file so

So you've written shfolder.dll? Or synced from WINE? We do syncs from 
WINE ourselves using "Vendor drops" when we need a DLL, so that we can 
share code.
> MSISYS.OCX Make Some parts of office 2000 Works and some other ocx files witch makes internet
> explorer 5 run but not receive WebPages but its an start..

Are these OCX files coded by you, or from WINE?
> The patches in ntdll.dll correct some bugs/mistakes and implant some new functions will return
> with more detail

Please make sure that you document each bug/mistake...it makes it easier 
for us.
> And comdlg32 and comctl32 I implanted missing and wrong implantations and let it work so you could
> test those in a winxp env.

See above.
> comdlg32 comctl32 shfolder.dll makes dependsx86 works and you can also open a run debug output

See above.
> Most of the other files are new implantations of functions

See above.
> In advapi32.dll
> ;iamallreadyimplentet where all ready implanted look at it yourself many weird things going on in
> the def file
> And implanted and corrected the reg.c file so you could use your regedit app properly..

See above.
> and i sync every dll with the most recent cvs of wine

We usually do this ourselves with vendor drops, so it's not really 
necessary in a patch.
> Code Style
>
> if   (bob)  
>  {
> bobobob( kffk) ;
> }
>
> my point different code styles every where in reactos I just tabbed and made it more easy to
> understand
>
> if (bob) {
>  bobobob(kffk);
> }

I understand, but it makes the patches almost impossible to read.
> But okay am a little tired of some blaming all and nothing
>
> Won’t help you
> Read about that and I may help you
> Look on the web page you moron
> You spell the word wrong can’t understand you like an irritating France Man would say.
> You used 2000 Mb of... are you all on telephone lines or what..
> Think it really would help if you treat ppl. Better…
>
> I got an idea:
>
> Split the work provide documentation on your web page comment your code put your best information
> link up on kernel code and so on instead of cutting ppls head over all information do not stand I
> books and many great coders get their information and ideas from ppl, own expertise share it.. it
> will make ppl better.. And Reactos could really use it..
>
> Don’t want a lot of negative mail but comment and so on are welcome the negative I just empty..
>
> But nice job you all and great Sunday..
>
> Thomas

I agree with you that our documentation is a bit lacking, and I thank 
you for the work you've done. Many people get discourage when they 
submit their first patch, but making mistakes is the way to learning... 
I will eagearly awaiting your new patch files, with explenations for the 
bugs they fix.

Best regards,
Alex Ionescu

[Jakob Eriksson]

You rock. :-)

Some were rude but you are patient and stay anyway.

regards,
Jakob

[Thomas Larsen]

Please Implent Those Files they sync to newest wine and implent many missing or uncorrect
functions in Reactos

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - Easier than ever with enhanced search. Learn more.
http://info.mail.yahoo.com/mail_250

[Thomas Larsen]

Please Implent Those Files they sync to newest wine and implent many missing or uncorrect
functions in Reactos

Last One...

Thomas Larsen Lila Corp.

__________________________________ 
Do you Yahoo!? 
The all-new My Yahoo! - Get yours free! 
http://my.yahoo.com