Re: [ros-dev] [ros-diffs] [cgutman] 40142: - Reorganize NDIS code

[Aleksey Bragin]

What was wrong with a previous naming convention?

x0gone.c were supposed to contain implementation of functions, which  
became legacy in that major version of NDIS. Now you substituted it  
with x0stubs.c, which means it's going to contain stubs only. Was  
that intentionally?

On Mar 21, 2009, at 12:29 AM, [e-mail] wrote:
> Author: cgutman
> Date: Sat Mar 21 00:29:53 2009
> New Revision: 40142
>
> URL: http://svn.reactos.org/svn/reactos?rev=40142&view=rev
> Log:
> Reorganize NDIS code
>
> Added:
>     trunk/reactos/drivers/network/ndis/ndis/30stubs.c
>       - copied, changed from r40140, trunk/reactos/drivers/network/ 
> ndis/ndis/40gone.c
>     trunk/reactos/drivers/network/ndis/ndis/40stubs.c
>       - copied, changed from r40141, trunk/reactos/drivers/network/ 
> ndis/ndis/50gone.c
>     trunk/reactos/drivers/network/ndis/ndis/50stubs.c
>       - copied, changed from r40113, trunk/reactos/drivers/network/ 
> ndis/ndis/stubs.c
>     trunk/reactos/drivers/network/ndis/ndis/misc.c   (with props)
> Removed:
>     trunk/reactos/drivers/network/ndis/ndis/40gone.c
>     trunk/reactos/drivers/network/ndis/ndis/50gone.c
>     trunk/reactos/drivers/network/ndis/ndis/stubs.c

[Cameron Gutman]

This makes it easier to figure out what is left to be implemented. It also
makes it easier to find implemented legacy functions because I can just look
where a non-legacy function would be located instead of having to look
through 40gone.c and 50gone.c.

[Sent from ROS r40165 :)]

On Sat, Mar 21, 2009 at 10:17 AM, Aleksey Bragin [e-mail]:
> What was wrong with a previous naming convention?
>
> x0gone.c were supposed to contain implementation of functions, which
> became legacy in that major version of NDIS. Now you substituted it
> with x0stubs.c, which means it's going to contain stubs only. Was
> that intentionally?
>
> On Mar 21, 2009, at 12:29 AM, [e-mail] wrote:
> > Author: cgutman
> > Date: Sat Mar 21 00:29:53 2009
> > New Revision: 40142
> >
> > URL: http://svn.reactos.org/svn/reactos?rev=40142&view=rev
> > Log:
> > Reorganize NDIS code
> >
> > Added:
> >     trunk/reactos/drivers/network/ndis/ndis/30stubs.c
> >       - copied, changed from r40140, trunk/reactos/drivers/network/
> > ndis/ndis/40gone.c
> >     trunk/reactos/drivers/network/ndis/ndis/40stubs.c
> >       - copied, changed from r40141, trunk/reactos/drivers/network/
> > ndis/ndis/50gone.c
> >     trunk/reactos/drivers/network/ndis/ndis/50stubs.c
> >       - copied, changed from r40113, trunk/reactos/drivers/network/
> > ndis/ndis/stubs.c
> >     trunk/reactos/drivers/network/ndis/ndis/misc.c   (with props)
> > Removed:
> >     trunk/reactos/drivers/network/ndis/ndis/40gone.c
> >     trunk/reactos/drivers/network/ndis/ndis/50gone.c
> >     trunk/reactos/drivers/network/ndis/ndis/stubs.c
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev