Regarding 48632

[Ros Arm]

Hello,

Many thanks for fixing this idiotic oversight of mine. I apologies for the long hours of
debugging I must have caused.

This fix is somewhat incomplete/at the wrong place; could this be marked as such in the
code, perhaps with a FIXME under my name, so that I may fix this correctly upon my return
to the US?

Much obliged!

-r

Author: mjmartin
Date: Sat Aug 28 00:26:02 2010
New Revision: 48632

URL: http://svn.reactos.org/svn/reactos?rev=48632&view=rev
Log:
[ntoskrnl/ps]
- When deleting a Process remove the Process from the MmProcessList. Fixes random NonPaged
Pool corruptions.  Thanks aicom for assistance.

Modified:
   trunk/reactos/ntoskrnl/ps/kill.c

Modified: trunk/reactos/ntoskrnl/ps/kill.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=486…
==============================================================================
--- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Sat Aug 28 00:26:02 2010
@@ -300,6 +300,8 @@

        /* Detach */
        KeUnstackDetachProcess(&ApcState);
+
+        RemoveEntryList(&Process->MmProcessLinks);

        /* Completely delete the Address Space */
        MmDeleteProcessAddressSpace(Process);

[Michael Martin]

No problem mate, it happens.



Was not 100% positive on the placement. Ill add a comment a bit later there to remind
you.



mjmartin



>   From: ros.arm(a)reactos.org
>  To: ros-dev(a)reactos.org
>  Date: Sat, 28 Aug 2010 04:55:06 +0200
>  Subject: [ros-dev] Regarding 48632
>  
>  Hello,
>  
>  Many thanks for fixing this idiotic oversight of mine. I apologies for the long hours of
> debugging I must have caused.
>  
>  This fix is somewhat incomplete/at the wrong place; could this be marked as such in the
> code, perhaps with a FIXME under my name, so that I may fix this correctly upon my return
> to the US?
>  
>  Much obliged!
>  
>  -r
>  
>  Author: mjmartin
>  Date: Sat Aug 28 00:26:02 2010
>  New Revision: 48632
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=48632&view=rev
>  Log:
>  [ntoskrnl/ps]
>  - When deleting a Process remove the Process from the MmProcessList. Fixes random
> NonPaged Pool corruptions.  Thanks aicom for assistance.
>  
>  Modified:
>     trunk/reactos/ntoskrnl/ps/kill.c
>  
>  Modified: trunk/reactos/ntoskrnl/ps/kill.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=486…
>  ==============================================================================
>  --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original)
>  +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Sat Aug 28 00:26:02 2010
>  @@ -300,6 +300,8 @@
>  
>          /* Detach */
>          KeUnstackDetachProcess(&ApcState);
>  +
>  +        RemoveEntryList(&Process->MmProcessLinks);
>  
>          /* Completely delete the Address Space */
>          MmDeleteProcessAddressSpace(Process);
>  
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev