Re: [ros-dev] [ros-diffs] [ion] 52806: [KERNEL32]: Implement BaseFiberStartup in ASM, just like the thread/process thunks, so we get a "naked" thunk without any compiler-generated crap.

[Timo Kreuzer]

Am 23.07.2011 14:05, schrieb ion(a)svn.reactos.org:
>   Author: ion
>  Date: Sat Jul 23 12:05:38 2011
>  New Revision: 52806
>
>  URL: http://svn.reactos.org/svn/reactos?rev=52806&view=rev
>  Log:
>  [KERNEL32]: Implement BaseFiberStartup in ASM, just like the thread/process thunks, so we
> get a "naked" thunk without any compiler-generated crap. 
I don't see
the point in this change.
That "crap" is setting up a stack frame, which is pretty useful for 
debugging. It consists of 3 instructions:

push ebp
mov ebp, esp
sub esp, 8

Your change also broke compilation with MSVC (the END directive is only 
at the end of the file!) and deleted the function for amd64.
The function is not performance critical and the asm code doesn't really 
add any performace gain anyway.
So why are we going back?

I'm asking, because I've been working on converting more asm code to C 
code and IMO thats the way to go.

Regards,
Timo