Re: [ros-dev] [ros-diffs] [sginsberg] 36005: - Make sure we get a Subkey in RegDeleteKeyA/W. Fixes Winetests causing a system crash, but (for now) hides a bug in CM.

[Steven Edwards]

On Sat, Sep 6, 2008 at 5:02 PM,  <sginsberg(a)svn.reactos.org> wrote:
>   - Make sure we get a Subkey in RegDeleteKeyA/W. Fixes
> Winetests causing a system crash, but (for now) hides a bug in CM. 
Maybe we should throw a DPRINT1 here so we are reminded that the bug
is still there.

-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo

[Aleksey Bragin]

I said I will fix it properly after I finish other CM work, why is  
there a hurry to commit a hack?

WBR,
Aleksey.

On Sep 7, 2008, at 5:38 AM, Steven Edwards wrote:

>   On Sat, Sep 6, 2008 at 5:02 PM, 
> <sginsberg(a)svn.reactos.org> wrote:
> >   - Make sure we get a Subkey in RegDeleteKeyA/W.
> > Fixes Winetests  
> >  causing a system crash, but (for now) hides a bug in CM. 
>  Maybe we should throw a DPRINT1 here so we are reminded that the bug
>  is still there.
>
>  -- 
>  Steven Edwards

[Stefan Ginsberg]

Hello.

The check is not a hack. Windows performs the same check, but only since XP according to
Winetests. Winetests have a workaround for earlier systems, and this workaround caused ros
to crash. The crash is still hit by later registry tests however, so the bug isn't
hidden.
Anyway, I should have clarified this in the commit message. My fault.

>   From: aleksey(a)reactos.org
>  Date: Sun, 7 Sep 2008 11:43:01 +0400
>  To: ros-dev(a)reactos.org
>  Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 36005: - Make sure we get a	Subkey in
> RegDeleteKeyA/W. Fixes Winetests causing a system	crash, but (for now) hides a bug in CM.
>  
>  I said I will fix it properly after I finish other CM work, why is  
>  there a hurry to commit a hack?
>  
>  WBR,
>  Aleksey.
>  
>  On Sep 7, 2008, at 5:38 AM, Steven Edwards wrote:
>  
> >   On Sat, Sep 6, 2008 at 5:02 PM, 
> > <sginsberg(a)svn.reactos.org> wrote:
> > >   - Make sure we get a Subkey in RegDeleteKeyA/W.
> > > Fixes Winetests  
> > >  causing a system crash, but (for now) hides a bug in CM. 
> >  Maybe we should throw a DPRINT1 here so we are reminded that the bug
> >  is still there.
> >
> >  -- 
> >  Steven Edwards 
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 
_________________________________________________________________
Explore the seven wonders of the world
http://search.msn.com/results.aspx?q=7+wonders+world&mkt=en-US&form…