Re: [ros-dev] [ros-diffs] [tkreuzer] 62480: [PSDK] winternl.h: Fix RtlLookupAtomInAtomTable prototype (should be sent to wine? not sure)

[Thomas Faber]

This is intentional, their RTL_ATOM_TABLE is already a pointer:

/* Wine doesn't implement atom table as NT does:
 * - in NT, atom tables are user space tables, which ntdll directly accesses
 * - on Wine, (even local) atom tables are wineserver objects, hence a HANDLE
 */
typedef struct atom_table *RTL_ATOM_TABLE, **PRTL_ATOM_TABLE;


So that would need to be changed consistently.

(also, winternl.h should be used by Wine code only, so shouldn't affect
us -- since we have NDK to use instead)


On 2014-03-11 23:48, tkreuzer(a)svn.reactos.org wrote:
>   Author: tkreuzer
>  Date: Tue Mar 11 22:48:04 2014
>  New Revision: 62480
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=62480&view=rev
>  Log:
>  [PSDK]
>  winternl.h: Fix RtlLookupAtomInAtomTable prototype (should be sent to wine? not sure)
>  
>  Modified:
>      trunk/reactos/include/psdk/winternl.h
>  
>  Modified: trunk/reactos/include/psdk/winternl.h
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winternl.h?re…
>  ==============================================================================
>  --- trunk/reactos/include/psdk/winternl.h	[iso-8859-1] (original)
>  +++ trunk/reactos/include/psdk/winternl.h	[iso-8859-1] Tue Mar 11 22:48:04 2014
>  @@ -632,7 +632,7 @@
>       FileFsMaximumInformation
>   } FS_INFORMATION_CLASS, *PFS_INFORMATION_CLASS;
>   
>  -typedef enum _KEY_INFORMATION_CLASS { 
>  +typedef enum _KEY_INFORMATION_CLASS {
>     KeyBasicInformation           = 0,
>     KeyNodeInformation            = 1,
>     KeyFullInformation            = 2,
>  @@ -2244,7 +2244,7 @@
>   DWORD     WINAPI RtlLengthSid(PSID);
>   NTSTATUS  WINAPI RtlLocalTimeToSystemTime(const LARGE_INTEGER*,PLARGE_INTEGER);
>   BOOLEAN   WINAPI RtlLockHeap(HANDLE);
>  -NTSTATUS  WINAPI RtlLookupAtomInAtomTable(RTL_ATOM_TABLE,const WCHAR*,RTL_ATOM*);
>  +NTSTATUS  WINAPI RtlLookupAtomInAtomTable(RTL_ATOM_TABLE*,const WCHAR*,RTL_ATOM*);
>   
>   NTSTATUS  WINAPI
> RtlMakeSelfRelativeSD(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,LPDWORD);
>   void      WINAPI RtlMapGenericMask(PACCESS_MASK,const GENERIC_MAPPING*);
>  
>

[Hermès BÉLUSCA - MAÏTO]

A quick look at:
http://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&a…
1
shows that reactos/base/system/format/format.c includes winternl.h, and
therefore MUST be fixed :D

Hermès.

-----Message d'origine-----
De : ros-dev-bounces(a)reactos.org [mailto:[e-mail]] De la
part de Thomas Faber
Envoyé : jeudi 20 mars 2014 14:24
À : ros-dev(a)reactos.org
Objet : Re: [ros-dev] [ros-diffs] [tkreuzer] 62480: [PSDK] winternl.h: Fix
RtlLookupAtomInAtomTable prototype (should be sent to wine? not sure)

This is intentional, their RTL_ATOM_TABLE is already a pointer:

/* Wine doesn't implement atom table as NT does:
 * - in NT, atom tables are user space tables, which ntdll directly accesses
 * - on Wine, (even local) atom tables are wineserver objects, hence a
HANDLE  */ typedef struct atom_table *RTL_ATOM_TABLE, **PRTL_ATOM_TABLE;


So that would need to be changed consistently.

(also, winternl.h should be used by Wine code only, so shouldn't affect us
-- since we have NDK to use instead)


On 2014-03-11 23:48, tkreuzer(a)svn.reactos.org wrote:
>   Author: tkreuzer
>  Date: Tue Mar 11 22:48:04 2014
>  New Revision: 62480
>  
>  URL: http://svn.reactos.org/svn/reactos?rev=62480&view=rev
>  Log:
>  [PSDK]
>  winternl.h: Fix RtlLookupAtomInAtomTable prototype (should be sent to 
>  wine? not sure)
>  
>  Modified:
>      trunk/reactos/include/psdk/winternl.h
>  
>  Modified: trunk/reactos/include/psdk/winternl.h
>  URL: 
>  http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winternl
>  .h?rev=62480&r1=62479&r2=62480&view=diff
>  
============================================================================
==
>   --- trunk/reactos/include/psdk/winternl.h	[iso-8859-1]
> (original)
>  +++ trunk/reactos/include/psdk/winternl.h	[iso-8859-1] Tue Mar 11 
22:48:04 2014
>   @@ -632,7 +632,7 @@
>       FileFsMaximumInformation
>   } FS_INFORMATION_CLASS, *PFS_INFORMATION_CLASS;
>   
>  -typedef enum _KEY_INFORMATION_CLASS {
>  +typedef enum _KEY_INFORMATION_CLASS {
>     KeyBasicInformation           = 0,
>     KeyNodeInformation            = 1,
>     KeyFullInformation            = 2,
>  @@ -2244,7 +2244,7 @@
>   DWORD     WINAPI RtlLengthSid(PSID);
>   NTSTATUS  WINAPI RtlLocalTimeToSystemTime(const 
LARGE_INTEGER*,PLARGE_INTEGER);
>    BOOLEAN   WINAPI RtlLockHeap(HANDLE);
>  -NTSTATUS  WINAPI RtlLookupAtomInAtomTable(RTL_ATOM_TABLE,const 
>  WCHAR*,RTL_ATOM*);
>  +NTSTATUS  WINAPI RtlLookupAtomInAtomTable(RTL_ATOM_TABLE*,const 
>  +WCHAR*,RTL_ATOM*);
>   
>   NTSTATUS  WINAPI
RtlMakeSelfRelativeSD(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,LPDWORD);
>    void      WINAPI RtlMapGenericMask(PACCESS_MASK,const
> GENERIC_MAPPING*);
>  
>   

_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev