Re: [ros-dev] [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
SP2 was not out when we made the choice.
And before we move to SP2, I'd rather move to Win 7 =)
-- Best regards, Alex Ionescu
-----Original Message----- From: ros-diffs-bounces@reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca@svn.reactos.org Sent: Wednesday, February 12, 2014 2:58 PM To: ros-diffs@reactos.org Subject: [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
Author: hbelusca Date: Wed Feb 12 22:58:13 2014 New Revision: 62142
URL: http://svn.reactos.org/svn/reactos?rev=62142&view=rev Log: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
Modified: trunk/reactos/boot/bootdata/hivesys.inf trunk/reactos/include/psdk/ntverp.h trunk/reactos/ntoskrnl/ex/init.c
Modified: trunk/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?r... ============================================================================== --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1143,8 +1143,8 @@ ; ReactOS specific - by default we report ourselves as Server for the user, ; but we can also report as Workstation if some application needs it. HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWorkstation",0x00010001,0x00000000 -; Some installers check for SP2 -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000200 +; Some installers check for SP1 +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001 +,0x00000100
HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders",2,"schannel.dll" HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00000012
Modified: trunk/reactos/include/psdk/ntverp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=6... ============================================================================== --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -14,10 +14,10 @@ */
// -// Windows NT Build 3790.3959 +// Windows NT Build 3790.1830 // #define VER_PRODUCTBUILD 3790 -#define VER_PRODUCTBUILD_QFE 3959 +#define VER_PRODUCTBUILD_QFE 1830
// // Windows NT Version 5.2
Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=6214... ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1072,12 +1072,12 @@ /* Setup initial system settings */ CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector);
- /* Load static defaults for Service Pack 2 and add our SVN revision */ + /* Load static defaults for Service Pack 1 and add our SVN revision + */ /* Format of CSD : SPMajor - SPMinor */ - CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); + CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); CmNtCSDReleaseType = 0;
- /* Set Service Pack data for Service Pack 2 */ + /* Set Service Pack data for Service Pack 1 */ CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; if (!(CmNtCSDVersion & 0xFFFF0000)) {
So, just to know, does SP2 change a lot internally ? Or is it just a matter of few added / removed APIs ? (at least, checking differences in the ntoskrnl exports, there are 2 more APIs, undocumented; no differences in the exported APIs in ntdll, one more API in kernel32). I can check other core dlls to see whether there are big changes or not.
Hermes.
-----Message d'origine----- De : ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org] De la part de Alex Ionescu Envoyé : jeudi 13 février 2014 01:08 À : ros-dev@reactos.org; ros-diffs@reactos.org Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
SP2 was not out when we made the choice.
And before we move to SP2, I'd rather move to Win 7 =)
-- Best regards, Alex Ionescu
-----Original Message----- From: ros-diffs-bounces@reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca@svn.reactos.org Sent: Wednesday, February 12, 2014 2:58 PM To: ros-diffs@reactos.org Subject: [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
Author: hbelusca Date: Wed Feb 12 22:58:13 2014 New Revision: 62142
URL: http://svn.reactos.org/svn/reactos?rev=62142&view=rev Log: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
Modified: trunk/reactos/boot/bootdata/hivesys.inf trunk/reactos/include/psdk/ntverp.h trunk/reactos/ntoskrnl/ex/init.c
Modified: trunk/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?r ev=62142&r1=62141&r2=62142&view=diff ============================================================================ == --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1143,8 +1143,8 @@ ; ReactOS specific - by default we report ourselves as Server for the user, ; but we can also report as Workstation if some application needs it.
HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWo rkstation",0x00010001,0x00000000 -; Some installers check for SP2 -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x0 0000200 +; Some installers check for SP1 +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001 +,0x00000100
HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders ",2,"schannel.dll"
HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00 000012
Modified: trunk/reactos/include/psdk/ntverp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=6 2142&r1=62141&r2=62142&view=diff ============================================================================ == --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -14,10 +14,10 @@ */
// -// Windows NT Build 3790.3959 +// Windows NT Build 3790.1830 // #define VER_PRODUCTBUILD 3790 -#define VER_PRODUCTBUILD_QFE 3959 +#define VER_PRODUCTBUILD_QFE 1830
// // Windows NT Version 5.2
Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=6214 2&r1=62141&r2=62142&view=diff ============================================================================ == --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1072,12 +1072,12 @@ /* Setup initial system settings */ CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector);
- /* Load static defaults for Service Pack 2 and add our SVN revision */ + /* Load static defaults for Service Pack 1 and add our SVN revision + */ /* Format of CSD : SPMajor - SPMinor */ - CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); + CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); CmNtCSDReleaseType = 0;
- /* Set Service Pack data for Service Pack 2 */ + /* Set Service Pack data for Service Pack 1 */ CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; if (!(CmNtCSDVersion & 0xFFFF0000)) {
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
If you would like to provide a list of:
1) NTDLL 2) KERNEL32 3) ADVAPI32 4) NTOSKRNL 5) HAL
Export changes, that would be a good start.
Do you have IDA Pro?
-- Best regards, Alex Ionescu
-----Original Message----- From: ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org] On Behalf Of Hermès BÉLUSCA - MAÏTO Sent: Thursday, February 13, 2014 2:47 AM To: 'ReactOS Development List' Subject: Re: [ros-dev] [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
So, just to know, does SP2 change a lot internally ? Or is it just a matter of few added / removed APIs ? (at least, checking differences in the ntoskrnl exports, there are 2 more APIs, undocumented; no differences in the exported APIs in ntdll, one more API in kernel32). I can check other core dlls to see whether there are big changes or not.
Hermes.
-----Message d'origine----- De : ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org] De la part de Alex Ionescu Envoyé : jeudi 13 février 2014 01:08 À : ros-dev@reactos.org; ros-diffs@reactos.org Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
SP2 was not out when we made the choice.
And before we move to SP2, I'd rather move to Win 7 =)
-- Best regards, Alex Ionescu
-----Original Message----- From: ros-diffs-bounces@reactos.org [mailto:ros-diffs-bounces@reactos.org] On Behalf Of hbelusca@svn.reactos.org Sent: Wednesday, February 12, 2014 2:58 PM To: ros-diffs@reactos.org Subject: [ros-diffs] [hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
Author: hbelusca Date: Wed Feb 12 22:58:13 2014 New Revision: 62142
URL: http://svn.reactos.org/svn/reactos?rev=62142&view=rev Log: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
Modified: trunk/reactos/boot/bootdata/hivesys.inf trunk/reactos/include/psdk/ntverp.h trunk/reactos/ntoskrnl/ex/init.c
Modified: trunk/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?r ev=62142&r1=62141&r2=62142&view=diff ============================================================================ == --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1143,8 +1143,8 @@ ; ReactOS specific - by default we report ourselves as Server for the user, ; but we can also report as Workstation if some application needs it.
HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWo rkstation",0x00010001,0x00000000 -; Some installers check for SP2 -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x0 0000200 +; Some installers check for SP1 +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001 +,0x00000100
HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders ",2,"schannel.dll"
HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00 000012
Modified: trunk/reactos/include/psdk/ntverp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=6 2142&r1=62141&r2=62142&view=diff ============================================================================ == --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -14,10 +14,10 @@ */
// -// Windows NT Build 3790.3959 +// Windows NT Build 3790.1830 // #define VER_PRODUCTBUILD 3790 -#define VER_PRODUCTBUILD_QFE 3959 +#define VER_PRODUCTBUILD_QFE 1830
// // Windows NT Version 5.2
Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=6214 2&r1=62141&r2=62142&view=diff ============================================================================ == --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1072,12 +1072,12 @@ /* Setup initial system settings */ CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector);
- /* Load static defaults for Service Pack 2 and add our SVN revision */ + /* Load static defaults for Service Pack 1 and add our SVN revision + */ /* Format of CSD : SPMajor - SPMinor */ - CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); + CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); CmNtCSDReleaseType = 0;
- /* Set Service Pack data for Service Pack 2 */ + /* Set Service Pack data for Service Pack 1 */ CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; if (!(CmNtCSDVersion & 0xFFFF0000)) {
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
On 13.02.2014 4:08, Alex Ionescu wrote:
SP2 was not out when we made the choice.
And before we move to SP2, I'd rather move to Win 7 =)
\o/ for moving to Win7. Seriously.
Regards, Aleksey Bragin
no!! Or, at least, please try to maintain compatibility with XP/2003 as much as possible!
On Thu, Feb 13, 2014 at 3:04 PM, Aleksey Bragin aleksey@reactos.org wrote:
On 13.02.2014 4:08, Alex Ionescu wrote:
SP2 was not out when we made the choice.
And before we move to SP2, I'd rather move to Win 7 =)
\o/ for moving to Win7. Seriously.
Regards, Aleksey Bragin
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
-
Aleksey Bragin -
Alex Ionescu -
Hermès BÉLUSCA - MAÏTO -
Javier Agustìn Fernàndez Arroyo