Re: [ros-dev] [ros-diffs] [tkreuzer] 44274: Mm64BitPhysicalAddress is a BOOLEAN, not a PBOOLEAN

[Alexander Potashev]

Hi,
Ok, commenting here...

MSDN says that Mm64BitPhysicalAddress is PBOOLEAN:
http://msdn.microsoft.com/en-us/library/bb648424.aspx

So, there should be another BOOLEAN variable, and
Mm64BitPhysicalAddress should point to it.



Alexander


2009/11/23  <tkreuzer(a)svn.reactos.org>rg>:
>   Author: tkreuzer
>  Date: Mon Nov 23 21:44:21 2009
>  New Revision: 44274
>
>  URL: http://svn.reactos.org/svn/reactos?rev=44274&view=rev
>  Log:
>  Mm64BitPhysicalAddress is a BOOLEAN, not a PBOOLEAN
>
>  Modified:
>     branches/ros-amd64-bringup/reactos/ntoskrnl/mm/mminit.c
>
>  Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/mm/mminit.c
>  URL:
> http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk…
>  ==============================================================================
>  --- branches/ros-amd64-bringup/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original)
>  +++ branches/ros-amd64-bringup/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Mon Nov 23
> 21:44:21 2009
>  @@ -48,7 +48,7 @@
>      "LoaderXIPRom      "
>   };
>
>  -PBOOLEAN Mm64BitPhysicalAddress = FALSE;
>  +BOOLEAN Mm64BitPhysicalAddress = FALSE;
>   ULONG MmReadClusterSize;
>   //
>   // 0 | 1 is on/off paging, 2 is undocumented
>
>
>

[Timo Kreuzer]

Alexander Potashev wrote:
>   Hi,
>  Ok, commenting here...
>
>  MSDN says that Mm64BitPhysicalAddress is PBOOLEAN:
>  http://msdn.microsoft.com/en-us/library/bb648424.aspx
>
>  So, there should be another BOOLEAN variable, and
>  Mm64BitPhysicalAddress should point to it.
>     
No, that's just because of the way msvc handles imports.
In fact the variable is a BOOLEAN, you just treat it as PBOOLEAN when
you import it from your driver.
A correct definition would be "__declspec(dllimport) BOOLEAN
Mm64BitPhysicalAddress;", which would internally be treated as a
reference to "_imp__Mm64BitPhysicalAddress", which is a pointer to the
real variable stored in ntoskrnl. This way it must be handled on gcc.

Regards,
Timo