Re: [ros-svn] [hpoussin] 19059: When a driver is a legacy driver, call its AddDevice function with a NULL Pdo

[Hartmut Birr]

hpoussin(a)svn.reactos.com wrote:
>   When a driver is a legacy driver, call its AddDevice
> function with a NULL Pdo
>
>
>  Updated files:
>  trunk/reactos/drivers/bus/acpi/ospm/acpisys.c
>  trunk/reactos/drivers/input/i8042prt/i8042prt.c
>  trunk/reactos/drivers/input/kbdclass/kbdclass.c
>  trunk/reactos/drivers/input/mouclass/mouclass.c
>  trunk/reactos/ntoskrnl/io/device.c
>
>  _______________________________________________
>  Ros-svn mailing list
>  Ros-svn(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-svn
>
>     
This change breaks installing reactos within qemu for me. Reactos
crashes at the second boot:

The problem seems to be caused by the following file: ntoskrnl.exe

Technical information:

*** STOP: 0x0000001E (0xc0000005,0x8003366e,0x00000000,0x00000010)

***    ntoskrnl.exe - Address 0x8003366e base at 0x80000000, DateStamp 0x0

Page Fault Exception: 14(0)
Processor: 0 CS:EIP 8:8003366e <ntoskrnl.exe:3366e
(ntoskrnl/io/device.c:726 (IoGetAttachedDevice))>
cr2 10 cr3 22000 Proc: 80804ba0 Pid: 4 <System> Thrd: 80805630 Tid: 0
DS 23 ES 23 FS 30 GS 0
EAX: 00000000   EBX: 80827e78   ECX: 00000000
EDX: 000000e9   EBP: 80108ac0   ESI: 80827748   ESP: 80108a48
EDI: 00076514   EFLAGS: 00200292 kESP 80108a48 kernel stack base 80106000
Frames:
<ntoskrnl.exe:32fc5 (ntoskrnl/io/device.c:344
(IoAttachDeviceToDeviceStackSafe))>
<ntoskrnl.exe:32f71 (ntoskrnl/io/device.c:319
(IoAttachDeviceToDeviceStack))>
<acpi.sys:174a1 (drivers/bus/acpi/ospm/acpisys.c:146 (ACPIAddDevice))>
<ntoskrnl.exe:32c0b (ntoskrnl/io/device.c:88 (IopInitializeDevice))>
<ntoskrnl.exe:c63d2 (ntoskrnl/io/driver.c:1269
(IopInitializeBuiltinDriver))>
<ntoskrnl.exe:3b19e (ntoskrnl/io/driver.c:1332 (IopInitializeBootDrivers))>
<ntoskrnl.exe:c6d3d (ntoskrnl/io/iomgr.c:391 (IoInit2))>
<ntoskrnl.exe:c3857 (ntoskrnl/ex/init.c:646 (ExpInitializeExecutive))>
<ntoskrnl.exe:6866 (ntoskrnl/ke/main.c:100 (KiSystemStartup))>
<ntoskrnl.exe:c1857 (ntoskrnl/ke/main.c:294 (_main))>
<0>

- Hartmut

[Hervé Poussineau]

Hello,

Since revision 19059, lines 146 and 147 in
reactos/drivers/bus/acpi/ospm/acpisys.c are commented out:

146: //DeviceExtension->Common.Ldo =
147: //  IoAttachDeviceToDeviceStack(Fdo, PhysicalDeviceObject);

So, I suppose that something is wrong in your local copy.
Try to update reactos/drivers/bus/acpi, and make acpi_clean && make

Hervé


-----Message d'origine-----
De : ros-dev-bounces(a)reactos.org [mailto:[e-mail]] De la
part de Hartmut Birr
Envoyé : samedi 12 novembre 2005 14:10
À : ros-dev(a)reactos.org
Objet : [ros-dev] Re: [ros-svn] [hpoussin] 19059: When a driver is a legacy
driver, call its AddDevice function with a NULL Pdo

hpoussin(a)svn.reactos.com wrote:
>   When a driver is a legacy driver, call its AddDevice
> function with a 
>  NULL Pdo
>
>
>  Updated files:
>  trunk/reactos/drivers/bus/acpi/ospm/acpisys.c
>  trunk/reactos/drivers/input/i8042prt/i8042prt.c
>  trunk/reactos/drivers/input/kbdclass/kbdclass.c
>  trunk/reactos/drivers/input/mouclass/mouclass.c
>  trunk/reactos/ntoskrnl/io/device.c
>
>  _______________________________________________
>  Ros-svn mailing list
>  Ros-svn(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-svn
>
>     
This change breaks installing reactos within qemu for me. Reactos crashes at
the second boot:

The problem seems to be caused by the following file: ntoskrnl.exe

Technical information:

*** STOP: 0x0000001E (0xc0000005,0x8003366e,0x00000000,0x00000010)

***    ntoskrnl.exe - Address 0x8003366e base at 0x80000000, DateStamp 0x0

Page Fault Exception: 14(0)
Processor: 0 CS:EIP 8:8003366e <ntoskrnl.exe:3366e
(ntoskrnl/io/device.c:726 (IoGetAttachedDevice))>
cr2 10 cr3 22000 Proc: 80804ba0 Pid: 4 <System> Thrd: 80805630 Tid: 0 DS 23
ES 23 FS 30 GS 0
EAX: 00000000   EBX: 80827e78   ECX: 00000000
EDX: 000000e9   EBP: 80108ac0   ESI: 80827748   ESP: 80108a48
EDI: 00076514   EFLAGS: 00200292 kESP 80108a48 kernel stack base 80106000
Frames:
<ntoskrnl.exe:32fc5 (ntoskrnl/io/device.c:344
(IoAttachDeviceToDeviceStackSafe))>
<ntoskrnl.exe:32f71 (ntoskrnl/io/device.c:319
(IoAttachDeviceToDeviceStack))>
<acpi.sys:174a1 (drivers/bus/acpi/ospm/acpisys.c:146 (ACPIAddDevice))>
<ntoskrnl.exe:32c0b (ntoskrnl/io/device.c:88 (IopInitializeDevice))>
<ntoskrnl.exe:c63d2 (ntoskrnl/io/driver.c:1269
(IopInitializeBuiltinDriver))> <ntoskrnl.exe:3b19e
(ntoskrnl/io/driver.c:1332 (IopInitializeBootDrivers))> <ntoskrnl.exe:c6d3d
(ntoskrnl/io/iomgr.c:391 (IoInit2))>
<ntoskrnl.exe:c3857 (ntoskrnl/ex/init.c:646 (ExpInitializeExecutive))>
<ntoskrnl.exe:6866 (ntoskrnl/ke/main.c:100 (KiSystemStartup))>
<ntoskrnl.exe:c1857 (ntoskrnl/ke/main.c:294 (_main))> <0>

- Hartmut
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

[Hartmut Birr]

Hervé Poussineau wrote:
>   Hello,
>
>  Since revision 19059, lines 146 and 147 in
>  reactos/drivers/bus/acpi/ospm/acpisys.c are commented out:
>
>  146: //DeviceExtension->Common.Ldo =
>  147: //  IoAttachDeviceToDeviceStack(Fdo, PhysicalDeviceObject);
>
>  So, I suppose that something is wrong in your local copy.
>  Try to update reactos/drivers/bus/acpi, and make acpi_clean && make
>
>  Hervé
>
>     
There was a an update error in reactos.dff. Reactos..cab wasn't rebuild.

- Hartmut